[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c25cd376b6: [LLDB][GUI] Add Create Target form (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362450. OmarEmaraDev added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many inline comments with simple fixes! Very close. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2658 + TargetCreateFormDelegate(Debugger &debugger) : m

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I still can't get remote debugging to work unfortunately, or maybe I don't understand it really. The way I understand it is as follows: - If the remote file is specified, then that means we are creating a target for remote debugging. - If the remote file doesn't ex

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362189. OmarEmaraDev added a comment. - Rebase on main. - Add basic remote debugging support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/sourc

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg added a comment. In D106192#2894392 , @OmarEmaraDev wrote: >> Are you going to land the other smaller diffs first and then update this one >> after hey have landed? > > Yes. There is much dependency between patches, so the smaller ones will hav

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. > Are you going to land the other smaller diffs first and then update this one > after hey have landed? Yes. There is much dependency between patches, so the smaller ones will have to land first then we will rebase this one on main. Also, notice that the smaller p

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg added a comment. In D106192#2893862 , @OmarEmaraDev wrote: > I am currently breaking this patch into smaller independent viable patches as > suggested. That will make reviews much easier. Are you going to land the other smaller diffs first an

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Thanks @DavidSpickett! I will look into this and let you know how it goes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 ___ lld

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I am currently breaking this patch into smaller independent viable patches as suggested. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1309 +FileSpec file_spec(m_content); +FileSystem::Instance().Resolve(file_spec); +return file_

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

DavidSpickett added a comment. > This doesn't support remote files yet, I am still having trouble testing > those. If you want to set that up we have some docs for it: https://lldb.llvm.org/use/remote.html https://lldb.llvm.org/use/qemu-testing.html This is mostly how I work on AArch64 changes.

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Great start! Many inlined comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1309 +FileSpec file_spec(m_content); +FileSystem::Instance().Res

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This doesn't support remote files yet, I am still having trouble testing those. Also, there is also an unrelated clang-format change, not sure if I should revert it or keep it. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a Create Target form for the LLDB GUI. Additionall