This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
jankratochvil marked an inline comment as done.
Closed by commit rG72748488addd: [lldb] Fix editline unicode on Linux (authored
by jankratochvil).
Repository:
rG LLV
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lldb/tools/driver/Driver.cpp:872
+ ::setlocale(LC_ALL, "");
+ ::setlocale(LC_CTYPE, "");
+
jankratochvil wrote:
> teemperor
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: lldb/tools/driver/Driver.cpp:871
int main(int argc, char const *argv[]) {
+ ::setlocale(LC_ALL, "");
+ ::setlocale(LC_CTYPE, "");
teemperor wrote:
> Can you make t
jankratochvil updated this revision to Diff 358047.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105779/new/
https://reviews.llvm.org/D105779
Files:
lldb/source/Core/IOHandlerCursesGUI.cpp
lldb/tools/driver/Driver.cpp
Index: lldb/tools/driver
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
In retrospective that's a rather obvious fix. Thanks!
This LGTM, but I think this deserves a comment about why we are setting this.
Usually LLVM avoids the locale-dependent fun
jankratochvil updated this revision to Diff 357799.
jankratochvil edited the summary of this revision.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105779/new/
https://reviews.llvm.org/D105779
Files:
lldb/source/Core/IOHandlerCursesGUI.cpp
lldb
jankratochvil created this revision.
jankratochvil added reviewers: teemperor, nealsid, labath.
jankratochvil added a project: LLDB.
Herald added a subscriber: JDevlieghere.
jankratochvil requested review of this revision.
[[ https://lists.llvm.org/pipermail/lldb-dev/2021-July/016961.html | [lldb-
