clayborg added inline comments.
Comment at: lldb/include/lldb/Target/TraceHTR.h:41
+ size_t m_num_instructions;
+ std::unordered_map m_func_calls;
+ friend llvm::json::Value toJSON(const HTRBlockMetadata &metadata);
wallace wrote:
> jj10306 wrote:
> > clayborg
jj10306 marked 6 inline comments as done.
jj10306 added inline comments.
Comment at: lldb/include/lldb/Target/TraceHTR.h:3
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
clayborg wrote:
> Maybe add a definition
wallace added inline comments.
Comment at: lldb/include/lldb/Target/TraceHTR.h:29
+/// Metadata is initially populated in Layer 1 and merged as blocks are merged
+class HTRBlockMetadata {
+public:
This is a very expensive structure if you are going to have for La
wallace added inline comments.
Comment at: lldb/include/lldb/Target/TraceHTR.h:31
+public:
+ HTRBlockMetadata(Thread &thread, TraceInstruction curr_instruction,
+ llvm::Optional next_instruction);
const TraceInstruction &curr_instruction
to a
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/Target/TraceHTR.h:1-2
+//===-- TraceHTR.h -*- C++
+//-*-===//
+//
jj10306 created this revision.
jj10306 added reviewers: wallace, clayborg.
Herald added subscribers: dang, mgorny.
jj10306 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This diff enables visualization of Intel PT traces by converting a su
