[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0321dbc87e43: [LLDB][GUI] Add Process Attach form (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D105655

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2425 +return true; + } + clayborg wrote: > Should be easy to verify if it is needed or not. If it is, we will need to > add it back. Looks like it is actually needed. I

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358766. OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. - Manually continue if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D10565

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I like the new detach/kill dialog as it incorporates many of your features that you added to the forms! Very close, just a few minor issues and this will be good to go. ==

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Two actions with an option: F17916215: 20210713-214929.png Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1838 + + FieldDelegateUP &GetField(int field_index) { return m_fields[field_index]; } --

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358399. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Return raw pointers instead of unique ones. - Add Show Advance Settings option. - Allow detaching and killing at the same time. - Allow detaching while keeping process

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1838 + + FieldDelegateUP &GetField(int field_index) { return m_fields[field_index]; } ---

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Updated UI: F17912164: 20210713-170719.png Kill/Detach form. F17912163: 20210713-170734.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1056

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358268. OmarEmaraDev added a comment. - Add kill/detach form. - Fix forms with no fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D105655 Files: lldb/source/Co

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Currently working on the detach/kill form. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2346 + return; + +if (process->GetShouldDetach()) { clayborg wrote: > We might w

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358228. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Use unique pointers for field delegates. - Fix typos in Select methods. - Set the process name to the main executable name by default. - Turn plugin name into a choice

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1921 protected: std::vector m_fields; std::vector m_actions; Do these actually n

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. I initially created two forms for attach by name and attach by PID, because the options were divided between them. Today I tried to reimplement that such that it is a single form with a choices field at the top that determine

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a form window to attach a process, either by PID o