[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2839256 , @jankratochvil wrote: > On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: > -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver > It uses `lldb/tools/debugserver/source/RNBSocket.c

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver It uses `lldb/tools/debugserver/source/RNBSocket.cpp` (if I mess up the source file it does not build). The build does not need this `Reso

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added inline comments. Comment at: lldb/tools/debugserver/source/RNBSocket.cpp:44 } else if (strcmp(hostname, "*") == 0) { addr = htonl(INADDR_ANY); return true; Here it should use `AI_PASSIVE` instead. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838600 , @jankratochvil wrote: > In D104856#2838571 , @teemperor > wrote: > >> The file is part of `debugserver` which is Darwin exclusive and is also only >> compiled/use

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838571 , @teemperor wrote: > The file is part of `debugserver` which is Darwin exclusive and is also only > compiled/used when you're on Darwin. It's also kind of its own thing: it > isn't using LLVM libraries

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838526 , @jankratochvil wrote: > In D104856#2838515 , @teemperor > wrote: > >> (Nit: this is from the Linux manpage but this code is only compiled on >> Darwin). > > Why d

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838515 , @teemperor wrote: > (Nit: this is from the Linux manpage but this code is only compiled on > Darwin). Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor edited reviewers, added: jasonmolenda; removed: k8stone, beanz. teemperor added a comment. (Nit: this is from the Linux manpage but this code is only compiled on Darwin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://r

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

serge-sans-paille created this revision. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to the manpage The gethostbyname*() and gethostbyaddr*() functions are obsolete. Applications should use getaddrinfo(3