[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29cc50e17a68: [LLDB][GUI] Add initial forms support (authored by OmarEmaraDev, committed by teemperor). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This looks good. Lets get this in so we can start using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Full example: F17684763: 20210630-220202.mp4 Example API definition for the above example: class TestFormDelegate : public FormDelegate { public: TestFormDelegate() { m_text_field = AddTextField("Text", "The big br

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 355672. OmarEmaraDev added a comment. This revision is now accepted and ready to land. - Add contextual scrolling support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. - Scrolling was temporarily removed from the patch. It was causing issues with fields that change in size. I will reimplement it as contextual scrolling directly. - Action buttons weren't moved to the window border as d

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 355364. OmarEmaraDev added a comment. This revision is now accepted and ready to land. - Rewrite internal field navigation. - Rewrite form window drawing. Form delegate no longer have drawing routines. - Add global error messages. - Add action bar. Form d

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Not available in this patch yet: - Global error messages. - Contextual scrolling. - Action bar. - Auto completion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 354364. OmarEmaraDev added a comment. - Add Surface type. - Add Pad and SubPad types. - Implement dynamic scrolling. - Implement per-field validation and error messages. - Implement File field. - Implement Directory field. - Implement List field. - Refact

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. In D104395#2836661 , @OmarEmaraDev wrote: > Since we are still working on this diff. I will add the other form > functionality I have been working on here as well if you don't mind. Sure thing! Comment at:

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Since we are still working on this diff. I will add the other form functionality I have been working on here as well if you don't mind. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1396-1405 + // ___

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. Just a few questions on how buttons should be handled since we are making new sweeping changes! See inlined comments and let me know what you think Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1396-1405 + // ___

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353783. OmarEmaraDev added a comment. - Remove Field type and use FieldDelegate directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Cor

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. In D104395#2828065 , @OmarEmaraDev wrote: > @clayborg I tried implementing scrolling mechanisms as suggested. My first > trial essentially defined a "visible area" rectangle which gets updated with > every time the selection c

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. @clayborg I tried implementing scrolling mechanisms as suggested. My first trial essentially defined a "visible area" rectangle which gets updated with every time the selection changes, then when it comes to drawing, each field checks if it is completely contained

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353087. OmarEmaraDev added a comment. - Add form pages. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Core/IOHandlerCurse

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Lets try the diamond character for the boolean stuff unless anyone has any objections. Maybe handle a few more keys for the boolean field as suggested in the comments. This will

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352778. OmarEmaraDev added a comment. - Always scroll left on removing a character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Core/IOHa

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1108 + window.AttributeOn(A_REVERSE); +window.PutChar(m_content ? 'X' : ' '); +if (is_active) clayborg wrote: > We could use ACS_DIAMOND or ACS_BULLET? Check it o

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352761. OmarEmaraDev added a comment. - Remove PutCStringTruncatedWidth, use a character limit instead. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. > did you consider implementing each field as a Window? My first implementation was actually done completely with fields as sub windows. However, two things deterred me from taking that approach. - While sub-windows in ncurses are mostly sub-spaces with their own lo

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. Looks very nice. A few things to consider here, and I am open to everyone's opinion here, did you consider implementing each field as a Window? It seems that a lot of the window code is duplicated, DrawBox for one. I know we would need to make modifications to the Win

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. An example form: F17429353: 20210616-174753.mp4 class TestFormDelegate : public FormDelegate { public: TestFormDelegate() { m_path_field = AddTextField("Path", 20, Point(4, 2

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds initial support for forms and dialogs for the LLDB