[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bebc0b177d0: [lldb] Decouple ObjCLanguage from Symtab (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord updated this revision to Diff 353484. bulbazord added a comment. Addressed comments! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 Files: lldb/include/lldb/Target/Language.h lldb/source

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2825199 , @bulbazord wrote: > ping! Sorry, feel free to me directly sooner :) I ran some benchmarks and this changed the

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord updated this revision to Diff 351696. bulbazord added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 Files: lldb/include/lldb/Target/Language.h lldb/source/Br

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

shafik added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:104 + // We also return the FunctionNameType of each possible name. + std::vector> GetMethodNameVariants(ConstString method_name) const override; teemperor wrote: > Co

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2811834 , @jingham wrote: > This looks pretty good to me. > > It's a little awkward in InitNameIndexes that we look up the v

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

jingham added a comment. This looks pretty good to me. It's a little awkward in InitNameIndexes that we look up the various NameToSymbolIndex maps by eFunctionNameType, use the function name type again to sort the names & index pairs into the bucket we looked up before. I wonder if that could

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. Herald added a subscriber: JDevlieghere. Note that this is working towards solving the same problem as D103210 but it does so in a different way. Instead of repurposing the old diff, I made a new one so it is a little easier to compa

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord created this revision. bulbazord added a reviewer: teemperor. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We can extend/modify `GetMethodNameVariants` to suit our purposes here. Wha