[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a2d4f3f24a3: [lldb] Enable Rust v0 symbol demangling (authored by Alexander Mols , committed by teemperor). Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

clayborg added a comment. Yes, good to go! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. @teemperor @clayborg Is this good to go? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. And thank you for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! (And congrats on your first patch) I'll land this for you next week just to give the others another chance to take a look. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm updated this revision to Diff 351481. asm marked an inline comment as done. asm added a comment. code style fixes, use modern log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 Files: lldb/include/

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

clayborg added a comment. Once teemperor's issues are resolved this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} asm wrote: > teemperor wrote: > > Could you do me a favour and change your test functions to LLDB's code > > style, so `mangl

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} teemperor wrote: > Could you do me a favour and change your test functions to LLDB's code style, > so `mangled_name` as a variable

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added a comment. This seems reasonable to me, but I'll leave this open for a while in case someone that knows more about Rust mangling shows up. Otherwise I'll accept this next week. Comment at: lldb/source/Core/Mangled.cpp:213 +else + LLDB_LOGF(log, "deman

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm created this revision. asm added reviewers: clayborg, wallace. Herald added subscribers: pengfei, JDevlieghere. asm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rust's v0 name mangling scheme [1] is easy to disambiguate from other na