[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

wallace added a comment. I'll redo this in a different patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

clayborg added a comment. I mostly commented on ThreadTrace.h and we should resolve the questions in there before reviewing the rest of this patch. Comment at: lldb/include/lldb/Target/ThreadTrace.h:44-45 + /// \param[in] start_position + /// The instruction position to

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

vsk added a comment. I think this is moving in the right direction! However, the way ThreadTrace is specified still raises the same scalability concerns (see inline). The "instruction index" concept doesn't seem sufficient. Decoding needs to be done in two stages: a separate "trace index" conce

[Lldb-commits] [PATCH] D103588: [trace] Create a top level ThreadTrace class

wallace updated this revision to Diff 351344. wallace edited the summary of this revision. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103588/new/ https://reviews.llvm.org/D103588 Files: lldb/include/lldb/Target/T