This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf9f21a28be1: [trace][intel-pt] Create basic SB API
(authored by W
clayborg accepted this revision.
clayborg added a comment.
Looks good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
___
lldb-commits mailing list
lldb-commit
wallace updated this revision to Diff 352835.
wallace marked 2 inline comments as done.
wallace added a comment.
address comments:
- use llvm::ArrayRef where needed
- improved documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
a few nits!
Comment at: lldb/include/lldb/API/SBTarget.h:847
+ /// \return
+ /// The trace object. It might be undefined.
+ lldb::SBTrace GetTrace();
-
wallace added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
wallace updated this revision to Diff 350725.
wallace marked 11 inline comments as done.
wallace added a comment.
Herald added a subscriber: mgorny.
address all comments. I appreciate your feedback!
- I ended up deleting all the deprecated methods, as I doubt anyone is using
them. Intel wrote th
mib added a comment.
Took a look at the SBAPI changes and left few comments but overall, that part
looked good to me. It would be nice if you could delete the depreciated
method/class.
Comment at: lldb/bindings/interface/SBTrace.i:32-51
+ /// deprecated
void StopTrace(SBE
JDevlieghere added inline comments.
Comment at: lldb/bindings/interface/SBTrace.i:32-51
+ /// deprecated
void StopTrace(SBError &error,
lldb::tid_t thread_id);
+ /// deprecated
void GetTraceConfig(SBTraceOptions &options,
SBError
vsk requested changes to this revision.
vsk added a subscriber: mib.
vsk added a comment.
This revision now requires changes to proceed.
Thanks, excited to see this work progress!
Comment at: lldb/include/lldb/Target/Target.h:1129
/// The trace object. It might be undefine
wallace updated this revision to Diff 350647.
wallace added a comment.
improved the documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
Files:
lldb/bindings/interface/SBStructuredData.i
lldb
wallace updated this revision to Diff 350641.
wallace marked an inline comment as done.
wallace added a comment.
address all comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
Files:
lldb/bindings
wallace marked 9 inline comments as done.
wallace added inline comments.
Comment at: lldb/include/lldb/Target/Target.h:1137-1141
+ llvm::Expected CreateTrace();
+
+ /// If a \a Trace object is present, this returns it, otherwise a new Trace
is
+ /// created with \a Trace::Cre
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/API/SBTrace.h:31
+
+ /// Start tracing a live process using a provided configuration.
///
wallace updated this revision to Diff 350493.
wallace marked an inline comment as done.
wallace added a comment.
address all comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
Files:
lldb/bindings
wallace marked 18 inline comments as done.
wallace added inline comments.
Comment at: lldb/include/lldb/API/SBStructuredData.h:103
friend class SBBreakpointName;
+ friend class SBTrace;
clayborg wrote:
> Is this needed?
yes, to access the actual StructuredD
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/include/lldb/API/SBProcess.h:97
+ /// Deprecated
lldb::SBThread GetSelectedThread() const;
Remove? This is not depre
wallace updated this revision to Diff 349376.
wallace added a comment.
rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103500/new/
https://reviews.llvm.org/D103500
Files:
lldb/bindings/interface/SBStructuredData.i
lldb/bindings/interface/
wallace created this revision.
wallace added a reviewer: clayborg.
Herald added a subscriber: dang.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This adds a basic SB API for creating and stopping traces.
Note: This doesn't add an
18 matches
Mail list logo
