[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-10-23 Thread Sylvestre Ledru via Phabricator via lldb-commits
sylvestre.ledru added a comment. > Maybe it would be better to disable the binary completely (in cmake) for > unsupported architectures instead? +1, having an error message like "lldb isn't supported on arch foo" would save hours of work :) CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-10-18 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This will create an lldb-server that crashes as soon as it tries to debug something. Maybe it would be better to disable the binary completely (in cmake) for unsupported architectures instead? Comment at: lldb/source/Plugins/Process/Linux/NativeRegiste

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-10-17 Thread John Paul Adrian Glaubitz via Phabricator via lldb-commits
glaubitz added a comment. It seems we need this change on all architectures except arm, arm64, ppc64el, s390x and x86_64. Those are the only ones which implement NativeRegisterContextLinux_$ARCH. See: https://github.com/llvm/llvm-project/tree/main/lldb/source/Plugins/Process/Linux CHANGES SI

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-10-17 Thread John Paul Adrian Glaubitz via Phabricator via lldb-commits
glaubitz added a comment. This failure affects 32-bit PowerPC as well. Can we get this fixed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102872/new/ https://reviews.llvm.org/D102872 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-21 Thread Khem Raj via Phabricator via lldb-commits
raj.khem added a comment. In D102872#2773106 , @DavidSpickett wrote: > I assume this is caused by the removal of the specific > `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but > you're going to connect to another debug server (g

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-21 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I assume this is caused by the removal of the specific `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but you're going to connect to another debug server (gdb, custom stub etc.). The problem with doing it this way is then if you build on a sup

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-20 Thread Khem Raj via Phabricator via lldb-commits
raj.khem updated this revision to Diff 346855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102872/new/ https://reviews.llvm.org/D102872 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp ==

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

2021-05-20 Thread Khem Raj via Phabricator via lldb-commits
raj.khem created this revision. raj.khem added a project: LLDB. Herald added subscribers: JDevlieghere, atanasyan, arichardson, sdardis. raj.khem requested review of this revision. Herald added a subscriber: lldb-commits. This helps fixing lldb-server build regression > /mnt/b/yoe/master/build/tm