This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
werat marked an inline comment as done.
Closed by commit rG0bab7b26f4d9: [lldb] Encode `bool` as unsigned int (authored
by werat).
Repository:
rG LLVM Github Monorep
werat marked 2 inline comments as done.
werat added a comment.
Thanks for a quick review!
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:21
-# (http://llvm.org/pr21800)
-@skipIfWindows
def test_and_run_command(self):
teemperor wro
werat updated this revision to Diff 346161.
werat added a comment.
Keep @skipIfWindows for now
Add mroe checks in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102685/new/
https://reviews.llvm.org/D102685
Files:
lldb/source/Plugins/TypeSys
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
Nice, and it's not even my birthday. Just some nits that don't need another
round of review.
Comment at: lldb/test/API/lang/cp
werat created this revision.
werat added a reviewer: teemperor.
werat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
`bool` is considered to be unsigned according to
`std::is_unsigned::value` (and `Type::GetTypeInfo`). Encoding it as
sig
