[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In D102092#2771746 , @kastiglione wrote: > @thakis thanks for pointing that out. I had tried `-Wall` using the clang > included with the latest version of Xcode, and that does not enable > `-Wmisleading-indentation`. I see from

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

danilaml added a comment. I remember some noise due to this option (albeit on GCC), because it stops tracking indentation when the number of lines is too big, as it is for files including TableGen'ed inc files. Not sure if there is a way to improve it. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. @thakis thanks for pointing that out. I had tried `-Wall` using the clang included with the latest version of Xcode, and that does not enable `-Wmisleading-indentation`. I see from the compiler explorer that recent clang versions do include misleading indentation di

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In both gcc and clang, -Wmisleading-indentation is part of -Wall as far as I can tell: https://godbolt.org/z/Msaz6Kb6T In which build configuration does this change have an effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. Will keep an eye on buildbots, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/D102092 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf44c6f20f5e9: [cmake] Enable -Wmisleading-indentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.l

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me if - if the build (of ~everything in the monorepo) is clean - and do please keep an eye on the buildbots when this is committed as there's likely to be cleanup here and t

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. Didn't mean to self-accept this, so I resigned as reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/D102092 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione updated this revision to Diff 343773. kastiglione added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Enable for llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. @dblaikie I have checked lldb, it builds cleanly. In the downstream swift branch of lldb there were a couple issues. I'll check llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

teemperor added a comment. I think some people are already building with this warning + -Werror so this should be fine (Apparently that list of people includes me and Stella as I fixed a warning that broke the build in https://reviews.llvm.org/D99694#2671667 ) Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

dblaikie added a comment. might as well enable it for LLVM more generally? (though probably lldb specifically, and lots of llvm more generally, would need cleanup before this is enabled? Have you checked if lldb or other parts of llvm build cleanly with this warning enabled?) Repository: rG

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, jasonmolenda. Herald added a subscriber: mgorny. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Enable `-Wmisleading-indentation` to balance