This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8fdfc1d64c51: [lldb] Add tests for DumpDataExtractor formats
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
DavidSpickett updated this revision to Diff 341811.
DavidSpickett added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101453/new/
https://reviews.llvm.org/D101453
Files:
lldb/unittests/Core/CMakeLists.txt
ll
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
FWIW, we do have a test for this named TestBuiltinFormats.py. It's using the SB
API so it's not as a direct test as this one, so I think having this too is
good.
I think this looks good
DavidSpickett added reviewers: LLDB, zturner.
DavidSpickett added a comment.
I'm looking into printing memory tags and "memory read" uses this code a lot so
I thought I'd add tests before I attempt to extend it.
If this is useful then I'll add some more covering some other key bits like
splitti
DavidSpickett updated this revision to Diff 341184.
DavidSpickett added a comment.
Herald added a subscriber: JDevlieghere.
- Remove unused cfloat include.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101453/new/
https://reviews.llvm.org/D101453
DavidSpickett created this revision.
Herald added a subscriber: mgorny.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Covering basic cases where you have 1 item on 1 line.
Apart from eFormatCharArray, where using multiple l
