[Lldb-commits] [PATCH] D100740: json

2021-04-20 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. The title should be updated on this diff as well. Set the "json" right now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 ___ lldb-co

[Lldb-commits] [PATCH] D100740: json

2021-04-20 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/LineEntry.h:94-104 + /// \param[in] compare_addresses + /// If \b true, then the addresses of the LineEntry objec

[Lldb-commits] [PATCH] D100740: json

2021-04-20 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 339044. wallace retitled this revision from "[trace] Dedup different source lines when dumping instructions + refactor" to "json". wallace added a comment. ready for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D100740: json

2021-04-18 Thread walter erquinigo via Phabricator via lldb-commits
wallace updated this revision to Diff 338435. wallace added a comment. only json is left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/Co

[Lldb-commits] [PATCH] D100740: json

2021-04-18 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100740 Files: lldb/include/lldb/Target/Trace.h lldb/source/Commands/CommandObjectTh