[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. I'm sorry about looking into it this late. I've just marked them all unsupported on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

thakis added a comment. The new tests here fall for me on macOS: [4303/4304] Running lldb shell test suite llvm-lit: /Users/thakis/src/llvm-project/lldb/test/Shell/helper/toolchain.py:126: note: using SDKROOT: '/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk' llvm-lit: /Users/th

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a2a947317bf: [lldb] [client] Implement follow-fork-mode (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny updated this revision to Diff 369949. mgorny added a comment. Rebased. Changed hw breakpoint sizes to match the normal sending code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 Files: lldb/include/lldb/Target/Process.h lldb/incl

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. In D100503#2894584 , @vadimcn wrote: > @mgorny Do your changes allow debugging both the parent and child processes > after a fork? No. This patch supports choosing either the parent or the child but it's a step in that directio

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

vadimcn added a comment. @mgorny Do your changes allow debugging both the parent and child processes after a fork? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny updated this revision to Diff 360049. mgorny added a comment. Rebased. Switched to watchpoint iterator API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/lldb-private-enu

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:5504-5513 + WatchpointList &wps = GetTarget().GetWatchpointList(); + size_t wp_count = wps.GetSize(); + for (size_t i = 0; i < wp_count; ++i) { +WatchpointSP wp = wps.Get

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:5504-5513 + WatchpointList &wps = GetTarget().GetWatchpointList(); + size_t wp_count = wps.GetSize(); + for (size_t i = 0; i < wp_count; ++i) { +WatchpointSP wp = w

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny updated this revision to Diff 356440. mgorny added a comment. Rebase. Do not run tests on NetBSD yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/lldb-private-enumerati

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added a comment. This is it! The fruit of my labor! It feels like it's... kinda small. But I guess this is because all the groundwork has been done well, and now it's just a matter of plugging it in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Implement a new target.process.follow-fork-mode setting to control LLDB's behavior on fork. If set to 'parent', the forked child is detached and parent continues being trac