[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

2021-04-22 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. The regression was due to the `help process trace` command which surprisingly ends up in `GDBRemoteCommunicationClient::SendTraceSupported` which was crashing on `libipt`-enabled builds. Fixed by: rG18a85276426b9604a9ceca8c528b694964dd8d7c

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

2021-04-22 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. It has caused a regression for Fedora buildbot (which is so far a silent one): https://lab.llvm.org/staging/#/builders/16/builds/4936 Failed Tests (2): lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py lldb-api :: tools/lldb-vscode/launch/TestVSCod

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

2021-04-21 Thread walter erquinigo via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79fbbeb41280: [lldb-vscode] Add postRunCommands (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D100340?vs=336942&id=3393

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

2021-04-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. "postRunCommands" might be clearer as "firstStopCommands"? Not sure, but I wanted to mention it. Comment at: lldb/tools/lldb-vscode/package.json:166 + "type": "array", +

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

2021-04-12 Thread walter erquinigo via Phabricator via lldb-commits
wallace created this revision. wallace added reviewers: clayborg, aadsm. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff ass postRunCommands, which are the counterpart of the preRunCommands. TThey will be executed right a