[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-31 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D100299#2917768 , @stella.stamenova wrote: > This also fails on the Windows lldb bot: Sorry I did not check (probably it sends messages to Author and not Commiter). Added there: // -gsplit-dwarf is supported only on

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added a comment. In D100299#2917598 , @jankratochvil wrote: > In D100299#2917467 , @Eric wrote: > >> Is arm hardware necessary to test this, > > In this case it is not as it does not require link

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D100299#2917467 , @Eric wrote: > Is arm hardware necessary to test this, In this case it is not as it does not require linking. Usually I find easier to run it natively than to setup all the cross-compilation libraries

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Eric Leese via Phabricator via lldb-commits
Eric added a comment. Is arm hardware necessary to test this, or can the test be modified to cross-compile to arm to see what is going on? Is there a way to determine what build target the test bot is using? In any case the broken test doesn't exercise lldb at all so it could be separated from

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D100299#2917250 , @Eric wrote: > Would it make sense to turn the split-optimized test back into an x86 only > test, or just leave it out of the change as it's not actually testing a code > path that this changed? The q

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Eric Leese via Phabricator via lldb-commits
Eric added a comment. Would it make sense to turn the split-optimized test back into an x86 only test, or just leave it out of the change as it's not actually testing a code path that this changed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D100299#2916203 , @omjavaid wrote: > This fails on 32 bit Arm > https://lab.llvm.org/buildbot/#/builders/17/builds/9595 I have reverted it as it takes some time to build on arm32 to investigate it. Repository: rG LL

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. Herald added a subscriber: JDevlieghere. This fails on 32 bit Arm https://lab.llvm.org/buildbot/#/builders/17/builds/9595 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100299/new/ https://reviews.llvm.org/D100299 ___

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

2021-07-30 Thread Jan Kratochvil via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7b8ba103a84: [lldb] [DWARF-5] Be lazier about loading .dwo files (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Heral