[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

zequanwu added inline comments. Comment at: lldb/CodeOwners.rst:132 + +Breakpad + labath wrote: > @zequanwu I accept this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9a7c22ee67: [LLDB][PDB] Fix age field in UUID in PDB file. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152189/new/ https://revie

[Lldb-commits] [PATCH] D152189: [LLDB][PDB] Fix age field in UUID in PDB file.

zequanwu created this revision. zequanwu added reviewers: labath, rnk, aganea. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There are two age fields in a PDB file. One from the PDB Stream and another

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:183 + [&](size_t task, const Twine &moduleName) { +buf[task].first = moduleName.str(); return std::make_unique( int3 wrote: > Any reason why this doesn't instead store the module n

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG960126e04a6f: [LLDB][NativePDB] Check string table in PDB files. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145115/new/ https://r

[Lldb-commits] [PATCH] D145115: [LLDB][NativePDB] Check string table in PDB files.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a subscriber: arphaman. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Usually PDB files have a string table (aka: Named

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3945136 , @glandium wrote: > Still broken: > > task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ > --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE > -D__STDC_CONSTANT_MACROS -D__

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. In D137217#3944952 , @glandium wrote: > This broke the gold plugin: > > [task 2022-11-22T21:03:29.486Z] > /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: > error: no matching function for call to

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Relanded here to match api changes at https://reviews.llvm.org/D135590 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Merge executable module's architecture into target's architecture.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24993e749ccd: [LLDB][Minidump] Merge executable module's architecture into target's… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rG531ed6d5aa65: [LTO][COFF] Use bitcode file names in lto native object file names. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D137217?vs=477014&id=477246#toc Repository:

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 477014. zequanwu added a comment. Update `Twine` argument to `const Twine&`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/BackendUtil.c

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml:74 +header: + Machine: IMAGE_FILE_MACHINE_I386 Characteristics: [ IMAGE_FILE_EXECUTABLE_IMAGE, IMAGE_FILE_LARGE_ADDRESS_AWARE, IMAGE_FILE_DLL ] -

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Use plugin.object-file.pe-coff.abi as minidump process abi when OS is Windows.

zequanwu updated this revision to Diff 477008. zequanwu edited the summary of this revision. zequanwu added a comment. Merge executable module's architecture into target's architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ http

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu updated this revision to Diff 476221. zequanwu added a comment. Use plugin.object-file.pe-coff.abi as minidump process abi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ https://reviews.llvm.org/D137873 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu added a comment. In D137873#3931888 , @mstorsjo wrote: > In D137873#3930683 , @labath wrote: > >> If that doesn't work then (besides knowing why), I'd like us try some kind >> of a single-setting solutio

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); tejohnson wrote: > MaskRay wrote: > > What if

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475895. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/Cod

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6435fe699c29: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info… (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D134066?vs=475517&id=475879#toc R

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu updated this revision to Diff 475628. zequanwu added a comment. Herald added subscribers: llvm-commits, mstorsjo. Herald added a project: LLVM. Add `settings set plugin.process.minidump.abi msvc/gnu` to override minidump abi triple. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475538. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/Backe

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu reclaimed this revision. zequanwu added a comment. Oh, they are not the same. I will work on a similar setting for minidump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ https://reviews.llvm.org/D137873 __

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu abandoned this revision. zequanwu added a comment. In D137873#3926821 , @labath wrote: > This dual environment thing is tricky.. MSVC is probably a better default, > but it would still mean that the same bugs will appear if the situation is > r

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 475517. zequanwu marked 2 inline comments as done. zequanwu added a comment. Herald added a reviewer: shafik. Move RequireCompleteType to TypeSystemClang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/ne

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104 - auto AddStream = [&](size_t Task) { + auto AddStream = [&](size_t Task, Twine File) { return std::make_unique(std::move(OS), tejohnson wrote: > I think you might need to

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475296. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/Backe

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we don't set it, clang will use itanium abi to create record layout which may cause

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 473834. zequanwu added a comment. Adding a test for incomplete record type as class static member. It returns error, because its type not required to be completed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 473829. zequanwu added a comment. Removed `PdbAstBuilder::RequireCompleteType` from `PdbAstBuilder::CreateArrayType` as it's not necessary at all. 1. When the element type info is missing, its size info is missing in pdb, which is 0. Thus we can't calculat

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:96 CompilerType method_ct = m_ast_builder.ToCompilerType(method_qt); - lldb::opaque_compiler_type_t derived_opaque_ty = m_de

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:96 CompilerType method_ct = m_ast_builder.ToCompilerType(method_qt); - lldb::opaque_compiler_type_t derived_opaque_ty = m_derived_ct.GetOpaqueQualType(); + PdbAstBuil

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu updated this revision to Diff 473336. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066 Files: lldb/source/Plugins/Sym

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fa5febaa43: [Test] Fix CHECK typo. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/new/ https://reviews.llvm.org/D137287 File

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

zequanwu added a comment. In D137287#3905474 , @probinson wrote: > Nice work! > have you verified that all the modified tests pass? naively it looks like > you'd need at least 3 different targets to run them all (windows, > webassembly, powerpc) Those

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu updated this revision to Diff 473077. zequanwu added a comment. Update to forcefully complete a record type only if it has empty debug info and is required to have complete type. I basically copied RequireCompleteType

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

zequanwu updated this revision to Diff 472833. zequanwu added a comment. Herald added subscribers: lldb-commits, nemanjai. Herald added projects: LLDB, clang-tools-extra, Flang. Fix more typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/ne

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu abandoned this revision. zequanwu added a comment. It shouldn't reach the code path to complete a class with empty debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066

[Lldb-commits] [PATCH] D136795: [LLDB] Add a `(not loaded) ` prefix to placeholder object filename to indicate they are not loaded.

zequanwu added a comment. Actually just changing the module's file spec make `image dump symtab /tmp/test/linux-x86_64` to fail because the extra string. I still prefer the previous version though `PlaceholderObjectFile` isn't first class plugin as we just checking the plugin name. Repository

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu created this revision. zequanwu added reviewers: rnk, tejohnson, mehdi_amini. Herald added subscribers: pmatos, asb, ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added projects: lld-macho, All. Herald added a reviewer: lld-

[Lldb-commits] [PATCH] D136795: [LLDB] Mark placeholder modules in `target module list` output.

zequanwu updated this revision to Diff 471337. zequanwu added a comment. - Modify file spec of placeholder object file. - Change it to "(not loaded)" which is more obvious than "(placeholder)". - Use prefix so the file extension is preseved. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0f38bb5186: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D136795: [LLDB] Mark placeholder modules in `target module list` output.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minidump may contain modules that are created from placeholder object files if they are

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3878821 , @labath wrote: > So if I understand correctly, when we deserialize incorrectly, this causes us > to misclassify some function parameters (arguments) as local variables. Is > that correct? If yes, then that

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b809cc5b69a: [LLDB][NativePDB] Improve ParseDeclsForContext time. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ https:/

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1413-1414 if (context.isTranslationUnit()) { -ParseAllNamespacesPlusChildrenOf(llvm::None); +ParseAllTypes(); +ParseAllFunctionsAndNonLocalVars(); return; --

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu updated this revision to Diff 469350. zequanwu edited the summary of this revision. zequanwu added a comment. Don't try to complete types in `PdbAstBuilder::ParseDeclsForContext`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ h

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3866933 , @rnk wrote: > Right, so `cantFail` must be an assertions-only check. That's not great. With assertion enabled, lldb still silently deserialize member functions as non-member functions. My guess is that `Typ

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix the problem that it was treating member functions as non-member functions when

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Improve ParseDeclsForContext time.

zequanwu added a comment. In D136006#3864144 , @labath wrote: > Is this purely a performance optimization, or does it have some impact on > operation (its correctness) as well? E.g. does it prevent duplicate > construction of some types or something lik

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } zequanwu wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Fix ParseAllNamespacesPlusChildrenOf and avoid duplicate iteration on symbol stream

zequanwu updated this revision to Diff 468362. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136006/new/ https://reviews.llvm.org/D136006 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp lldb/

[Lldb-commits] [PATCH] D136006: [LLDB][NativePDB] Fix ParseAllNamespacesPlusChildrenOf and avoid duplicate iteration on symbol stream

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136006 Files: lldb/source/Plugins/SymbolFile/NativePDB

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3492ed01667: [LLDB][NativePDB] Fix struct layout when it has anonymous unions. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 467573. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 467266. zequanwu added a comment. - Handle the case when anonymous struct inside an union. - Append labath's changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:459 + uint64_t end_offset = offset + fields.back()->bit_size; + parent->fields.push_back(fields.back()); + end_offset_map[end_offset].push_back(parent);

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } labath wrote: > zequanwu wrote: > >

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:459 + uint64_t end_offset = offset + fields.back()->bit_size; + parent->fields.push_back(fields.back()); + end_offset_map[end_offset].push_back(parent);

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 466575. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849 Files: lldb/source/P

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:392-443 + // For anonymous unions in a struct, msvc generated pdb doesn't have the + // entity for that union. So, we need to construct anonymous union and struct + //

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 465933. zequanwu marked 5 inline comments as done. zequanwu added a comment. Add unittests and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849 File

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 465565. zequanwu marked an inline comment as done. zequanwu added a comment. Updated to handle the nested anonymous union and struct situation. It's done by: 1. Create the record layout with `Field` which could be a field member or an anonymous struct or an

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, lldb mistook fields in anonymous union in a struct as the direct field

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu added a comment. >> For members from parent classes, pdb only has information saying that its >> direct parents class are at some offsets for this class. For class without >> vtable, it's easy to calculate inherited member offsets by adding parent >> class offsets with their member off

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd434f437200b: [LLDB][NativePDB] Add class/union layout bit size. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu added a comment. In D134656#3818234 , @labath wrote: > That said, I am kinda surprised that this is the whole thing. I would have > expected to see more here. In dwarf we specify the offsets of individual > class members. Does PDB encode that i

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu updated this revision to Diff 463290. zequanwu marked 2 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134656/new/ https://reviews.llvm.org/D134656 Files: lldb/source/P

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3e60044d758: [LLDB][NativePDB] Let native pdb use class layout in debug info. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134509/n

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Missing it causes lldb to crash or give incorrect result. Repository: rG LLVM G

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

zequanwu marked an inline comment as done. zequanwu added a comment. In D134509#3811203 , @labath wrote: > It's not clear to me how much of this patch is pure refactoring, and how much > of it is adding new features. It would have been better to split th

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

zequanwu updated this revision to Diff 462555. zequanwu added a comment. Seperate refactor and the chang that fix class layout. This just hooks PdbAstBuilder to TypeSystem to use class layout from native pdb, but it's still broken because the layout bitsize is missing. Repository: rG LLVM Git

[Lldb-commits] [PATCH] D134509: [LLDB][NativePDB] Let native pdb use class layout in debug info.

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Before, class layout in native pdb is not hooked up in here

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu planned changes to this revision. zequanwu added a comment. It seems not correct. The dwarf test expects an error. I should figure out how to reduce that original

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:681 +auto &ts = llvm::cast(*ct.GetTypeSystem()); +ts.GetMetadata(&tag)->SetIsForcefullyCompleted(); + } rnk wrote: > Is this what we do for

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu created this revision. zequanwu added reviewers: labath, martong, rnk. Herald added a subscriber: rnkovacs. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a record type doesn't have compl

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21b417025f8: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

zequanwu updated this revision to Diff 460644. zequanwu added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133601/new/ https://reviews.llvm.org/D133601 Files: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFil

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8704281c5677: [LLDB][NativePDB] Global ctor and dtor should be global decls. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 460152. zequanwu added a comment. Move the logic into `MSVCUndecoratedNameParser`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Plugins/Langu

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3788956 , @labath wrote: > In D133446#3787362 , @zequanwu > wrote: > >> In D133446#3786561 , @labath wrote: >> >>> In D133446#3780961

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3786561 , @labath wrote: > In D133446#3780961 , @zequanwu > wrote: > >> In D133446#3779600 , @labath wrote: >> >>> I believe that thi

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedad60231fc: [LLDB][NativePDB] Add local variables with no location info. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133626/new/

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we don't add local variables with no location info, when trying to print it, lld

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/blocks.cpp:17 + +// CHECK: Function: id = {{.*}}, name = "main", range = [0x000140001000-0x00014000104b) +// CHECK-NEXT: FuncType: id = {{.*}}

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, it returns the outermost blocks if nested blocks have the same address rang

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3779600 , @labath wrote: > I believe that this fixes the crash, but the names of generated functions > still look fairly weird. Could we create them using their mangled name > instead? That way, someone might actuall

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 459145. zequanwu added a comment. Update test case after moving the check into `CreateDeclInfoForUndecoratedName`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Fi

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

This revision was automatically updated to reflect the committed changes. Closed by commit rG32530e0493c1: [LLDB][NativePDB] Set block address range. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133461/new/ https://reviews.l

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b825dcdb267: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContext when ICF happens. (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D133243?vs=458299&id=458794#toc Repos

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The block address range was missing before. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 458583. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes a crash that mistaken global ctor/dtor as funciton methods. Repository

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 458299. zequanwu added a comment. - Removed `GetParentDeclContextForSymbol` as this is not necesssary. We can get the demangled names from CVSymbol and then using it to create tag decl or namespace decl. - Add test cases with same base names, but with diffe

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:634-659 +name_components = name_components.drop_back(); +if (!name_components.empty()) { + // Render the current list of scope nodes as a fully qualified name, and

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 457752. zequanwu added a comment. Herald added a subscriber: JDevlieghere. Fix comment in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133243/new/ https://reviews.llvm.org/D133243 Files: lldb/so

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `PdbAstBuilder::GetParentDeclContextForSymbol` finds the public symbol that has sam

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d56ddac1bf: [LLDB] Clean up after command fails (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu updated this revision to Diff 455311. zequanwu added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132397/new/ https://reviews.llvm.org/D132397 Files: lldb/source/Interpreter/CommandObject.cpp lldb/test/She

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu created this revision. zequanwu added a reviewer: JDevlieghere. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `CommandObject::CheckRequirements()` requires m_exe_ctx being cleaned up. Repos

  1   2   3   >