[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 258034. yuri added a comment. Added @skipIfWindows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.cpp lldb/test/API/func

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. > I don't believe this test will pass on windows, because of the different path > styles. I don't think it's possible to meaningfully test this on windows, as > it requires the path in the core file to match a host path. So, I think you > can just slap `@skipIfWindows` on

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. @labath, please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 255588. yuri added a comment. Do not depend on exitance of /bin/sh anymore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri marked an inline comment as done. yuri added inline comments. Comment at: lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py:221 +core = f.read() +core = core.replace(b'/home/labath/test/a.out', b'/bin/sh\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0'

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri added a comment. Build failure is a bug of //tidy// script and is not caused by the patch itself. /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lldb/source/Target/RemoteAwarePlatform.cpp:9:10: error: 'lldb/Target/RemoteAwarePlatform.h' file not found [clang-diagnostic-erro

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri updated this revision to Diff 255260. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77529/new/ https://reviews.llvm.org/D77529 Files: lldb/source/Target/RemoteAwarePlatform.cpp lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore

[Lldb-commits] [PATCH] D77529: Prefer executable files from sysroot over files from local filesystem

yuri created this revision. yuri added reviewers: labath, clayborg, EugeneBi. yuri added a project: LLDB. Herald added a subscriber: lldb-commits. In D49685 sysroot behaviour was partially fixed. But files from local filesystem with same path still has priority o