[Lldb-commits] [PATCH] D86662: Simplify Symbol Status Message to Only Debug Info Size

aelitashen updated this revision to Diff 288456. aelitashen added a comment. Keep symbol status till new version released, remove comments in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86662/new/ https://reviews.llvm.org/D86662 Files:

[Lldb-commits] [PATCH] D86662: Simplify Symbol Status Message to Only Debug Info Size

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. aelitashen requested review of this revision. Herald added a subscriber: JDevlieghere. The Symbol Status in modules view is simplified so

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 286885. aelitashen added a comment. @Walter Please help me fix the tests. Looks like in the new added runInTerminal tests, it cannot hit the breakpoint and capture the local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen added a comment. I tried rebase onto the commit that Walter created just for formatting but I am not sure why it didn't remove those formatting noise.. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:410 + +VSCode::PacketStatus VSCode::SendReverseRequest(llvm::json::O

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 286620. aelitashen added a comment. Refactor code and optimize logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/tools/lldb-vscode/VSCode.cpp lld

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 285727. aelitashen added a comment. Remove uncomplete tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/tools/lldb-vscode/VSCode.cpp lldb/tools/l

[Lldb-commits] [PATCH] D84974: [WIP] Enable Launching the Debugee in VSCode Terminal

aelitashen updated this revision to Diff 285725. aelitashen added a comment. Add a attacher thread to avoid race condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84974/new/ https://reviews.llvm.org/D84974 Files: lldb/test/API/tools/lldb-v

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 282720. aelitashen added a comment. Move everything to the right place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 Files: lldb/tools/lldb-vscode/lldb-vscode.cp

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 282703. aelitashen added a comment. Herald added a subscriber: JDevlieghere. Cover ARM and ARM64 case in disassembly syntax highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://revie

[Lldb-commits] [PATCH] D84974: Enable Launching the Debugee in VSCode Terminal

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aelitashen requested review of this revision. Herald added a subscriber: JDevlieghere. When turn on "Launch In Terminal" in IDE, the debugee will

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 280596. aelitashen added a comment. Use unique id for disassembly.json Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 Files: lldb/tools/lldb-vscode/lldb-vscode.cp

[Lldb-commits] [PATCH] D84555: Add Syntax Highlighting to Disassembly View

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. When lldb cannot find source file thus IDE renders a disassembly view, add syntax highlighting for constants, registers and fin

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG986e3af53bfe: Add Debug Info Size to Symbol Status (authored by aelitashen, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 280261. aelitashen added a comment. Fix run_test to cover every system case and attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen marked an inline comment as done. aelitashen added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +active_modules = self.vscode.get_active_modules() +program_module = active_modules[program_basenam

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279936. aelitashen added a comment. Fix the accidentally removed test contents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279351. aelitashen added a comment. Add a white space in Symbols loaded info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-c

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279303. aelitashen added a comment. Remove white space for test_module_event Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-cl

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278922. aelitashen added a comment. Add TODO comment for Linux, Use ostringstream for Debug Info Size message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278900. aelitashen added a comment. Merge if statements in GetDebugInfoSizeInSection() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-for

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278898. aelitashen added a comment. Merge Codes and Improve Readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-clang-f

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278894. aelitashen added a comment. Create help function in tests for code re-use. Take care of both macOS and Linux system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278631. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests added are only for macOS, Walter will help me write tests on Linux. This update optimize the code and apply git clang format. Repository:

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 278591. aelitashen added a comment. Add Test for Debug Info Size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: lldb/packages/Python/lldbsuite/test/tools/l

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. Debug Info Size is displayed with Symbol Status Message. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83731 Files:

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f80159753b: [lldb-vscode] Add Support for Module Event (authored by aelitashen, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

This revision was automatically updated to reflect the committed changes. Closed by commit rG03ef61033ff5: [lldb-vscode] Add Compile Unit List to Modules View (authored by aelitashen, committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 276596. aelitashen added a comment. Fix Path and Add Documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files: lldb/packages/Python/lldbsuite/test/tools

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 276515. aelitashen added a comment. Recover Messy Diff History Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276294. aelitashen added a comment. Add Path Verification in Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276274. aelitashen added a comment. Fix messy diff stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vsco

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276172. aelitashen added a comment. Add test for loading symbols, other module info and Add version to module info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Fi

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added subscribers: lldb-commits, aprantl. Herald added a project: LLDB. aelitashen retitled this revision from "Add Compile Unit List to Modules View" to "[lldb-vscode] Add Compile Unit List to Modules View". a

[Lldb-commits] [PATCH] D83072: [lldb-vscode] Add Compile Unit List to Modules View

aelitashen updated this revision to Diff 275192. aelitashen added a comment. Remove comment line in request_getCompileUnits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83072/new/ https://reviews.llvm.org/D83072 Files: lldb/tools/lldb-vscode/ll

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 274634. aelitashen added a comment. Make LLDB take care of the directory delimiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files: clang/tools/clang-format/

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen marked 3 inline comments as done. aelitashen added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:337-340 +std::string(module.GetFileSpec().GetFilename())); + std::string module_path = std::string(module.GetFileSpec().GetDirectory()) + +

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen abandoned this revision. aelitashen added a comment. Mistakenly created two diffs on same commit, See D82477 for the original diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://revie

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273378. aelitashen added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Formatting the codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 273189. aelitashen added a comment. Formatting the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://reviews.llvm.org/D82505 Files: clang/tools/clang-format/git-clang-format lldb/pac

[Lldb-commits] [PATCH] D82505: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. aelitashen added a project: LLDB. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository:

[Lldb-commits] [PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository: rG LLVM Github Monorepo https://r