[Lldb-commits] [PATCH] D145183: [libc++] Implement `stop_token`

2023-05-22 Thread Valentin Clement via Phabricator via lldb-commits
clementval added a comment. Herald added a subscriber: JDevlieghere. Something seems wrong with this patch. It contains multiple unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145183/new/ https://reviews.llvm.org/D145183

[Lldb-commits] [PATCH] D130822: Fixed loads of typos

2022-12-07 Thread Valentin Clement via Phabricator via lldb-commits
clementval requested changes to this revision. clementval added inline comments. This revision now requires changes to proceed. Comment at: flang/docs/Extensions.md:157 with each other. -* Values for whole anonymous parent components in structure constructors (e.g., `EXTEND

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-10 Thread Valentin Clement via Phabricator via lldb-commits
clementval updated this revision to Diff 290770. clementval added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87389/new/ https://reviews.ll

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Valentin Clement via Phabricator via lldb-commits
clementval added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:41 focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false), is_attach(false), - reverse_request_seq(0), waiting_for_run_in_terminal(false) { + sto

[Lldb-commits] [PATCH] D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect

2020-09-09 Thread Valentin Clement via Phabricator via lldb-commits
clementval created this revision. clementval added reviewers: sscalpone, schweitz, jeanPerier, DavidTruby, jdoerfert. Herald added subscribers: lldb-commits, rriddle. Herald added a project: LLDB. clementval requested review of this revision. Herald added subscribers: stephenneuendorffer, JDevlieg