[Lldb-commits] [lldb] r310488 - Fix PlatformPythonTestCase.test_platform_list for the build bots

Author: enlight Date: Wed Aug 9 08:49:15 2017 New Revision: 310488 URL: http://llvm.org/viewvc/llvm-project?rev=310488&view=rev Log: Fix PlatformPythonTestCase.test_platform_list for the build bots Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/platform/TestPlatformPyth

[Lldb-commits] [lldb] r310452 - Expose active and available platform lists via SBDebugger API

Author: enlight Date: Wed Aug 9 02:20:40 2017 New Revision: 310452 URL: http://llvm.org/viewvc/llvm-project?rev=310452&view=rev Log: Expose active and available platform lists via SBDebugger API Summary: The available platform list was previously only accessible via the `platform list` command,

[Lldb-commits] [lldb] r309803 - Fix ProcessAPITestCase.test_get_process_info

Author: enlight Date: Wed Aug 2 03:12:12 2017 New Revision: 309803 URL: http://llvm.org/viewvc/llvm-project?rev=309803&view=rev Log: Fix ProcessAPITestCase.test_get_process_info Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py Modified: lldb/trunk/p

[Lldb-commits] [lldb] r309664 - Expose process instance info via SB API

Author: enlight Date: Tue Aug 1 00:34:26 2017 New Revision: 309664 URL: http://llvm.org/viewvc/llvm-project?rev=309664&view=rev Log: Expose process instance info via SB API Summary: Implement SBProcessInfo to wrap lldb_private::ProcessInstanceInfo, and add SBProcess::GetProcessInfo() to retrieve

[Lldb-commits] [PATCH] D26124: [LLDB-MI] Escape MI output in a more consistent manner

enlight added a comment. @ki.stfu Are you OK with this going in? Repository: rL LLVM https://reviews.llvm.org/D26124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26124: [LLDB-MI] Escape MI output in a more consistent manner

enlight added a comment. Thanks for the review. `AddSlashes` is still used in a couple of places (but not for escaping MI output), so I'll leave it be for now. Repository: rL LLVM https://reviews.llvm.org/D26124 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D26124: [LLDB-MI] Escape MI output in a more consistent manner

enlight created this revision. enlight added reviewers: ki.stfu, abidh. enlight added a subscriber: LLDB. enlight set the repository for this revision to rL LLVM. While attempting to run lldb-mi on Windows it became apparent that it doesn't consistently escape output, for instance error messages

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

This revision was automatically updated to reflect the committed changes. enlight marked an inline comment as done. Closed by commit rL284231: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class (authored by enlight). Changed prior to commit: https://reviews.llvm.org/D25592?vs=74628&id=74667

[Lldb-commits] [lldb] r284231 - [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

Author: enlight Date: Fri Oct 14 07:58:02 2016 New Revision: 284231 URL: http://llvm.org/viewvc/llvm-project?rev=284231&view=rev Log: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class Summary: Placeholder c-strings don't need to be instance variables. Reviewers: ki.stfu, abidh Subscribers:

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

enlight marked an inline comment as done. enlight added inline comments. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:116 if (!bOk) -return m_pUnkwn; +return kUnresolvedValue; ki.stfu wrote: > After couple of minutes I see the lack of logic the

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

enlight updated this revision to Diff 74628. enlight marked an inline comment as done. enlight added a comment. Rename `kUnresolvedValue` back to `kUknownValue`. Repository: rL LLVM https://reviews.llvm.org/D25592 Files: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp tools/lldb-mi/MICmnLLDBUtilS

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

enlight updated this revision to Diff 74622. enlight added a comment. Renamed placeholder c-strings. Repository: rL LLVM https://reviews.llvm.org/D25592 Files: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp tools/lldb-mi/MICmnLLDBUtilSBValue.h Index: tools/lldb-mi/MICmnLLDBUtilSBValue.h ===

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

enlight added inline comments. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22 +static const char *kUnknownValue = "??"; +static const char *kCompositeValuePlaceholder = "{...}"; + ki.stfu wrote: > use unnamed namespace here I would like to use an anon

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

enlight created this revision. enlight added reviewers: ki.stfu, abidh. enlight added a subscriber: LLDB. enlight set the repository for this revision to rL LLVM. Placeholder c-strings don't need to be instance variables. Repository: rL LLVM https://reviews.llvm.org/D25592 Files: tools/lld

[Lldb-commits] [lldb] r284100 - Fix Python binding generation build step on Windows

Author: enlight Date: Wed Oct 12 23:07:22 2016 New Revision: 284100 URL: http://llvm.org/viewvc/llvm-project?rev=284100&view=rev Log: Fix Python binding generation build step on Windows Summary: If Python is installed to a location that contains spaces (e.g. "C:\Program Files\Python3") then the b

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

enlight added a comment. In https://reviews.llvm.org/D25486#567722, @zturner wrote: > Heh. It just occurred to me that this is probably the reason why all of the > `lldb-mi` tests fail on Windows. Because `.exe` is not appended. I'm not > ready to turn that on and deal with all the failures

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a comment. It seems like it should be possible to conditionally enable this using CMAKE_VERSION . However that just means anyone who's silly enough to use an older CMake version may run into the

Re: [Lldb-commits] [Diffusion] rL250335: Fix codesign command with cmake.

enlight added a subscriber: enlight. enlight added a comment. I believe LLVM requires CMake 2.8.12 or later (at least that was the case when I looked three weeks ago). Users: sas (Author) dawn (Auditor) http://reviews.llvm.org/rL250335 ___ lldb

Re: [Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL250175: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in… (authored by enlight). Changed prior to commit: http://reviews.llvm.org/D13636?vs=37056&id=37261#toc Repository: rL L

[Lldb-commits] [lldb] r250175 - Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

Author: enlight Date: Tue Oct 13 11:30:28 2015 New Revision: 250175 URL: http://llvm.org/viewvc/llvm-project?rev=250175&view=rev Log: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows Summary: /usr/lib/debug doesn't exist on Windows so there's no

Re: [Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

enlight added a comment. Zach, I've looked at the path separator issue you've mentioned earlier in D13201 , and I think it's fine as is. All those paths with the forward slashes end up in a FileSpec, which converts forward slashes to backw

[Lldb-commits] [PATCH] D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows

enlight created this revision. enlight added reviewers: zturner, clayborg. enlight added a subscriber: lldb-commits. enlight set the repository for this revision to rL LLVM. `/usr/lib/debug` doesn't exist on Windows so there's no point even attempting to look for symbol files in there. Repositor

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

enlight added a comment. Hi Zach, Can you close this issue please? http://reviews.llvm.org/D13404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D13520: Make CMake display more readable paths to Python binaries on Windows

enlight created this revision. enlight added reviewers: zturner, brucem. enlight added a subscriber: lldb-commits. enlight set the repository for this revision to rL LLVM. Previously CMake would display messages like these: ``` -- LLDB Found PythonExecutable: $<$:C:/Projects/Python-2.7.9-bin/x64

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

enlight added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:113 @@ +112,3 @@ + set (PYTHON_LIBRARY ${PYTHON_LIBRARY} PARENT_SCOPE) + set (PYTHON_DLL ${PYTHON_LIBRARY} PYTHON_DLL PARENT_SCOPE) + set (PYTHON_INCLUDE_DIRS ${PYTHON_INCLUDE_DIRS} PARENT_SCOPE)

Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

enlight updated this revision to Diff 36468. enlight added a comment. Added a couple of unit tests, the Windows-specific cleanups will be submitted in a separate patch. Repository: rL LLVM http://reviews.llvm.org/D13201 Files: source/Host/common/Symbols.cpp unittests/Host/CMakeLists.txt

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

enlight added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:56 @@ +55,3 @@ +message("LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME. Python support disabled.") +set(LLDB_DISABLE_PYTHON 1) +return() This will

Re: [Lldb-commits] [PATCH] D13404: Teach CMake to find versions of Python != 2.7

enlight added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:109 @@ +108,3 @@ + set (PYTHON_EXECUTABLE $<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTHON_RELEASE_EXE}> PARENT_SCOPE) + set (PYTHON_LIBRARY $<$:${PYTHON_DEBUG_LIB}>$<$>:${PYTHON_RELEASE_LIB}> PARENT_SCOPE) + se

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight added a comment. That looks fine to me. CMake prints those messages during the configuration step, at that point the generator expressions haven't been expanded yet. I could prettify those messages a bit to read: `Found PythonLibs: C:/Python27_LLDB/x86/libs/python27_d.lib and C:/Python

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight updated this revision to Diff 36072. enlight added a comment. This revision is now accepted and ready to land. Added an explanation of the generator expression used in this patch. Repository: rL LLVM http://reviews.llvm.org/D13234 Files: cmake/modules/LLDBConfig.cmake Index: cmake

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight planned changes to this revision. enlight added a comment. I'll submit a revised patch that contains an explanation of the generator expressions to aid future maintainers/contributors. Comment at: cmake/modules/LLDBConfig.cmake:61 @@ +60,3 @@ + # below, otherwise C

Re: [Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:61 @@ +60,3 @@ + # below, otherwise CMake will replace the whitespace with a semicolon in some contexts (which would stuff things up). + set (PYTHON_EXECUTABLE $<$:${PYTHON_DEBUG_EXE}>$<$>:${PYTH

[Lldb-commits] [PATCH] D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir

enlight created this revision. enlight added reviewers: brucem, zturner. enlight added a subscriber: lldb-commits. enlight set the repository for this revision to rL LLVM. After a developer builds LLDB from source on Windows (assuming they've built it with Python support enabled), they may be som

[Lldb-commits] [PATCH] D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator

enlight created this revision. enlight added reviewers: brucem, zturner. enlight added a subscriber: lldb-commits. enlight set the repository for this revision to rL LLVM. Previously `CMAKE_BUILD_TYPE` was used to determine whether to link in `python27.lib` or `python27_d.lib`, unfortunately this

Re: [Lldb-commits] [PATCH] D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()

enlight added a comment. I've updated the summary with the scenario. I don't know how one would go about writing a test for this, mixed platform remote debugging is a bit finicky. Comment at: source/Host/common/Symbols.cpp:238-250 @@ -237,15 +237,15 @@ // Add /usr/li

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

enlight added inline comments. Comment at: tools/lldb-mi/MICmdCmdExec.cpp:92 @@ +91,3 @@ +const char *pCmd = bProcessMustStopAtEntry ? "process launch -s" : "process launch"; +const lldb::ReturnStatus rtn = rSessionInfo.GetDebugger().GetCommandInterpreter().Handl

Re: [Lldb-commits] [PATCH] D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run

enlight added a subscriber: enlight. enlight added a comment. According to the GDB-MI spec the exec-run command already has a **start** option. Support for the **start** option can be dete