[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. > Is it possible to get your IDE to record the module & the address? I don't control the definition of the protocol (FWIW it's Microsoft's Debug Adapter Protocol), but I'll look into that, maybe there's a way to sneak in extra information. In which case, what is the c

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. @JDevlieghere: ping.Or are you saying you wouldn't consider landing such a change at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. Hi Jim, I think there's a bit of confusion going on here: The original bug was opened by Ted Woodward, and I think his scenario was motivated by embedded debugging. He also provided that example with a breakpoint being set in main. I've rediscovered this bug independent

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn updated this revision to Diff 372636. vadimcn added a comment. Added patch context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109738/new/ https://reviews.llvm.org/D109738 Files: lldb/source/Breakpoint/BreakpointResolverAddress.cpp

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn added a comment. > In the future, can you generate patches with context (i.e. pass -U to > "git diff" or "git show"), it's a lot easier to read patches with context. Sure thing, will do. This doesn't seem like the right solution to the problem to me. The way > address breakpoints S

[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

vadimcn created this revision. vadimcn added a reviewer: jingham. vadimcn added a project: LLDB. Herald added a subscriber: JDevlieghere. vadimcn requested review of this revision. Herald added a subscriber: lldb-commits. Setting an address breakpoint unconditionally creates a location, however th

[Lldb-commits] [PATCH] D109339: Fix compilation error with older libstdc++

vadimcn updated this revision to Diff 372391. vadimcn added a comment. Re-formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109339/new/ https://reviews.llvm.org/D109339 Files: lldb/include/lldb/Target/ThreadPlanStack.h Index: lldb/include/lldb/Target/ThreadPlanStack.h ===

[Lldb-commits] [PATCH] D109339: Fix compilation error with older libstdc++

vadimcn created this revision. vadimcn added a reviewer: jingham. vadimcn added a project: LLDB. Herald added a subscriber: JDevlieghere. vadimcn requested review of this revision. Herald added a subscriber: lldb-commits. Until GCC 6, std::unordered_map could not emplace non-copyable values, which

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

vadimcn added a comment. @mgorny Do your changes allow debugging both the parent and child processes after a fork? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D67793: new api class: SBFile

vadimcn added inline comments. Comment at: lldb/trunk/scripts/Python/python-typemaps.swig:481 + PyBuffer_Release(&view); + $1 = ($1_ltype) buf; + $2 = ($2_ltype) (size/sizeof($*1_type)); Sorry for being late to the party, but I just stumbled upon this code...

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

This revision was automatically updated to reflect the committed changes. Closed by commit rL344474: Fix double import of _lldb module. (authored by vadimcn, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52404?vs=166627&id=169595#toc

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

vadimcn added a comment. Thanks, What changed in SWIG 3.0.11? Repository: rLLDB LLDB https://reviews.llvm.org/D52404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

vadimcn added a comment. Changing title as it looks like this is not a Windows-only problem: https://github.com/rust-lang/rust/issues/54126. The above illustrates why I think this needs to be fixed: Right now LLDB cannot be installed correctly unless the installer can preserve symlinks. Merely

[Lldb-commits] [PATCH] D37934: Fix compatibility with OpenOCD debug stub.

vadimcn added a comment. Maybe LLDB should use `qAttached` to determine if there's an active process? OpenOCD seems to implement that one correctly. Repository: rL LLVM https://

[Lldb-commits] [PATCH] D37934: Fix compatibility with OpenOCD debug stub.

vadimcn added a comment. Sorry, for not catching this regression! I've checked that attaching to a standard gdbserver still worked, but was not aware of the other scenarios. Does lldb-server return 'OK' string in response to 'qfThreadInfo'? According to this

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

vadimcn added a comment. FYI - this broke at least Windows, because the default behavior of Process::WillResume() changed from success to an error and WindowsProcess does not override WillResume(). Not sure what other platforms are in the same boat. Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D37934: Fix compatibility with OpenOCD debug stub.

vadimcn added a comment. This is what I see in the log: < 16> send packet: $qfThreadInfo#bb < 5> read packet: $l#6c And here's code that generates it: https://github.com/gnu-mcu-eclipse/openocd/blob/b21ab1d683aaee501d45fe8a509a2043123f16fd/src/rtos/rtos.c#L370 I agree, they should have

[Lldb-commits] [PATCH] D37934: Fix compatibility with OpenOCD debug stub.

vadimcn created this revision. vadimcn added a project: LLDB. OpenOCD sends register classes as two separate nodes, fixed parser to process both of them. OpenOCD returns "l" in response to "qfThreadInfo", so IsUnsupportedResponse() was false and we were ending up without any threads in the pro

[Lldb-commits] [PATCH] D27476: Install lldb Python module on Windows.

vadimcn added a comment. Ping! Should I ask somebody else to review? Repository: rL LLVM https://reviews.llvm.org/D27476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27476: Install lldb Python module on Windows.

vadimcn created this revision. vadimcn added reviewers: zturner, hans. vadimcn added a subscriber: lldb-commits. vadimcn set the repository for this revision to rL LLVM. vadimcn added a project: LLDB. Herald added a subscriber: mgorny. With this change, "script import lldb" succeeds when executed