[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-27 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 approved this pull request. https://github.com/llvm/llvm-project/pull/94794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread Usama Hameed via lldb-commits
@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() { if (!process_sp) return; - lldb::ModuleSP module_sp = GetRuntimeModuleSP(); - Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint( - module_sp, process_sp, ConstString("sanitizer

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (#88349) (PR #88962)

2024-04-16 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/88962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (#88349) (PR #88962)

2024-04-16 Thread Usama Hameed via lldb-commits
usama54321 wrote: > The only change here was catching the build errors, right? lldbtest.build > only throws exceptions, it doesn't return any value, so this seems the right > way to do it. > > Letting the build system fail to find this library seems easier than trying > to check ourselves. >

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (#88349) (PR #88962)

2024-04-16 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 created https://github.com/llvm/llvm-project/pull/88962 The previous patch was reverted because the test fails to build when libsanitizers is not present. This patch catches the BuildError exception and skips the test appropriately. This patch tests LLDB integrat

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-15 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-15 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 18757485878c4455032883ebfeb13483dc3ab469 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: > Will this test primarily be run at-desk? Or will it be a part of existing CI? > I know we have discussed this previously, I just want to confirm as I'm > putting together documentation for this kind of testing for libsanitizers. > I'd love to make note somewhere where we ex

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: Changed the no_libsanitizers function to use the LLDB image list command https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 59ee9026bc0d35bcde83ff45aacb272bb39902b0 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: Added a util function to skip tests if libsanitizers is not present in the shared cache https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From b25a5a0b5beb249c8a646cbfc02b865ca91ab861 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
@@ -26,6 +31,67 @@ def setUp(self): self.line_free = line_number("main.c", "// free line") self.line_breakpoint = line_number("main.c", "// break line") +# Test line numbers: rdar://126237493 +def libsanitizer_tests(self): +target = self.createT

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From c336a2ad53121bedd52a80169d11e5617c7058ed Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 3d31b403aad13f8eb8a9377390f05a310bfa0999 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From de4ed3289ecb52b4971f6abe942c0a3af9e6425a Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From a1ef63cd8f5bb927fc58827996b22c1f4dba15bb Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
usama54321 wrote: I reused the test in TestReportData because the output should match exactly with current ASan. For TestMemoryHistory, libsanitizers currently only supports the memory history plugin for addresses for which a report has been generated, so I wrote a test separately. https://gi

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 created https://github.com/llvm/llvm-project/pull/88349 This patch tests LLDB integration with libsanitizers for ASan. rdar://111856681 >From 4cee76dff9b474a6a6bd278ea69cde6c3be924ad Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subje

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/84583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/84583 >From 3b16e506778ce0a869e19b41d13836b4c3cf26ca Mon Sep 17 00:00:00 2001 From: usama Date: Mon, 11 Mar 2024 11:39:24 -0700 Subject: [PATCH] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoin

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-08 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/84583 >From fbe08446991972f1fde90206d0281c506d668d6b Mon Sep 17 00:00:00 2001 From: usama Date: Fri, 8 Mar 2024 15:55:25 -0800 Subject: [PATCH] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-08 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 created https://github.com/llvm/llvm-project/pull/84583 symbol This patch puts the default breakpoint on the sanitizers_address_on_report symbol, and uses the old symbol as a backup if the default case is not found rdar://123911522 >From aa8f732f4d6d2cdae5b32462

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-25 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-25 Thread Usama Hameed via lldb-commits
usama54321 wrote: Thanks everyone! https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-25 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
@@ -1,5 +1,7 @@ +add_subdirectory(Libsanitizers) usama54321 wrote: More specifically, I have named the file `ASanLibsanitizers/InstrumentationRuntimeASan.cpp` instead of `ASanLibsanitizers/InstrumentationRuntimeASanLibsanitizers.cpp` https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
usama54321 wrote: Thanks a lot for the feedback @bulbazord and @JDevlieghere. I have updated the PR. I will appreciate any feedback about the directory/file naming convention after the update. https://github.com/llvm/llvm-project/pull/69388 ___ lldb-

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
@@ -1,5 +1,7 @@ +add_subdirectory(Libsanitizers) usama54321 wrote: I moved the plugin in the parent directory. However, I was not sure how to name the plugin so I have currently named the folder as ASanLibsanitizers and named the files as InstrumentationRuntime

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-17 Thread Usama Hameed via lldb-commits
usama54321 wrote: @llvm-ci test https://github.com/llvm/llvm-project/pull/69388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-17 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From 3ee63c7dfd8b92ac8738d19bd3cebffeccfd59ec Mon Sep 17 00:00:00 2001 From: usama Date: Tue, 17 Oct 2023 14:35:04 -0700 Subject: [PATCH] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin Instr