[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Yes please. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 247597. unnar marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h Index: lldb/include/lldb/Utility/RangeMap.h

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Thanks for the feedback! I addressed all of your comments in the latest patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 247211. unnar marked 2 inline comments as done. unnar added a comment. As discussed with labath@ I made a separate struct called AugmentedEntry that is used internally but we only ever expose the Entry part to the user. CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. In D74759#1895748 , @labath wrote: > In D74759#1893485 , @unnar wrote: > > > That should work...although I'm not sure how that is any different to the > > range or data being public. If a use

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar marked 2 inline comments as done. unnar added a comment. No, I can't. If you could submit this for me it would be great. Comment at: lldb/unittests/Utility/RangeMapTest.cpp:23 +std::vector FindEntryIndexes(uint32_t address, + Ra

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar updated this revision to Diff 246721. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75180/new/ https://reviews.llvm.org/D75180 Files: lldb/unittests/Utility/RangeMapTest.cpp Index: lldb/unittests/Utility/RangeMapTest.cpp =

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. In D74759#1893450 , @labath wrote: > In D74759#1893186 , @unnar wrote: > > > In D74759#1880499 , @labath wrote: > > > > > Have you done a proper comple

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added a comment. Sure, removed tests from this patch. They are now at D75180 Comment at: lldb/unittests/Utility/RangeMapTest.cpp:22 +const std::vector FindEntryIndexes(uint32_t address, + Ran

[Lldb-commits] [PATCH] D75180: Add unit tests for RangeDataVector::FindEntryIndexesThatContain

unnar created this revision. unnar added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere, arphaman. Herald added a project: LLDB. This adds unit tests for FindEntryIndexesThatContain, this is done in preparation for changing the logic of the function. Reposito

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246716. unnar marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h Index: lldb/include/lldb/Utility/RangeMap.h

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246681. unnar added a comment. Added reference to Wikipedia article. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74759/new/ https://reviews.llvm.org/D74759 Files: lldb/include/lldb/Utility/RangeMap.h lldb/unittests/Utility/RangeMapTest.cpp Ind

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar added inline comments. Comment at: lldb/include/lldb/Utility/RangeMap.h:642 + B ComputeUpperBounds(int lo, int hi) { +if (lo > hi) return B(); + jarin wrote: > Here, B() should be the min value of type B, no? Perhaps this should be > `std::numeric_lim

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar updated this revision to Diff 246679. unnar marked 5 inline comments as done. unnar added a comment. In D74759#1880499 , @labath wrote: > Have you done a proper complexity analysis here? I doubt the `O(log n)` claim > is true in general. It would ha

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

unnar created this revision. unnar added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Since RangeDataVector is assumed to always be sorted we can treat it as an flattened BST and augment it with additional information about the

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar updated this revision to Diff 238771. unnar added a comment. Switched back to std::vector and uploaded the full diff. I don't have commit access so it would be appreciated if you could land this for me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https://rev

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar updated this revision to Diff 238759. unnar marked an inline comment as done. unnar added a comment. Herald added a reviewer: jdoerfert. @labath Can you take another look and see if this matches what you had in mind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https:

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar added a comment. In D72909#1826110 , @labath wrote: > Thanks for the patch. I've been wondering how to improve this, and this > solution is pretty neat. > > I have just one request. Instead of the `ReplaceLineTableWithSequences` > thingy, could you

[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

unnar created this revision. unnar added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, mgrang. Motivation: When setting breakpoints in certain projects line sequences are frequently being inserted out of order. Rather than inserting sequences one at a time into a sorted