[Lldb-commits] [lldb] [LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size (PR #117604)

https://github.com/tuliom approved this pull request. The build succeeded! The source comment at line 82 caught my attention, though. It may imply that data layout is important in this struct, i.e. it should match `siginfo_t` returned by the OS. But this change is not guaranteeing that. Actual

[Lldb-commits] [lldb] [LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size (PR #117604)

https://github.com/tuliom requested changes to this pull request. This didn't help. The size on 32-bits continue to be 44. I think the difference is not really caused the size of the properties on 32 bits, but the implicit padding on 32/64 bits. Look at the code generated here: https://godbolt.

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

tuliom wrote: We're also seeing this issue. We have a full build log available at https://download.copr.fedorainfracloud.org/results/@fedora-llvm-team/llvm-snapshots-big-merge-20241123/fedora-rawhide-i386/08305565-llvm/builder-live.log.gz , in case it helps. https://github.com/llvm/llvm-projec

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/103388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: Agreed. Let me merge this. https://github.com/llvm/llvm-project/pull/103388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: > Do we need anything more to make progress with this PR? @kimgr Do you have committer permission? Would you like some help to get this merged? https://github.com/llvm/llvm-project/pull/103388 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [clang] [lldb] Use CLANG_RESOURCE_DIR more consistently (PR #103388)

tuliom wrote: > Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be > replaced with something else at runtime, i.e. a real use-case for the > optional CustomResourceDir optional argument I removed? @kimgr I have also looked for this and I haven't found an use-case where this

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/70443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

tuliom wrote: I confirmed the new code works with Python 3.6 and removed the conditional. https://github.com/llvm/llvm-project/pull/70443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

https://github.com/tuliom updated https://github.com/llvm/llvm-project/pull/70443 >From 16fd09f102eff20825847e32f225715960d1c082 Mon Sep 17 00:00:00 2001 From: Tulio Magno Quites Machado Filho Date: Wed, 25 Oct 2023 10:48:53 -0300 Subject: [PATCH 1/2] [lldb] Replace the usage of module imp with

[Lldb-commits] [lldb] [lldb] Fix misleading indentiation warning in ScriptInterpreterPython (NFC) (PR #70732)

tuliom wrote: Thank you! https://github.com/llvm/llvm-project/pull/70732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

tuliom wrote: Do you know what is the reason for requiring such an old Python version? I'm asking because it's been hard to find a distro that provides both Python 3.6 (released in 2016) and cmake 3.20 (released in 2021). For the record, Ubuntu 18.04 does have Python 3.6, but it has cmake 3.10.

[Lldb-commits] [lldb] [lldb] Adapt code to Python 3.13 (PR #70445)

https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/70445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

tuliom wrote: I believe it's also important to mention this PR does not solve issue #70453. But it helps to solve `ModuleNotFoundError: No module named 'imp'` kind of issues. https://github.com/llvm/llvm-project/pull/70443 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

tuliom wrote: [This document](https://docs.python.org/3/library/importlib.html) mentions 3.1. Many functions were added after 3.6, but none of them are being explicitly used in this patch. I'm afraid the easiest way to guarantee is by testing with Python 3.6. https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [lldb] Adapt code to Python 3.13 (PR #70445)

https://github.com/tuliom created https://github.com/llvm/llvm-project/pull/70445 1. Remove usage of PyEval_ThreadsInitialized and PyEval_InitThreads Both of these functions were removed in Python 3.13 [1] after being deprecated since Python 3.9. According to "What's new in Python 3.13" docum

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

https://github.com/tuliom created https://github.com/llvm/llvm-project/pull/70443 imp got removed in Python 3.12 [1] and the community recommends using importlib in newer Python versions. [1] https://docs.python.org/3.12/whatsnew/3.12.html#imp >From 16fd09f102eff20825847e32f225715960d1c082 Mo