[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

2023-08-04 Thread Tom Yang via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG786bab433469: Display PC instead of for stack trace in vscode (authored by zhyty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

2023-08-03 Thread Tom Yang via Phabricator via lldb-commits
zhyty updated this revision to Diff 546979. zhyty added a comment. remove a.out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732 Files: lldb/test/API/tools/lldb-vscode/stackTraceMissingFunctionName/Makef

[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

2023-08-03 Thread Tom Yang via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9a3f0cd717f6: Fix crash in lldb-vscode when missing function name (authored by zhyty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156970/new/ https://rev

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

2023-08-03 Thread Tom Yang via Phabricator via lldb-commits
zhyty updated this revision to Diff 546738. zhyty added a comment. - added a test case - rebased this commit on top of D156970 , which fixes a crash preventing me from testing this feature - addressed other comments Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D156970: Fix crash in lldb-vscode when missing function name

2023-08-03 Thread Tom Yang via Phabricator via lldb-commits
zhyty created this revision. Herald added a project: All. zhyty requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. In cases where the PC has no function name, lldb-vscode crashes. `lldb::SBFrame::GetDisplayFunctionName()` returns a `nu

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

2023-07-31 Thread Tom Yang via Phabricator via lldb-commits
zhyty created this revision. Herald added a project: All. zhyty requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It isn't useful for users to see "" as a stack trace when lldb fails to symbolicate a stack frame. I've replaced "" with the va