upsj added a comment.
I don't have commit access to LLVM, so feel free to merge it
Tobias Ribizel
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
___
lldb-com
upsj updated this revision to Diff 426983.
upsj marked an inline comment as done.
upsj added a comment.
move standalone-specific code to LLDBStandalone.cmake
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
upsj updated this revision to Diff 426628.
upsj added a comment.
fix standalone builds
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cmake
lldb/CMakeLists.txt
lldb
upsj updated this revision to Diff 426215.
upsj added a comment.
restore some of the previous behavior
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cmake
lldb/cmake
upsj updated this revision to Diff 426080.
upsj added a comment.
improve handling of disabled libedit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cmake
lldb/cmake/
upsj updated this revision to Diff 426072.
upsj added a comment.
revert remaining unnecessary change from initial diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cm
upsj updated this revision to Diff 426071.
upsj added a comment.
fix broken build without libedit, improve find module
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124673/new/
https://reviews.llvm.org/D124673
Files:
cmake/Modules/FindLibEdit.cm
upsj updated this revision to Diff 426068.
upsj added a comment.
Herald added a subscriber: JDevlieghere.
The previous setup didn't work for clang-query, so I added a CMake IMPORTED
target for LibEdit and used it everywhere
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
upsj created this revision.
upsj added reviewers: mgorny, MaskRay.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
upsj requested review of this revision.
Herald added projects: LLDB, LLVM.
Herald added subscribers: llvm-commits, lldb-commits.
Currently, LLVM's LineEd
