[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-16 Thread Tobias Hieta via lldb-commits
tru wrote: /cherry-pick adf44d5c3ea03569f019740e1140c3205810b3fa 2bcab9ba7139cfa96c85433fa85b29c8a6d7008b https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-26 Thread Tobias Hieta via lldb-commits
tru wrote: This was suggested in https://github.com/llvm/llvm-project/pull/91856 and the suggestion there was that we need to split it up per sub-project which is something @e-kwsm has been doing: https://github.com/llvm/llvm-project/pulls/e-kwsm so I don't think this one is needed. https://

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread Tobias Hieta via lldb-commits
tru wrote: > I think .natvis files should be CRLF (those are used with Visual Studio for > debug visualizers). Agreed, Visual Studio should handle this correctly, but who knows 🤷🏼 https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mail

[Lldb-commits] [lldb] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

2023-09-25 Thread Tobias Hieta via lldb-commits
tru wrote: Looking at it - it seems like none of Tablegen is correctly clang-formatted. If that's not desired, maybe it should have a local .clang-format file to disable the formatting of these files. Do we have a clang-tblgen maintainer? Couldn't find anything in the codeowners and git log h

[Lldb-commits] [lldb] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

2023-09-25 Thread Tobias Hieta via lldb-commits
tru wrote: No I don't think it's job's fault. I ran clang-format on this file and it's not formatted at all, so I think when we ask it to just format a patch like we do in the job, it gets a bit confused and give you a bit of non-sense formatting. This is just a limitation of not running forma

[Lldb-commits] [lldb] [cmake] Add LLVM_FORCE_VC_REVISION option (PR #67125)

2023-09-22 Thread Tobias Hieta via lldb-commits
https://github.com/tru commented: It looks fine to me, but maybe we should have an entry for it in the `CMake.rst` documentation since the other `LLVM_*_VC` options are documented. https://github.com/llvm/llvm-project/pull/67125 ___ lldb-commits maili

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-10 Thread Tobias Hieta via lldb-commits
tru wrote: Note that the formatting check failed! It shouldn't be ignored :) https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b135650 - [LLVM] Update C++ standard to 17

2022-08-06 Thread Tobias Hieta via lldb-commits
Author: Tobias Hieta Date: 2022-08-06T09:42:10+02:00 New Revision: b1356504e63ae821cccf1e051a0d2526bdfef2b0 URL: https://github.com/llvm/llvm-project/commit/b1356504e63ae821cccf1e051a0d2526bdfef2b0 DIFF: https://github.com/llvm/llvm-project/commit/b1356504e63ae821cccf1e051a0d2526bdfef2b0.diff

[Lldb-commits] [lldb] a339837 - Pass plugin_name in SBProcess::SaveCore

2022-06-09 Thread Tobias Hieta via lldb-commits
Author: Levon Date: 2022-06-09T16:29:50+02:00 New Revision: a33983729df641559b639a48d1b65e2de55f6e90 URL: https://github.com/llvm/llvm-project/commit/a33983729df641559b639a48d1b65e2de55f6e90 DIFF: https://github.com/llvm/llvm-project/commit/a33983729df641559b639a48d1b65e2de55f6e90.diff LOG: Pa