[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e757c6b500d: Fix conversion error to Expected (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126402/new/ https://reviews.llvm.org/D126

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre added a comment. In D126402#3538078 , @wallace wrote: > thank you! > > I'm surprised the compiler didn't do this automatically As mentioned, this is GCC 7.5. It might be different with a newer version. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D126402: Fix conversion error to Expected

thopre created this revision. thopre added reviewers: wallace, jj10306. Herald added a project: All. thopre requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Ubuntu 18.04 with GCC 7.5 Intel trace code fails to build due to failure to conve

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

thopre added a comment. Is there no way to split this patch further? It's going to be hard finding someone who can review something so big. If there's no way to split it in incremental changes, you could perhaps split per subsystem only for review and refer to this diff for CI as well as when l

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

thopre added a comment. In D102630#2764705 , @dblaikie wrote: > @thopre - as an aside: It'd be helpful if you could include some text in the > text box when marking something "approved" through phabricator. There's a > bug/limitation that approvals with

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

thopre added a comment. In D98179#2621706 , @davezarzycki wrote: > I've made all of the requested changes to date. Two notes: > > 1. One cannot simply omit the first argument to `split()` if the second is > provided. As I just learned, python will compla

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

thopre added a comment. Shouldn't the CMake target remain check-lldb-unit to be consistant with check-llvm-unit/check-clang-unit etc.? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 _