[Lldb-commits] [PATCH] D139969: Add a json dumper for call graph reconstructor

persona0220 created this revision. persona0220 added reviewers: jj10306, wallace. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff is created on top of D137614

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG20c7ec127240: [lldb][trace] Correctly treat kernel CPUs as individual threads (authored by persona0220). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136371

[Lldb-commits] [PATCH] D136371: [trace][intel pt] Correctly treat kernel CPUs as individual threads

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Resolved a bug in kernel decoding and correctly treat kernel CPUs as

[Lldb-commits] [PATCH] D135521: [lldb][trace] Add a basic function call dump [1] - Add the command scaffolding

persona0220 accepted this revision. persona0220 added a comment. This revision is now accepted and ready to land. LGTM! I'll also review the algorithm soon :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135521/new/ https://reviews.llvm.org/D13552

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450163. persona0220 added a comment. rebasing to the upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/in

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 marked an inline comment as done. persona0220 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:104-108 std::vector tids; for (const JSONProcess &process : bundle_description.processes) for (const JSONThread &threa

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450144. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 450137. persona0220 marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/Tra

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449823. persona0220 marked 9 inline comments as done. persona0220 added a comment. Resolved comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceInt

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449481. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449452. persona0220 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/Tra

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 marked 7 inline comments as done. persona0220 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTConstants.h:25 const bool kDefaultDisableCgroupFiltering = false; +const uint64_t kDefaultKernelLoadAddress = 0x8100; ---

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449447. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h lldb/source/Plugins/Trace/intel-

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449442. persona0220 marked 15 inline comments as done. persona0220 added a comment. - Remove duplicate files under `lldb/test/API/commands/trace/intelpt-kernel-trace` and use relative path to `../intelpt-multi-core-trace/` - Update TraceIntelBundleSaver

[Lldb-commits] [PATCH] D130805: Support a new kernel section in LLDB’s trace bundle schema

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a new "kernel" section with following schema. "kernel": {

[Lldb-commits] [PATCH] D130607: [trace] Add instruction control flow kind to JSON trace dumper's output

persona0220 accepted this revision. persona0220 added a comment. This revision is now accepted and ready to land. lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130607/new/ https://reviews.llvm.org/D130607

[Lldb-commits] [PATCH] D130580: Refactor string conversion for InstructionControlFlowKind enum

persona0220 accepted this revision. persona0220 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/Disassembler.cpp:930 + } +} + jj10306 wrote: > Thoughts on adding a default case with a string that indicates tha

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 updated this revision to Diff 447437. persona0220 added a comment. Add default implementation for GetControlFlowKind() CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130320/new/ https://reviews.llvm.org/D130320 Files: lldb/include/lldb/Core/Disassembler.h lldb/source/Cor

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 updated this revision to Diff 446680. persona0220 edited the summary of this revision. persona0220 added a comment. Not to cache the control flow kind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130320/new/ https://reviews.llvm.org/D130320 Files: lldb/include/lldb/Core/

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff move the logic of `GetControlFlowKind()` from Disassembler.

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 443360. persona0220 marked 8 inline comments as done. persona0220 added a comment. Added a struct `InstructionOpcodeAndModrm`, which contains primary_opcode, opcode_len and modrm bytes decoded from `InstructionLengthDecode` function. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 443281. persona0220 marked 4 inline comments as done. persona0220 added a comment. Herald added a subscriber: mgorny. - Delete PTI_MAP enum and use opcode_len instead. - Add a unit test - Divide existing Disassembler test into x86 / ARM subdirectory -

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 442420. persona0220 marked an inline comment as done. persona0220 added a comment. Add some more documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembl

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 442417. persona0220 marked 13 inline comments as done. persona0220 added a comment. - Terms ‘control flow kind’ and ‘control flow type’ was mixed across source codes -> Unify into ‘control flow kind’ - Divide the ‘GetControlFlowKind’ function into two fun

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441230. persona0220 added a comment. nit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceDumper.h lldb/include/lldb/lldb

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441229. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceDumper.h lldb/include/lldb/lldb-enumerations.h lldb/source/API/S

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 441226. persona0220 marked 26 inline comments as done. persona0220 added a comment. - Modify function name `instruction_decode` into `DecodeInstructionOpcode` - explicit naming for flag `show_kind` -> `show_control_flow_kind` - Convert `InstructionControlF

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

persona0220 added a comment. lgtm. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128775/new/ https://reviews.llvm.org/D128775 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 440808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 Files: lldb/include/lldb/Core/Disassembler.h lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/TraceInstructionDumper.h lldb/

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 440806. persona0220 added a comment. Herald added subscribers: Michael137, MaskRay. This new diff attach additional metadata 'control flow kind' for instruction. Add '-k / --kind' flag for both `disassemble` and `thread trace dump` command. Thanks to @jin

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To build complex binding upon instruction trace, additional metadata