Re: [Lldb-commits] [PATCH] D19480: Fix ARM attribute parsing for Android after rL267291

2016-04-25 Thread Stephen Hines via lldb-commits
srhines added a comment. In http://reviews.llvm.org/D19480#410664, @tberghammer wrote: > This patch only effects debugging (all modified file is part of LLDB). > > I want to get the Android <-> EABI part fixed ASAP as a recent LLDB change > completely broke Android ARM debugging with adding ARM.

Re: [Lldb-commits] [PATCH] D19480: Fix ARM attribute parsing for Android after rL267291

2016-04-25 Thread Stephen Hines via lldb-commits
srhines added a comment. In http://reviews.llvm.org/D19480#410641, @rengolin wrote: > In http://reviews.llvm.org/D19480#410620, @tberghammer wrote: > > > Both executables and shared libraries are containing ARM Attributes what > > contains the information about soft-float vs hard-float. I am not

Re: [Lldb-commits] [PATCH] D19114: [test] Relax stderr expectations on targets with chatty output

2016-04-14 Thread Stephen Hines via lldb-commits
srhines added inline comments. Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:142 @@ +141,3 @@ +def hasChattyStderr(test_case): +"""Some targets produce garbage on the standard error output. This utility function +determines whether the tests can be strict