sivachandra accepted this revision.
sivachandra added a comment.
Herald added subscribers: sstefan1, JDevlieghere.
OK for libc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144509/new/
https://reviews.llvm.org/D144509
sivachandra accepted this revision.
sivachandra added a comment.
Changes in the libc directory LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137338/new/
https://reviews.llvm.org/D137338
___
lldb-co
sivachandra accepted this revision.
sivachandra added a comment.
Libc change LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86616/new/
https://reviews.llvm.org/D86616
___
lldb-commits mailing list
l
sivachandra added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+is_legacy_mode=False,
+depends_on_projects=["llvm", "clang", "lldb", "lld"])
jankratochvil wrote:
> sivachandra wrote:
> > labath wrote:
> > > sivac
sivachandra added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+is_legacy_mode=False,
+depends_on_projects=["llvm", "clang", "lldb", "lld"])
labath wrote:
> sivachandra wrote:
> > sivachandra wrote:
> > > I wonde
sivachandra added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+is_legacy_mode=False,
+depends_on_projects=["llvm", "clang", "lldb", "lld"])
sivachandra wrote:
> I wonder why it is getting git.lab.llvm.org! Can y
sivachandra added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:71
+is_legacy_mode=False,
+depends_on_projects=["llvm", "clang", "lldb", "lld"])
I wonder why it is getting git.lab.llvm.org! Can you try with an additi
sivachandra added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:110
cmake_cmd = [
-"cmake", "-G", "Ninja", "../llvm",
+"cmake", "-G", "Ninja", "../" + self.monorepo_dir,
"-DCMAKE_BUILD_TYPE=" + config,
Should thi