[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-02-21 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra accepted this revision. sivachandra added a comment. Herald added subscribers: sstefan1, JDevlieghere. OK for libc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

2022-12-07 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra accepted this revision. sivachandra added a comment. Changes in the libc directory LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-co

[Lldb-commits] [PATCH] D86616: [cmake] Make gtest include directories a part of the library interface

2020-08-26 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra accepted this revision. sivachandra added a comment. Libc change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86616/new/ https://reviews.llvm.org/D86616 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

2019-10-24 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) jankratochvil wrote: > sivachandra wrote: > > labath wrote: > > > sivac

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

2019-10-23 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) labath wrote: > sivachandra wrote: > > sivachandra wrote: > > > I wonde

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

2019-10-23 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) sivachandra wrote: > I wonder why it is getting git.lab.llvm.org! Can y

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

2019-10-23 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) I wonder why it is getting git.lab.llvm.org! Can you try with an additi

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

2019-10-23 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:110 cmake_cmd = [ -"cmake", "-G", "Ninja", "../llvm", +"cmake", "-G", "Ninja", "../" + self.monorepo_dir, "-DCMAKE_BUILD_TYPE=" + config, Should thi