[Lldb-commits] [libc] [lldb] [llvm] [mlir] [polly] Fix simple bugs (PR #117151)

https://github.com/RKSimon requested changes to this pull request. Thanks for the cleanups! Please can you close this and submit separate PRs for independent review https://github.com/llvm/llvm-project/pull/117151 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

@@ -28729,7 +28731,7 @@ static SDValue GenerateFixedLengthSVETBL(SDValue Op, SDValue Op1, SDValue Op2, unsigned BitsPerElt = VTOp1.getVectorElementType().getSizeInBits(); unsigned IndexLen = MinSVESize / BitsPerElt; unsigned ElementsPerVectorReg = VTOp1.getVectorNumEleme

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

https://github.com/RKSimon approved this pull request. LGTM with one minor https://github.com/llvm/llvm-project/pull/80309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

@@ -171,7 +171,7 @@ bool HexagonGenExtract::convert(Instruction *In) { // this value. if (!LogicalSR && (SR > SL)) return false; -APInt A = APInt(BW, ~0ULL).lshr(SR).shl(SL); +APInt A = APInt(BW, ~0ULL, true).lshr(SR).shl(SL); RKSimon wrot

[Lldb-commits] [clang] [compiler-rt] [libc] [libclc] [libcxxabi] [lld] [lldb] [llvm] [mlir] Add clarifying parenthesis around non-trivial conditions in ternary expressions. (PR #90391)

https://github.com/RKSimon closed https://github.com/llvm/llvm-project/pull/90391 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libc] [libclc] [libcxxabi] [lld] [lldb] [llvm] [mlir] Add clarifying parenthesis around non-trivial conditions in ternary expressions. (PR #90391)

https://github.com/RKSimon approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90391 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libc] [libclc] [libcxxabi] [lld] [lldb] [llvm] [mlir] llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3804: lacking () for c… (PR #90391)

https://github.com/RKSimon commented: Please address the clang-format warnings the CI has reported https://github.com/llvm/llvm-project/pull/90391 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [compiler-rt] [libc] [libclc] [libcxxabi] [lld] [lldb] [llvm] [mlir] llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3804: lacking () for c… (PR #90391)

https://github.com/RKSimon commented: Please update the PR subject as its a lot more than just X86AsmParser.cpp https://github.com/llvm/llvm-project/pull/90391 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [clang] [compiler-rt] [flang] [libc] [libcxx] [lldb] [llvm] [mlir] [X86] Fast AVX-512-VNNI vpdpwssd tuning (PR #85033)

https://github.com/RKSimon requested changes to this pull request. This patch needs to be cleanly rebased on trunk (force push is OK in PR branchs) https://github.com/llvm/llvm-project/pull/85033 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [libcxx] [llvm] [libc] [compiler-rt] [lldb] [clang-tools-extra] [mlir] [clang] [flang] [AArch64] add intrinsic to generate a bfi instruction (PR #79672)

RKSimon wrote: @RamaMalladiAWS Do you have examples of the IR that fails to lower to BFI? These things often turn out to be either a missing middle-end canonicalization or maybe a case that could be added to existing pattern matching in the back-end. https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [libcxx] [flang] [libc] [clang-tools-extra] [clang] [llvm] [compiler-rt] [libunwind] [lld] [lldb] [X86] Use RORX over SHR imm (PR #77964)

@@ -4216,6 +4217,95 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned ROpc, unsigned MOpc, return CNode; } +// When the consumer of a right shift (arithmetic or logical) wouldn't notice +// the difference if the instruction was a rotate right instead (because the +//

[Lldb-commits] [clang-tools-extra] [libcxx] [flang] [lldb] [llvm] [libunwind] [compiler-rt] [lld] [libc] [clang] [X86] Use RORX over SHR imm (PR #77964)

@@ -4216,6 +4217,97 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned ROpc, unsigned MOpc, return CNode; } +// When the consumer of a right shift (arithmetic or logical) wouldn't notice +// the difference if the instruction was a rotate right instead (because the +//

[Lldb-commits] [libc] [lld] [clang-tools-extra] [libcxx] [libunwind] [compiler-rt] [lldb] [flang] [llvm] [clang] [X86] Use RORX over SHR imm (PR #77964)

https://github.com/RKSimon requested changes to this pull request. https://github.com/llvm/llvm-project/pull/77964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libunwind] [clang-tools-extra] [libc] [flang] [lldb] [lld] [compiler-rt] [libcxx] [llvm] [clang] [X86] Use RORX over SHR imm (PR #77964)

@@ -4216,6 +4217,97 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned ROpc, unsigned MOpc, return CNode; } +// When the consumer of a right shift (arithmetic or logical) wouldn't notice +// the difference if the instruction was a rotate right instead (because the +//

[Lldb-commits] [clang] [libunwind] [libcxx] [flang] [compiler-rt] [clang-tools-extra] [libc] [lldb] [llvm] [lld] [X86] Use RORX over SHR imm (PR #77964)

@@ -4216,6 +4217,97 @@ MachineSDNode *X86DAGToDAGISel::emitPCMPESTR(unsigned ROpc, unsigned MOpc, return CNode; } +// When the consumer of a right shift (arithmetic or logical) wouldn't notice +// the difference if the instruction was a rotate right instead (because the +//

[Lldb-commits] [libc] [clang-tools-extra] [llvm] [compiler-rt] [clang] [lldb] [lld] [flang] [libcxx] [libunwind] [X86] Use RORX over SHR imm (PR #77964)

https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/77964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [lldb] [libc] [llvm] [clang] [libcxxabi] [libunwind] [libcxx] [flang] [lld] [compiler-rt] Fix a bug in Smith's algorithm used in complex div/mul. (PR #78330)

https://github.com/RKSimon updated https://github.com/llvm/llvm-project/pull/78330 >From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 16 Jan 2024 11:24:03 -0800 Subject: [PATCH 1/4] Fixed a bug in Smith's algorithm and made sure last option in

[Lldb-commits] [lldb] 93a5a03 - [lldb] Host::ShellExpandArguments - fix error check for valid dictionary

Author: Simon Pilgrim Date: 2022-10-25T17:44:04+01:00 New Revision: 93a5a03030ab9f49120f7bd2ec8e84f063da9987 URL: https://github.com/llvm/llvm-project/commit/93a5a03030ab9f49120f7bd2ec8e84f063da9987 DIFF: https://github.com/llvm/llvm-project/commit/93a5a03030ab9f49120f7bd2ec8e84f063da9987.diff

[Lldb-commits] [lldb] 850bc76 - [lldb] BreakpointOptions::CommandData::CreateFromStructuredData - remove dead code + variable. NFCI.

Author: Simon Pilgrim Date: 2022-02-27T11:33:14Z New Revision: 850bc76a356b050b92851ad5a6a8207da05685cd URL: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd DIFF: https://github.com/llvm/llvm-project/commit/850bc76a356b050b92851ad5a6a8207da05685cd.diff LOG:

[Lldb-commits] [lldb] b81b3ac - [lldb] TypeSystemClang - use castAs/cast<> instead of getAs/dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-29T15:34:26Z New Revision: b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7 URL: https://github.com/llvm/llvm-project/commit/b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7 DIFF: https://github.com/llvm/llvm-project/commit/b81b3ac66886f2c93a2bab52f24ed38e9b5d34a7.diff LOG:

[Lldb-commits] [lldb] 058c5df - Raise the minimum Visual Studio version to VS2019

Author: Simon Pilgrim Date: 2022-01-29T10:56:41Z New Revision: 058c5dfc78cd1a1a6075bba9799e63f3ec871c0d URL: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d DIFF: https://github.com/llvm/llvm-project/commit/058c5dfc78cd1a1a6075bba9799e63f3ec871c0d.diff LOG:

[Lldb-commits] [lldb] 49d38b1 - Fix "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2022-01-23T15:14:10Z New Revision: 49d38b1d618c02964af93068ee8e1ac753722104 URL: https://github.com/llvm/llvm-project/commit/49d38b1d618c02964af93068ee8e1ac753722104 DIFF: https://github.com/llvm/llvm-project/commit/49d38b1d618c02964af93068ee8e1ac753722104.diff LOG:

[Lldb-commits] [lldb] d7aa402 - [lldb] PdbAstBuilder - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-23T15:11:08Z New Revision: d7aa402b4b8a325a68c20d0300ac6bc664766be0 URL: https://github.com/llvm/llvm-project/commit/d7aa402b4b8a325a68c20d0300ac6bc664766be0 DIFF: https://github.com/llvm/llvm-project/commit/d7aa402b4b8a325a68c20d0300ac6bc664766be0.diff LOG:

[Lldb-commits] [lldb] d13847b - [lldb] TerminalState::Save - fix unused variable warning

Author: Simon Pilgrim Date: 2022-01-23T15:12:44Z New Revision: d13847bbe5e632ec8f62abc81f74b9351a56d28c URL: https://github.com/llvm/llvm-project/commit/d13847bbe5e632ec8f62abc81f74b9351a56d28c DIFF: https://github.com/llvm/llvm-project/commit/d13847bbe5e632ec8f62abc81f74b9351a56d28c.diff LOG:

[Lldb-commits] [lldb] c934913 - [lldb] CxxModuleHandler - use cast<> instead of dyn_cast<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-23T15:10:33Z New Revision: c93491352cf3146559de7755283f0dd259392126 URL: https://github.com/llvm/llvm-project/commit/c93491352cf3146559de7755283f0dd259392126 DIFF: https://github.com/llvm/llvm-project/commit/c93491352cf3146559de7755283f0dd259392126.diff LOG:

[Lldb-commits] [lldb] 307cfad - Fix extraneous ')' error.

Author: Simon Pilgrim Date: 2021-06-11T14:50:22+01:00 New Revision: 307cfad0d639b0397033069473e84e6c7f249056 URL: https://github.com/llvm/llvm-project/commit/307cfad0d639b0397033069473e84e6c7f249056 DIFF: https://github.com/llvm/llvm-project/commit/307cfad0d639b0397033069473e84e6c7f249056.diff

[Lldb-commits] [lldb] cd2e500 - [lldb] DumpDataExtractor.cpp - replace APInt::toString() with llvm::toString(APInt)

Author: Simon Pilgrim Date: 2021-06-11T13:39:14+01:00 New Revision: cd2e500e555e134ffc19d07f26b17d0b0c71efd9 URL: https://github.com/llvm/llvm-project/commit/cd2e500e555e134ffc19d07f26b17d0b0c71efd9 DIFF: https://github.com/llvm/llvm-project/commit/cd2e500e555e134ffc19d07f26b17d0b0c71efd9.diff

[Lldb-commits] [lldb] 754f3c4 - Fix implicit Twine.h include dependency.

Author: Simon Pilgrim Date: 2020-06-26T13:24:32+01:00 New Revision: 754f3c4af4b8526d7576c8e92959ad10d40b6e2e URL: https://github.com/llvm/llvm-project/commit/754f3c4af4b8526d7576c8e92959ad10d40b6e2e DIFF: https://github.com/llvm/llvm-project/commit/754f3c4af4b8526d7576c8e92959ad10d40b6e2e.diff