[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Thanks! Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_static-member-anonymous-namespace.s:18 +# static int s; +# int m = 14159265; +# }; I wonder why I couldn't get the query to work against an initialized global wi

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. This is passing lldb-checks locally. Is there anything else I need to add or tweak, or is this ready for review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 ___

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 426452. siggi-alpheus added a comment. Fix awkwardly named variable in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files: lldb/source/Plugins/Sy

[Lldb-commits] [PATCH] D123415: [lldb] Fix crash when a type has no definition

siggi-alpheus abandoned this revision. siggi-alpheus added a comment. This is not a good fix for the crash. A better fix is in https://reviews.llvm.org/D124370. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123415/new/ https://reviews.llvm.org/D12

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425792. siggi-alpheus added a comment. A full diff from origin/main - I hope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files: lldb/source/Plugins/Symbo

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Please take a look. This now passes all tests locally, and adds a test that fails against the current ToT lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425790. siggi-alpheus added a comment. Add a test that fails against the ToT lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files: lldb/test/Shell/Symb

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus marked an inline comment as done. siggi-alpheus added a comment. Now passes all tests - but I still need to write a test for the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 425585. siggi-alpheus added a comment. Now passes all tests, still needs a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files: lldb/source/Plugins/Sy

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. Thanks for taking a look. Let me see about fixing the test failures and writing that test. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2672 // Handle static members - if (attrs.is_external && attrs.member_byte_off

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus created this revision. siggi-alpheus added a reviewer: labath. siggi-alpheus added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. Herald added a reviewer: shafik. Herald added a project: All. siggi-alpheus requested review of this revision. Herald added a subscribe

[Lldb-commits] [PATCH] D123415: [lldb] Fix crash when a type has no definition

siggi-alpheus created this revision. siggi-alpheus added reviewers: labath, jasonmolenda. siggi-alpheus added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. siggi-alpheus requested review of this revision. Herald added a subscriber: lldb-commits. See issue 5