[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

smeenai added a comment. This is breaking our build setup. It causes e.g. the Clang resource headers to be installed to `lib64/clang` instead of `lib/clang`. Given this and the other breakages, can we revert for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. FWIW, I've usually seen people just recommit directly instead of going through another review. Accepting this since it was already reviewed last time and the only changes are buildbot fixes.

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai added a comment. In D130549#3683423 , @clayborg wrote: > Ping. This was accepted before but I had Buildbot issues. Those should all be > resolved in this updated patch after a revert. Sorry for the delay. I can confirm this builds correctly for

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai added a comment. In D130309#3673365 , @thakis wrote: > Still broken on windows for me: http://45.33.8.238/win/62911/step_4.txt Seeing the same errors here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai added a comment. Herald added a subscriber: JDevlieghere. I believe you landed the wrong commit. rG859ebca744e634dcc89a2294ffa41574f947bd62 looks like the previous versions of this diff, where lots of extraneous chang

[Lldb-commits] [PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This doesn't seem like a correct revert. What command are you using to generate this? `git revert` is what you should be using, e.g. git

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

This revision was automatically updated to reflect the committed changes. Closed by commit rG969eefd98e0f: [lldb] add LLDB_SKIP_DSYM option (authored by rmaz, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103124/new/ https://r

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

smeenai accepted this revision. smeenai added a subscriber: sgraenitz. smeenai added a comment. This revision is now accepted and ready to land. Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO. LGTM. Do you need this to be committed for you? Repository: rG LLVM Git

[Lldb-commits] [PATCH] D102889: [lldb] Match test dependencies name to other LLVM projects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e327785da36: [lldb] Match test dependencies name to other LLVM projects. (authored by drodriguez, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

smeenai added a comment. Is this rebased on main? The LLD for Mach-O changes look like they belong to a different diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 _

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015d78a25e51: [lldb] Remove XPCServices symlinking (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147 + add_custom_command(TARGET liblldb POST_BUILD +COMMAND ${CMAKE_COMMAND} -E create_symlink +Versions/Current/XPCServices +${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LL

[Lldb-commits] [PATCH] D97701: [lldb] Remove XPCServices symlinking

smeenai created this revision. smeenai added reviewers: vsk, JDevlieghere. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a downstream change that was accidentally included upstream. Rep

[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147 + add_custom_command(TARGET liblldb POST_BUILD +COMMAND ${CMAKE_COMMAND} -E create_symlink +Versions/Current/XPCServices +${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LL

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG389955c69a3b: [lldb] add check for libcxx runtime (authored by rmaz, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https:/

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 ___

[Lldb-commits] [PATCH] D97227: [lldb] add check for libcxx runtime

smeenai added a comment. My understanding of the issue is that, with the runtimes build, the `cxx` target will get created after we process LLDB's build files. The `TARGET cxx` check here will therefore fail, but the `cxx` target will end up existing later, and CMake is perfectly fine adding a

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Oops, missed that I'd become a blocking reviewer for this (cos of requesting changes before). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D792

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Requesting changes to remove from my review queue while the above comments are being addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.l

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

smeenai added inline comments. Comment at: lld/test/lit.site.cfg.py.in:16 config.target_triple = "@TARGET_TRIPLE@" -config.python_executable = "@Python3_EXECUTABLE@" -config.have_zlib = @HAVE_LIBZ@ +config.python_executable = "@PYTHON_EXECUTABLE@" +config.have_zlib = @LLVM_ENABL

[Lldb-commits] [PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. With the newer minimum CMake version, we can eliminate a bunch of the policy settings as well, but that can be a follow-up (especially given this isn't gonna ship for a few months). (Anothe

[Lldb-commits] [PATCH] D74996: [arcconfig] Delete subproject arcconfigs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D74996: [arcconfig] Delete subproject arcconfigs

smeenai created this revision. smeenai added reviewers: jyknight, phosek, rnk. Herald added a reviewer: bollu. Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits. >From

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

smeenai added a comment. In D70764#1803559 , @raj.khem wrote: > this is now in master, and I am seeing build failures in cross-building > clang, e.g. when building clang for arm on a x86_64 host. its resorting to > finding, libz from buildhost instead of

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

smeenai accepted this revision. smeenai added a comment. LGTM Comment at: lldb/cmake/modules/LLDBFramework.cmake:125 +# Add an rpath pointing to the directory where LLDB.framework is installed. +# This allows frameworks (relying on @rpath) to be installed in the same folder an

[Lldb-commits] [PATCH] D69931: Add rpath to liblldb so vendors can ship their own python framework (or others)

smeenai added inline comments. Comment at: lldb/cmake/modules/LLDBFramework.cmake:124 + +# Add an rpath pointing to the directory where LLDB.framework is installed. +set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH smeenai wrote: > You may wanna add the

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. Commit message needs to be updated. Comment at: lldb/cmake/modules/LLDBFramework.cmake:124 + +# Add an rpath pointing to the directory where LLDB.framework is installed. +set_property(TARGET liblldb APPEND PROPERTY INSTALL_RPATH You may

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. In D69931#1739063 , @beanz wrote: > It is a bit gross that Python does an @rpath install name, that is generally > against convention. I can see adding an option to add rpaths to liblldb > making sense. I certainly agree LLDB sho

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

smeenai added a comment. I agree on not getting into the business of installing Python ourselves, but there's also the rpath issue. The Windows case is different because you just put all your DLLs in the same directory (or some other directory in your PATH) and you're done. With macOS, you have

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

This revision was automatically updated to reflect the committed changes. Closed by commit rL355340: [build] Rename clang-headers to clang-resource-headers (authored by smeenai, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D58791?vs=189

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. I added an entry to the release notes. The release notes change only covers the changes in this diff. My plan is to land this, wait for a few days (so that users of the target get broken in an obvious way), and then add the new install-clang-headers target (for installi

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 188988. smeenai added a comment. Release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-e

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai added a comment. In D58791#1415496 , @tstellar wrote: > This looks good, but could you also add an entry in the ReleaseNotes for this. Will do – thanks for the reminder :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar, rnk, dim. Herald added subscribers: openmp-commits, Sanitizers, jdoerfert, javed.absar, mgorny. Herald added a reviewer: serge-sans-paille. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. The current in

[Lldb-commits] [PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai updated this revision to Diff 189014. smeenai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt clang-tools-extra/te

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1376069 , @mehdi_amini wrote: > > You can avoid the git status pollution by adding the build directory to > > .git/info/exclude. > > Good to know! Should we include this in the doc? I can put that change up fore review

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

smeenai added a comment. In D57330#1375913 , @mehdi_amini wrote: > In D57330#1375096 , @labath wrote: > > > This is not an full out-of-source build, since the build folder is still a > > subfolder of the repo root

[Lldb-commits] [PATCH] D57330: Adjust documentation for git migration.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. The amount of duplicated and out-of-date documentation makes me sad, but this is an awesome effort to clean that up. Comment at: lldb/packages/Python/lldbsuite/test/funct

[Lldb-commits] [PATCH] D53917: [lldb] Fix race condition in framework installation

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB345711: [lldb] Fix race condition in framework installation (authored by smeenai, committed by ). Changed prior to commit: https://reviews.llvm.org/D53917?vs=171854&id=171884#toc Repository: rLLDB

[Lldb-commits] [PATCH] D53917: [lldb] Fix race condition in framework installation

smeenai created this revision. smeenai added a reviewer: xiaobai. Herald added a subscriber: mgorny. We need the install-liblldb-stripped target to also depend on the llvm-framework target in order for the installation to be guaranteed to behave as intended. I believe this is simply a typo. http

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340885: [LLDB] Fix script to work with GNU sed (authored by smeenai, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D51374?vs=162928&id=162988#toc

[Lldb-commits] [PATCH] D51374: [LLDB] Fix script to work with GNU sed

smeenai created this revision. smeenai added reviewers: beanz, davide, xiaobai. GNU sed and BSD sed have a different command-line syntax for in-place editing, and the current form of the script would only work with BSD sed. The easiest way to get cross-platform behavior is to specify a backup suff

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

smeenai added a comment. This is definitely trivial enough to just go through post-commit review :) (As in, just commit it directly without going through Phabricator.) Repository: rL LLVM https://reviews.llvm.org/D48620 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D41099: [lldb] Switch to add_llvm_install_targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL320443: [lldb] Switch to add_llvm_install_targets (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D41099 Files: lldb/trunk/cmake/modules/AddLLDB.cmake Index: lldb/trunk/cmake/m

[Lldb-commits] [PATCH] D41099: [lldb] Switch to add_llvm_install_targets

smeenai created this revision. Herald added a subscriber: mgorny. This adds the install-*-stripped targets to LLDB, which are required for the install-distribution-stripped option. We also need to create some install-*-stripped targets manually, which are modeled after their corresponding install-