[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

2020-07-05 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83180 Files: lldb/source/API/SBError.cpp Index: lldb/source/API/SBError.cpp ===

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

2020-07-04 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. @JDevlieghere Sounds good! I'll make the changes and use that for any future additions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82732/new/ https://reviews.llvm.org/D82732 ___

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

2020-06-30 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 updated this revision to Diff 274625. shivammittal99 added a comment. - Extend SBTarget to enable/disable/ignore watchpoints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82732/new/ https://reviews.llvm.org/D82732 Files: lldb/bind

[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects

2020-06-29 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. shivammittal99 added reviewers: jingham, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82732 Files: lldb/include/lldb/API/SB

[Lldb-commits] [PATCH] D82723: Add lldbAPI library to be able to invoke SB API from CommandObjects

2020-06-29 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 updated this revision to Diff 273977. shivammittal99 added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82723/new/ https://reviews.llvm.org/D82723 Files: lldb/source/API/CMakeLists.txt lldb/source/Co

[Lldb-commits] [PATCH] D82723: Add lldbAPI library to be able to invoke SB API from CommandObjects

2020-06-29 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Signed-off-by: Shivam Mittal Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82723 Files: lldb/source/API/CMakeLists.txt lldb/source/Commands/CMakeLists.txt

[Lldb-commits] [PATCH] D77568: Return correct entry in RangeDataVector::FindEntryThatContains

2020-04-06 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The FindEntryThatContains function does not return the correct entry in the case when two non-consecutive entries contain the range. Eg. Vector = [(0, 40, 0), (10, 10, 1)] and query = (25,

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

2020-04-02 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. Can you please commit this for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76729/new/ https://reviews.llvm.org/D76729 ___ lldb-commits

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

2020-03-30 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Resolve the two duplicated pragma marks in lldb/source/Commands/CommandObjectTarget.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77096 Files: lldb/source/Comma

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-26 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. Can someone please land this patch for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 ___ lldb

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

2020-03-24 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 updated this revision to Diff 252426. shivammittal99 added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76729/new/ https://reviews.llvm.org/D76729 Files: lldb/source/Commands/CommandObjectSettings.cpp

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

2020-03-24 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert index-based loops marked TODO in CommandObjectSettings and CommandObjectTarget to entry-based. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76729 Files: ll

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-23 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 updated this revision to Diff 252125. shivammittal99 added a comment. Remove conditional and move raw_command_string line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 Files: lldb/source/

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-23 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. > run by hand ASAN-built LLDB for the code modified by this patch. How do I do that? This is my first PR to llvm, so I am not aware of the tools. Please bear with me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-23 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. @jankratochvil When I use `LLVM_USE_SANITIZER=Address` and then run `ninja check-lldb` I get other errors: $ ninja check-lldb -j 1 [1/1981] Building DiagnosticDriverKinds.inc... FAILED: tools/clang/include/clang/Basic/DiagnosticDriverKinds.inc cd /home/sh

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-22 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 added a comment. I don't know why is `clang-tidy` failing. I haven't changed the import or any other file than `CommandObjectCommands.cpp`. @jingham @aprantl Could you please help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

2020-03-22 Thread Shivam Mittal via Phabricator via lldb-commits
shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76569 Files: lldb/source/Commands/CommandObjectCommands.cpp Index: lldb/source/Commands/CommandObjectCommands.cpp =