[Lldb-commits] [clang] [clang-tools-extra] [lldb] [c++20] P1907R1: Support for generalized non-type template arguments of scalar type. (PR #78041)

shafik wrote: This crash is due to this set of changes: https://github.com/llvm/llvm-project/issues/11 https://github.com/llvm/llvm-project/pull/78041 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [llvm] [libcxxabi] [flang] [libc] [compiler-rt] [openmp] [lld] [clang] [libunwind] [mlir] [lldb] [libcxx] [clang-tools-extra] [clang] static operators should evaluate object argument (P

https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/68485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [libunwind] [libc] [flang] [lld] [lldb] [compiler-rt] [llvm] [clang-tools-extra] [clang] [libclc] [clang] Add tests for DRs about complete-class context (PR #77444)

https://github.com/shafik commented: LGTM https://github.com/llvm/llvm-project/pull/77444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [clang] [lld] [mlir] [compiler-rt] [libcxxabi] [libcxx] [clang-tools-extra] [lldb] [libunwind] [libc] [llvm] [openmp] [clang] static operators should evaluate object argument (P

@@ -5678,10 +5678,15 @@ static ImplicitConversionSequence TryObjectArgumentInitialization( assert(FromType->isRecordType()); QualType ClassType = S.Context.getTypeDeclType(ActingContext); - // [class.dtor]p2: A destructor can be invoked for a const, volatile or - //

[Lldb-commits] [lldb] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/70150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Ensure zero-init is not overridden when initializing a base class in a constant expression context (PR #70150)

shafik wrote: The clang-format error is a false positive. https://github.com/llvm/llvm-project/pull/70150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

shafik wrote: Please make sure you add a description to your PR. This is what usually goes into the git log and we want those entries to be as descriptive and helpful for folks who read the git logs, thank you. https://github.com/llvm/llvm-project/pull/66963 ___

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/67788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

@@ -85,6 +85,18 @@ KnownBits KnownBits::computeForAddSub(bool Add, bool NSW, return KnownOut; } +KnownBits KnownBits::computeForSubBorrow(const KnownBits &LHS, KnownBits RHS, + const KnownBits &Borrow) { + assert(Borrow.getBitWidth()

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67373 >From beab5db738483795ecb0bace2842acdbb1c9869a Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Mon, 25 Sep 2023 13:56:43 -0700 Subject: [PATCH 1/2] [Clang] Fix crash when ill-formed code is treated as a dedu

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

shafik wrote: ping https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67373 >From beab5db738483795ecb0bace2842acdbb1c9869a Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Mon, 25 Sep 2023 13:56:43 -0700 Subject: [PATCH] [Clang] Fix crash when ill-formed code is treated as a deductio

[Lldb-commits] [lldb] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/67514 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67514 >From e2e0e10e13748ba9369b73c7547c035ee75dfffa Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Tue, 26 Sep 2023 18:55:44 -0700 Subject: [PATCH] [Clang] Fix crash when visting a fold expression in a default a

[Lldb-commits] [lldb] 1438639 - [LLDB] Remove undefined behavior in TestConstStaticIntegralMember.py

Author: Shafik Yaghmour Date: 2022-08-08T19:23:53-07:00 New Revision: 1438639a2f7eb9e9cba01454d3a9b1b16d179c9a URL: https://github.com/llvm/llvm-project/commit/1438639a2f7eb9e9cba01454d3a9b1b16d179c9a DIFF: https://github.com/llvm/llvm-project/commit/1438639a2f7eb9e9cba01454d3a9b1b16d179c9a.dif

[Lldb-commits] [lldb] fd14646 - [LLDB] Applying clang-tidy modernize-use-override over LLDB

Author: Shafik Yaghmour Date: 2022-04-22T13:29:47-07:00 New Revision: fd1464604367f2259614b66c886db16598b5be6b URL: https://github.com/llvm/llvm-project/commit/fd1464604367f2259614b66c886db16598b5be6b DIFF: https://github.com/llvm/llvm-project/commit/fd1464604367f2259614b66c886db16598b5be6b.dif

[Lldb-commits] [lldb] 24f9a2f - [LLDB] Applying clang-tidy modernize-use-equals-default over LLDB

Author: Shafik Yaghmour Date: 2022-03-31T13:21:49-07:00 New Revision: 24f9a2f53db78df59761f46ceed3bb5e7aa0d331 URL: https://github.com/llvm/llvm-project/commit/24f9a2f53db78df59761f46ceed3bb5e7aa0d331 DIFF: https://github.com/llvm/llvm-project/commit/24f9a2f53db78df59761f46ceed3bb5e7aa0d331.dif

[Lldb-commits] [lldb] 14cad95 - [LLDB] Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

Author: Shafik Yaghmour Date: 2022-03-30T18:00:37-07:00 New Revision: 14cad95d38235df6c5fd5dd3da84b91fa69e7e74 URL: https://github.com/llvm/llvm-project/commit/14cad95d38235df6c5fd5dd3da84b91fa69e7e74 DIFF: https://github.com/llvm/llvm-project/commit/14cad95d38235df6c5fd5dd3da84b91fa69e7e74.dif

[Lldb-commits] [lldb] aca9648 - [LLDB] Cleanup for Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

Author: Shafik Yaghmour Date: 2022-03-24T10:00:26-07:00 New Revision: aca96480784b5373ad7229816b00297690354208 URL: https://github.com/llvm/llvm-project/commit/aca96480784b5373ad7229816b00297690354208 DIFF: https://github.com/llvm/llvm-project/commit/aca96480784b5373ad7229816b00297690354208.dif

[Lldb-commits] [lldb] 33d7417 - [LLDB] Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

Author: Shafik Yaghmour Date: 2022-03-17T08:52:56-07:00 New Revision: 33d74170a36e3b801e93152effa59f19d9abb3a0 URL: https://github.com/llvm/llvm-project/commit/33d74170a36e3b801e93152effa59f19d9abb3a0 DIFF: https://github.com/llvm/llvm-project/commit/33d74170a36e3b801e93152effa59f19d9abb3a0.dif

[Lldb-commits] [lldb] 37400dd - [LLDB][NFC] Remove dead code from Section.cpp

Author: Shafik Yaghmour Date: 2022-03-15T18:11:30-07:00 New Revision: 37400dd3e817ea43ed9c32d545211dd93b5e7c59 URL: https://github.com/llvm/llvm-project/commit/37400dd3e817ea43ed9c32d545211dd93b5e7c59 DIFF: https://github.com/llvm/llvm-project/commit/37400dd3e817ea43ed9c32d545211dd93b5e7c59.dif

[Lldb-commits] [lldb] 6583f01 - [LLDB] Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

Author: Shafik Yaghmour Date: 2022-03-15T09:36:20-07:00 New Revision: 6583f01707211ed14d8e35f2183a8805a301b6f9 URL: https://github.com/llvm/llvm-project/commit/6583f01707211ed14d8e35f2183a8805a301b6f9 DIFF: https://github.com/llvm/llvm-project/commit/6583f01707211ed14d8e35f2183a8805a301b6f9.dif

[Lldb-commits] [lldb] 28c878a - [LLDB] Applying clang-tidy modernize-use-default-member-init over LLDB

Author: Shafik Yaghmour Date: 2022-03-14T13:32:03-07:00 New Revision: 28c878aeb29a7e7a9ae8f748de6a3c41482b97be URL: https://github.com/llvm/llvm-project/commit/28c878aeb29a7e7a9ae8f748de6a3c41482b97be DIFF: https://github.com/llvm/llvm-project/commit/28c878aeb29a7e7a9ae8f748de6a3c41482b97be.dif

[Lldb-commits] [lldb] 9bd72b5 - [LLDB] Remove cases of using namespace std

Author: Shafik Yaghmour Date: 2022-03-04T12:50:25-08:00 New Revision: 9bd72b5c258549b8743557a79c7929de38f05a6d URL: https://github.com/llvm/llvm-project/commit/9bd72b5c258549b8743557a79c7929de38f05a6d DIFF: https://github.com/llvm/llvm-project/commit/9bd72b5c258549b8743557a79c7929de38f05a6d.dif

[Lldb-commits] [lldb] ae869d4 - [LLDB] Remove cases of using namespace llvm:: from header file

Author: Shafik Yaghmour Date: 2022-03-03T10:39:06-08:00 New Revision: ae869d448499327a2e6435fafb0ac6ed0f205e66 URL: https://github.com/llvm/llvm-project/commit/ae869d448499327a2e6435fafb0ac6ed0f205e66 DIFF: https://github.com/llvm/llvm-project/commit/ae869d448499327a2e6435fafb0ac6ed0f205e66.dif

[Lldb-commits] [lldb] 14101f4 - [LLDB] Remove recursive include of GDBRemoteCommunicationServerCommon.h

Author: Shafik Yaghmour Date: 2022-02-21T18:46:12-08:00 New Revision: 14101f48d205b6cbf65b28c469d898e90e3995d2 URL: https://github.com/llvm/llvm-project/commit/14101f48d205b6cbf65b28c469d898e90e3995d2 DIFF: https://github.com/llvm/llvm-project/commit/14101f48d205b6cbf65b28c469d898e90e3995d2.dif

[Lldb-commits] [lldb] 08a6229 - [LLDB] Adding skipif for arm linux for TestStructuredBinding.py

Author: Shafik Yaghmour Date: 2022-02-17T14:30:54-08:00 New Revision: 08a6229e214bd75aed975c610aaff6026c5d2880 URL: https://github.com/llvm/llvm-project/commit/08a6229e214bd75aed975c610aaff6026c5d2880 DIFF: https://github.com/llvm/llvm-project/commit/08a6229e214bd75aed975c610aaff6026c5d2880.dif

[Lldb-commits] [lldb] f6d3901 - [LLDB] Fix TestStructuredBinding.py for libstdc++

Author: Shafik Yaghmour Date: 2022-02-17T11:30:07-08:00 New Revision: f6d390193cbcc3b9a0e900202023bd80bd5ac4a4 URL: https://github.com/llvm/llvm-project/commit/f6d390193cbcc3b9a0e900202023bd80bd5ac4a4 DIFF: https://github.com/llvm/llvm-project/commit/f6d390193cbcc3b9a0e900202023bd80bd5ac4a4.dif

[Lldb-commits] [lldb] f56cb52 - [DEBUGINFO] [LLDB] Add support for generating debug-info for structured bindings of structs and arrays

Author: Shafik Yaghmour Date: 2022-02-17T11:14:14-08:00 New Revision: f56cb520d8554ca42a215e82ecfa58d0b6c178e4 URL: https://github.com/llvm/llvm-project/commit/f56cb520d8554ca42a215e82ecfa58d0b6c178e4 DIFF: https://github.com/llvm/llvm-project/commit/f56cb520d8554ca42a215e82ecfa58d0b6c178e4.dif

[Lldb-commits] [lldb] 80a11e0 - [LLDB] Replace use of double underscore in identifiers

Author: Shafik Yaghmour Date: 2022-02-16T11:54:45-08:00 New Revision: 80a11e0803585556804274fc374b208901aa7a94 URL: https://github.com/llvm/llvm-project/commit/80a11e0803585556804274fc374b208901aa7a94 DIFF: https://github.com/llvm/llvm-project/commit/80a11e0803585556804274fc374b208901aa7a94.dif

[Lldb-commits] [lldb] c0e4154 - Fix clang-tidy bugprone-argument-comment that was mixed up

Author: Shafik Yaghmour Date: 2022-01-11T11:12:28-08:00 New Revision: c0e415471136a16cc98c9ce57392efd62db51c1f URL: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f DIFF: https://github.com/llvm/llvm-project/commit/c0e415471136a16cc98c9ce57392efd62db51c1f.dif

[Lldb-commits] [lldb] 4f6d3a3 - [LLDB] Fix setting of success in Socket::Close()

Author: Shafik Yaghmour Date: 2022-01-07T12:42:58-08:00 New Revision: 4f6d3a376c9faba93bbdf105966cea7585b0b8e9 URL: https://github.com/llvm/llvm-project/commit/4f6d3a376c9faba93bbdf105966cea7585b0b8e9 DIFF: https://github.com/llvm/llvm-project/commit/4f6d3a376c9faba93bbdf105966cea7585b0b8e9.dif

Re: [Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

I am wondering if you also need to check if token != LLDB_INVALID_ADDRESS > On Dec 4, 2021, at 6:34 PM, Kazu Hirata via lldb-commits > wrote: > > > Author: Kazu Hirata > Date: 2021-12-04T18:34:29-08:00 > New Revision: ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a > > URL: > https://github.com/llv

[Lldb-commits] [lldb] 0d62e31 - [LLDB][NFC] Fix test that broke due to libc++ std::vector changes

Author: Shafik Yaghmour Date: 2021-11-10T12:29:08-08:00 New Revision: 0d62e31c458526e1db37d11da947e61768c7b522 URL: https://github.com/llvm/llvm-project/commit/0d62e31c458526e1db37d11da947e61768c7b522 DIFF: https://github.com/llvm/llvm-project/commit/0d62e31c458526e1db37d11da947e61768c7b522.dif

[Lldb-commits] [lldb] 320f65e - [LLDB][NFC] Remove parameter names from forward declarations from hand written expressions used in heap.py part 2

Author: Shafik Yaghmour Date: 2021-10-19T16:52:36-07:00 New Revision: 320f65ee65f40fadbd2016036e538e28ae28614c URL: https://github.com/llvm/llvm-project/commit/320f65ee65f40fadbd2016036e538e28ae28614c DIFF: https://github.com/llvm/llvm-project/commit/320f65ee65f40fadbd2016036e538e28ae28614c.dif

Re: [Lldb-commits] [lldb] 5f6f33d - [lldb/Plugins] Move member template specialization out of class

This may actually be a gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85282 Not much we can do now but worth knowing in case it is fixed. > On Sep 3, 2021, at 3:19 PM, Med Ismail Bennani via lldb-commits > wrote: > > > Author: Med

Re: [Lldb-commits] [lldb] 2ce889f - [lldb][NFC] Add size tests for empty records with alignment and with empty members

Interesting to note that zero sized arrays are an extension, so are empty structs which require a diagnostic in C but are well-formed C++. It is unfortunate that we have divergence in that extension. > On Aug 30, 2021, at 7:38 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: Raph

[Lldb-commits] [lldb] 2a4a498 - [LLDB] Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

Author: Shafik Yaghmour Date: 2021-08-26T11:17:47-07:00 New Revision: 2a4a498a884ad929dad5dc72e20c76adfecfc78c URL: https://github.com/llvm/llvm-project/commit/2a4a498a884ad929dad5dc72e20c76adfecfc78c DIFF: https://github.com/llvm/llvm-project/commit/2a4a498a884ad929dad5dc72e20c76adfecfc78c.dif

[Lldb-commits] [lldb] 0479afb - [LLDB] Fix off by one logging placeholders in ClangASTSource::layoutRecordType()

Author: Shafik Yaghmour Date: 2021-08-17T16:47:46-07:00 New Revision: 0479afb3d6a31668631464653f07154d6850e4a1 URL: https://github.com/llvm/llvm-project/commit/0479afb3d6a31668631464653f07154d6850e4a1 DIFF: https://github.com/llvm/llvm-project/commit/0479afb3d6a31668631464653f07154d6850e4a1.dif

Re: [Lldb-commits] [lldb] 172a55e - [lldb] Fix FunctionDecl::Create after D102343

Thanks for catching and fixing this! > On Jul 29, 2021, at 9:57 AM, Fangrui Song via lldb-commits > wrote: > > > Author: Fangrui Song > Date: 2021-07-29T09:57:10-07:00 > New Revision: 172a55e7a40d27c7882be2e86d515696d8e12427 > > URL: > https://github.com/llvm/llvm-project/commit/172a55e7a40d

[Lldb-commits] [lldb] ae1a699 - [LLDB][NFC] Remove parameter names from forward declarations from hand written expressions used in heap.py

Author: Shafik Yaghmour Date: 2021-06-08T14:27:02-07:00 New Revision: ae1a699554cfa01d9fb307a964c3a9f71831a62e URL: https://github.com/llvm/llvm-project/commit/ae1a699554cfa01d9fb307a964c3a9f71831a62e DIFF: https://github.com/llvm/llvm-project/commit/ae1a699554cfa01d9fb307a964c3a9f71831a62e.dif

Re: [Lldb-commits] [lldb] 8dd1060 - [debugserver] Add platform cache support to improve performance.

So I guess we don’t use in class member initialization for m_platform b/c GetPlatform() can never be called before either Clear() or Detach()? > On May 20, 2021, at 7:10 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: kuperxu > Date: 2021-05-20T19:10:46-07:00 > New Revision: 8dd

Re: [Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

*sigh*I wish we had std::bit_cast instead of using union based type punning, we do have __builtin_bit_cast but it is different enough that replacing it later on w/ std::bit_cast wouldn’t just be search/replace. > On May 19, 2021, at 12:37 PM, Raphael Isemann via lldb-commits > wrote: > > > A

Re: [Lldb-commits] [lldb] d017d12 - [lldb][NFC] Cleanup IRForTarget member initializers

If you are doing further clean-up here, it almost looks like those two reference members could actually be owned by IRForTarget i.e. m_execution_unit m_error_stream Which would be cleaner. > On May 18, 2021, at 1:49 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: Raphael Is

[Lldb-commits] [lldb] 2182eda - [LLDB] Switch from using member_clang_type.GetByteSize() to member_type->GetByteSize() in ParseSingleMember

Author: Shafik Yaghmour Date: 2021-05-17T10:36:35-07:00 New Revision: 2182eda3062471e2e6994307c46ffcca7e39ecff URL: https://github.com/llvm/llvm-project/commit/2182eda3062471e2e6994307c46ffcca7e39ecff DIFF: https://github.com/llvm/llvm-project/commit/2182eda3062471e2e6994307c46ffcca7e39ecff.dif

Re: [Lldb-commits] [lldb] 30fcdf0 - [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec

Apologies, I see now you fixed it in a separate commit. > On May 5, 2021, at 10:19 AM, Shafik Yaghmour via lldb-commits > wrote: > > The last > > location_spec > > On line 341 does not seem to be used. > >> On May 4, 2021, at 5:34 PM, Med Ismail Bennani

Re: [Lldb-commits] [lldb] 30fcdf0 - [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec

The last location_spec On line 341 does not seem to be used. > On May 4, 2021, at 5:34 PM, Med Ismail Bennani via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > > > Author: Med Ismail Bennani > Date: 2021-05-05T00:34:44Z > New Revision: 30fcdf0b19661ca77767bd41ceba03f5dd33

Re: [Lldb-commits] [lldb] cd64273 - [lldb/ELF] Fix IDs of synthetic eh_frame symbols

Having side effects in the argument to a function call just feels like a bad idea in general even if it seems obviously correct here e.g. ++last_symbol_id, Can’t we just do: uint64_t last_symbol_id = num_symbols ? symbol_table->SymbolAtIndex(num_symbols - 1)->GetID() + 1: 1; Thank

[Lldb-commits] [lldb] ebee457 - [LLLDB] Adding additional check LibCppStdFunctionCallableInfo based on crash reports

Author: Shafik Yaghmour Date: 2021-04-14T16:28:38-07:00 New Revision: ebee45713190d9844ef860bf491035e3dcf3a538 URL: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538 DIFF: https://github.com/llvm/llvm-project/commit/ebee45713190d9844ef860bf491035e3dcf3a538.dif

Re: [Lldb-commits] [lldb] 8a5af9e - [debugserver] Fix unintialized member variable

I might be missing something here but I think m_launch_flavor Is also uninitialized. It looks like using in class member initialization would be a better fix for any case where the constructor is just a member initialization list with an empty body. > On Apr 13, 2021, at 9:47 AM, Jonas Devl

[Lldb-commits] [lldb] d9c9c0b - [LLDB][NFC] Add clarifying comments for AddCXXSummary and AddCXXSynthetic

Author: Shafik Yaghmour Date: 2021-04-09T12:07:24-07:00 New Revision: d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc URL: https://github.com/llvm/llvm-project/commit/d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc DIFF: https://github.com/llvm/llvm-project/commit/d9c9c0b2db0dc4ddf407edcafba0a5a806850ddc.dif

[Lldb-commits] [lldb] 79ac5bb - [LLDB] Clarifying the documentation for variable formatting wrt to qualifiers and adding a test that demonstrates this

Author: Shafik Yaghmour Date: 2021-04-07T14:29:12-07:00 New Revision: 79ac5bbb96c46e3c6c3568a441c13aa10c087b25 URL: https://github.com/llvm/llvm-project/commit/79ac5bbb96c46e3c6c3568a441c13aa10c087b25 DIFF: https://github.com/llvm/llvm-project/commit/79ac5bbb96c46e3c6c3568a441c13aa10c087b25.dif

[Lldb-commits] [lldb] ec00502 - [NFC][LLDB] Removing extra semicolons to silence -Wc++98-compat-extra-semi diagnostics

Author: Shafik Yaghmour Date: 2021-03-23T14:32:36-07:00 New Revision: ec00502b9f4021112c22b87ff849ecb5505763dd URL: https://github.com/llvm/llvm-project/commit/ec00502b9f4021112c22b87ff849ecb5505763dd DIFF: https://github.com/llvm/llvm-project/commit/ec00502b9f4021112c22b87ff849ecb5505763dd.dif

[Lldb-commits] [lldb] 080ba85 - Revert "Fix for Modify TypePrinter to differentiate between anonymous struct and unnamed struct"

Author: Shafik Yaghmour Date: 2021-02-18T18:17:24-08:00 New Revision: 080ba851c61604f9c00117b584191c67cfc468cd URL: https://github.com/llvm/llvm-project/commit/080ba851c61604f9c00117b584191c67cfc468cd DIFF: https://github.com/llvm/llvm-project/commit/080ba851c61604f9c00117b584191c67cfc468cd.dif

[Lldb-commits] [lldb] 1e08193 - Fix for Modify TypePrinter to differentiate between anonymous struct and unnamed struct

Author: Shafik Yaghmour Date: 2021-02-18T17:57:40-08:00 New Revision: 1e0819395657a9306f609849dcd3be9d7fb0c894 URL: https://github.com/llvm/llvm-project/commit/1e0819395657a9306f609849dcd3be9d7fb0c894 DIFF: https://github.com/llvm/llvm-project/commit/1e0819395657a9306f609849dcd3be9d7fb0c894.dif

[Lldb-commits] [lldb] 9f17599 - [LLDB] Fix LLDB_LOG calls to use correct formatting

Author: Shafik Yaghmour Date: 2021-02-12T11:09:39-08:00 New Revision: 9f175998debcbb14e95d7e94ca5fee26f4acc63b URL: https://github.com/llvm/llvm-project/commit/9f175998debcbb14e95d7e94ca5fee26f4acc63b DIFF: https://github.com/llvm/llvm-project/commit/9f175998debcbb14e95d7e94ca5fee26f4acc63b.dif

[Lldb-commits] [lldb] 4f14c17 - [LLDB] Remove uneeded CopyType from BlockPointerSyntheticFrontEnd

Author: Shafik Yaghmour Date: 2021-02-09T16:11:28-08:00 New Revision: 4f14c17df70916913d71914343dd4f6c709e218d URL: https://github.com/llvm/llvm-project/commit/4f14c17df70916913d71914343dd4f6c709e218d DIFF: https://github.com/llvm/llvm-project/commit/4f14c17df70916913d71914343dd4f6c709e218d.dif

[Lldb-commits] [lldb] dc057e8 - [LLDB] Fix how ObjCBOOLSummaryProvider deals with BOOL

Author: Shafik Yaghmour Date: 2021-01-22T10:05:24-08:00 New Revision: dc057e87f6c18c24d17c7cae97ebe95f78b6d934 URL: https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934 DIFF: https://github.com/llvm/llvm-project/commit/dc057e87f6c18c24d17c7cae97ebe95f78b6d934.dif

[Lldb-commits] [Differential] D83433: Fix how we handle bit-fields for Objective-C when creating an AST

This revision was automatically updated to reflect the committed changes. Closed by commit rGa54c42df9a72: Fix how we handle bit-fields for Objective-C when creating an AST (authored by shafik). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D83433?vs=278026&id=

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

> On Apr 16, 2020, at 3:17 PM, Davidino Italiano wrote: > > > >> On Apr 16, 2020, at 2:37 PM, Shafik Yaghmour via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >>> >>> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere vi

Re: [Lldb-commits] [lldb] 9f6a308 - [lldb/Utility] Fix a bug in stringify_append for printing addresses.

> On Apr 16, 2020, at 2:04 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-16T14:03:55-07:00 > New Revision: 9f6a308457d1bfebf1cee94b0306e738f270e512 > > URL: > https://github.com/llvm/llvm-project/commit/9f6a308457d1bfebf1cee94b0306e738f270e51

Re: [Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

Hello Saleem, I am not familiar with this part of the code but is there an easy way to test this failure? We should add a test to make sure we don’t break this accidentally in the future. Thank you! > On Apr 6, 2020, at 5:38 PM, Saleem Abdulrasool via lldb-commits > wrote: > > > Author: Sa

Re: [Lldb-commits] [lldb] 3806b38 - [LLDB] Initialize temporary token

Thank you for catching this and fixing it! > On Mar 30, 2020, at 7:13 AM, Benjamin Kramer via lldb-commits > wrote: > > > Author: Benjamin Kramer > Date: 2020-03-30T16:12:50+02:00 > New Revision: 3806b38045c08c674dc5db65bb06cf3dc34b9cc7 > > URL: > https://github.com/llvm/llvm-project/commit/

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

This is a lot of errors, did it the index use to start at one before? There is a type below, noted inline > On Mar 4, 2020, at 10:33 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: Raphael Isemann > Date: 2020-03-04T10:32:50-08:00 > New Revision: e98ef0af2c725f12dc60556a039e947dd

Re: [Lldb-commits] [lldb] b6b3fcd - [lldb] Don't iterate over a std::set in SymbolFileDWARF::GetTypes to make it deterministic

> On Mar 2, 2020, at 3:47 PM, Davide Italiano via lldb-commits > wrote: > > > >> On Mar 2, 2020, at 15:44, Raphael “Teemperor” Isemann >> wrote: >> >> I was just grepping for unordered data structures (e.g. ’std::set<‘) that >> use pointers/pointer-like objects (e.g. CompilerType with it

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

Decl* > On Jan 2, 2020, at 4:20 PM, Shafik Yaghmour via lldb-commits > wrote: > > Apologies, m_opaque_decl member of CompilerDecl and operator < in > CompilerDecl.h > >> On Jan 2, 2020, at 3:54 PM, Raphael “Teemperor” Isemann >> wrote: >> >> N

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

Apologies, m_opaque_decl member of CompilerDecl and operator < in CompilerDecl.h > On Jan 2, 2020, at 3:54 PM, Raphael “Teemperor” Isemann > wrote: > > Not sure if I can follow. What variable should just be a Decl* and what > operator > (Also yeah that reinterpret_cast could also be a stati

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

I am not crazy about the reinterpret_cast although if we look inside CompilerDecl impl we can see that basically it is always assuming it is a Decl* and just C-style casts it as such. So why not just make it a Decl* Also operator<(…) is super sketchy doing a < on void* > On Dec 28, 2019, at 6:

Re: [Lldb-commits] [lldb] fe8e25a - [lldb][NFC] Create type-safe function for creating a CompilerType from a QualType

Instead of GetType(...) I think GetCompilerType(…) is better or maybe even GetAsCompilerType(…). It adds a bit more context, we have so many types. It also feels a bit more consistent with methods like: > On Jan 2, 2020, at 2:55 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: R

Re: [Lldb-commits] [lldb] 6e3ecd1 - [lldb] Fix dwo variant of TestLibCxxFunction

Pavel, Thank you for fixing this! > On Nov 14, 2019, at 7:30 AM, Pavel Labath via lldb-commits > wrote: > > > Author: Pavel Labath > Date: 2019-11-14T16:29:36+01:00 > New Revision: 6e3ecd18847cb5c5bbe41d23428e1aa57ed1b339 > > URL: > https://github.com/llvm/llvm-project/commit/6e3ecd18847cb

Re: [Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

Stella, Thank you for the heads up, I am looking at it now. -Shafik > On Oct 29, 2019, at 11:04 AM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > This is broken on Windows. I moved the Buildbot to staging to resolve some of > the issues with the move to

[Lldb-commits] [lldb] r374570 - [lldb-test] Modify lldb-test to print out ASTs from symbol file

Author: shafik Date: Fri Oct 11 09:36:20 2019 New Revision: 374570 URL: http://llvm.org/viewvc/llvm-project?rev=374570&view=rev Log: [lldb-test] Modify lldb-test to print out ASTs from symbol file Summary: Currently when invoking lldb-test symbols -dump-ast it parses all the debug symbols and ca

[Lldb-commits] [lldb] r374077 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: shafik Date: Tue Oct 8 09:24:28 2019 New Revision: 374077 URL: http://llvm.org/viewvc/llvm-project?rev=374077&view=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit 080f35fb875f52c924ee37ed4d56a51fe7056afa. Conflicts:

Re: [Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

Pavel, It looks like this change breaks a couple of tests: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2315/ Reverting it fixes those on my end. -Shafik > On Oct 7, 2019, at 10:17 AM, Pavel Labath via lldb-commits

[Lldb-commits] [lldb] r373229 - [lldb][NFC] Updating test to reflect made by D67966

Author: shafik Date: Mon Sep 30 09:57:35 2019 New Revision: 373229 URL: http://llvm.org/viewvc/llvm-project?rev=373229&view=rev Log: [lldb][NFC] Updating test to reflect made by D67966 Summary: D67966 changes the output when dumping DWARF expressions and this updates basic_entry_values_x86_64 te

Re: [Lldb-commits] [lldb] r370848 - [lldb][NFC] Add a simple test for thread_local storage.

It seems like it would also be useful to test that threads actually see their own copy as well. > On Sep 4, 2019, at 1:02 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Sep 4 01:02:52 2019 > New Revision: 370848 > > URL: http://llvm.org/viewvc/llvm-project?re

Re: [Lldb-commits] [lldb] r370199 - [lldb][NFC] Test named operators like new and function names that might confuse LLDB

This test seems to be missing at least the address-of, delete and the comma operator in this test. Probably should cover array delete and new as well. > On Aug 28, 2019, at 6:33 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Wed Aug 28 06:33:52 2019 > New Revision:

[Lldb-commits] [lldb] r368937 - Improve anonymous class heuristic in ClangASTContext::CreateRecordType

Author: shafik Date: Wed Aug 14 15:30:29 2019 New Revision: 368937 URL: http://llvm.org/viewvc/llvm-project?rev=368937&view=rev Log: Improve anonymous class heuristic in ClangASTContext::CreateRecordType Summary: Currently the heuristic used in ClangASTContext::CreateRecordType to identify an an

[Lldb-commits] [lldb] r367726 - Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

Author: shafik Date: Fri Aug 2 14:41:50 2019 New Revision: 367726 URL: http://llvm.org/viewvc/llvm-project?rev=367726&view=rev Log: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl Summary: The change https://reviews.llvm.org/D55575 modified ClangASTContext::CreateParameterDe

[Lldb-commits] [lldb] r367701 - [Formatters] Temporarily disable libc++ std::function formatter due to performance issue

Author: shafik Date: Fri Aug 2 11:16:04 2019 New Revision: 367701 URL: http://llvm.org/viewvc/llvm-project?rev=367701&view=rev Log: [Formatters] Temporarily disable libc++ std::function formatter due to performance issue Summary: We have been seeing increased reports of performance issue around

[Lldb-commits] [lldb] r366365 - Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory

Author: shafik Date: Wed Jul 17 13:16:13 2019 New Revision: 366365 URL: http://llvm.org/viewvc/llvm-project?rev=366365&view=rev Log: Fix CreateFunctionTemplateSpecialization to prevent dangling poiner to stack memory In ClangASTContext::CreateFunctionTemplateSpecializationInfo a TemplateArgumen

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

Apologies, I somehow missed the offset < 0. > On Jun 5, 2019, at 12:38 PM, Pavel Labath wrote: > > On 05/06/2019 21:23, Shafik Yaghmour via lldb-commits wrote: >> abs(offset) is not the same as addr_t(-offset) > > It is, if you assume that offset is negative, wh

Re: [Lldb-commits] [lldb] r362570 - Fix -Wsign-compare by explicit cast after r362557

abs(offset) is not the same as addr_t(-offset) AFAICT offset is positive so we are casting a small negative number to an unsigned type which will result in a really large value e.g. https://godbolt.org/z/B2Z7Ok > On Jun 4, 2019, at 6:49 PM, Fangrui Song via lldb-commits > wrote: > > Author: m

[Lldb-commits] [lldb] r360599 - [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndType()

Author: shafik Date: Mon May 13 09:48:06 2019 New Revision: 360599 URL: http://llvm.org/viewvc/llvm-project?rev=360599&view=rev Log: [DataFormatters] FindLibCppStdFunctionCallableInfo() currently uses FindFunctions() in order to find a lambdas operator()() but using FindSymbolsMatchingRegExAndTy

[Lldb-commits] [lldb] r359921 - Fix for ambiguous lookup in expressions between local variable and namespace

Author: shafik Date: Fri May 3 12:59:22 2019 New Revision: 359921 URL: http://llvm.org/viewvc/llvm-project?rev=359921&view=rev Log: Fix for ambiguous lookup in expressions between local variable and namespace Summary: In an Objective-C context a local variable and namespace can cause an ambiguou

[Lldb-commits] [lldb] r359732 - Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

Author: shafik Date: Wed May 1 15:23:06 2019 New Revision: 359732 URL: http://llvm.org/viewvc/llvm-project?rev=359732&view=rev Log: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF Summary: This will fix a bug where during expression parsing w

[Lldb-commits] [lldb] r359699 - Disabling test in TestClassTemplateParameterPack.py until we do template lookup correctly

Author: shafik Date: Wed May 1 09:39:31 2019 New Revision: 359699 URL: http://llvm.org/viewvc/llvm-project?rev=359699&view=rev Log: Disabling test in TestClassTemplateParameterPack.py until we do template lookup correctly Summary: Some tests currently only work because we are pulling all the lo

[Lldb-commits] [lldb] r359118 - [DataFormatters] Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix

Author: shafik Date: Wed Apr 24 10:38:40 2019 New Revision: 359118 URL: http://llvm.org/viewvc/llvm-project?rev=359118&view=rev Log: [DataFormatters] Adjusting libc++ std::list formatter to act better with pointers and references and adding a test to cover a previous related fix Summary: This pr

[Lldb-commits] [lldb] r358462 - [ASTImporter] Regression test to ensure that we handling importing of anonymous enums correctly

Author: shafik Date: Mon Apr 15 16:05:45 2019 New Revision: 358462 URL: http://llvm.org/viewvc/llvm-project?rev=358462&view=rev Log: [ASTImporter] Regression test to ensure that we handling importing of anonymous enums correctly Summary: https://reviews.llvm.org/D51633 added error handling in th

[Lldb-commits] [lldb] r357210 - Fix for regression test, since we rely on the formatter for std::vector in the test we need a libc++ category.

Author: shafik Date: Thu Mar 28 13:25:57 2019 New Revision: 357210 URL: http://llvm.org/viewvc/llvm-project?rev=357210&view=rev Log: Fix for regression test, since we rely on the formatter for std::vector in the test we need a libc++ category. See differential https://reviews.llvm.org/D59847 for

[Lldb-commits] [lldb] r357188 - Regression test to ensure that we handling importing of std::vector of enums correctly

Author: shafik Date: Thu Mar 28 10:22:13 2019 New Revision: 357188 URL: http://llvm.org/viewvc/llvm-project?rev=357188&view=rev Log: Regression test to ensure that we handling importing of std::vector of enums correctly Summary: https://reviews.llvm.org/D59845 added a fix for the IsStructuralMat

[Lldb-commits] [lldb] r355525 - Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing

Author: shafik Date: Wed Mar 6 10:03:54 2019 New Revision: 355525 URL: http://llvm.org/viewvc/llvm-project?rev=355525&view=rev Log: Adding test to cover the correct import of SourceLocation pertaining to a built-in during expression parsing Summary: This tests a fix in the ASTImpoter.cpp to ens

[Lldb-commits] [lldb] r355422 - [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913

Author: shafik Date: Tue Mar 5 10:34:35 2019 New Revision: 355422 URL: http://llvm.org/viewvc/llvm-project?rev=355422&view=rev Log: [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913 rdar://problem/48568543 Modified: lldb/trunk/source/

[Lldb-commits] [lldb] r355352 - Revert "[DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913"

Author: shafik Date: Mon Mar 4 16:29:58 2019 New Revision: 355352 URL: http://llvm.org/viewvc/llvm-project?rev=355352&view=rev Log: Revert "[DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913"; This reverts commit r355351. Modified: lld

[Lldb-commits] [lldb] r355351 - [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913

Author: shafik Date: Mon Mar 4 16:17:18 2019 New Revision: 355351 URL: http://llvm.org/viewvc/llvm-project?rev=355351&view=rev Log: [DataFormatters] Fix regression in libc++ std::atomic formatter caused by https://reviews.llvm.org/D56913 rdar://problem/48568543 Modified: lldb/trunk/source/

[Lldb-commits] [lldb] r352772 - Fix use of non-existing variable in crashlog.py

Author: shafik Date: Thu Jan 31 09:33:17 2019 New Revision: 352772 URL: http://llvm.org/viewvc/llvm-project?rev=352772&view=rev Log: Fix use of non-existing variable in crashlog.py Summary: The method find_matching_slice(self) uses uuid_str on one of the paths but the variable does not exist and

[Lldb-commits] [lldb] r352677 - Fix handling of CreateTemplateParameterList when there is an empty pack

Author: shafik Date: Wed Jan 30 13:48:56 2019 New Revision: 352677 URL: http://llvm.org/viewvc/llvm-project?rev=352677&view=rev Log: Fix handling of CreateTemplateParameterList when there is an empty pack Summary: When we are creating a ClassTemplateSpecializationDecl in ParseTypeFromDWARF(...)

[Lldb-commits] [lldb] r348810 - [DataFormatters] Fixes to libc++ std::function formatter to deal with ABI change see

Author: shafik Date: Mon Dec 10 15:26:38 2018 New Revision: 348810 URL: http://llvm.org/viewvc/llvm-project?rev=348810&view=rev Log: [DataFormatters] Fixes to libc++ std::function formatter to deal with ABI change see https://reviews.llvm.org/D55045 Modified: lldb/trunk/source/Target/CP

Re: [Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

Pavel, I just reverted it. -Shafik > On Dec 7, 2018, at 10:46 AM, Pavel Labath via lldb-commits > wrote: > > On 07/12/2018 19:39, Davide Italiano wrote: >> Pavel, this broke the MacOS lldb cmake bot. >> In particular, this test started failing. >> lldb-Suite.macosx/function-starts.TestFunctio

  1   2   >