[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added a comment. Yes, will take a look. I had `check-lldb` pass for the new tests locally previously - I'll rebase and rerun and see what happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D10835

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added a comment. Hey there - just wondering if someone might be able to merge this in a while? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 ___ ll

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367815. saschwartz added a comment. Stick with integer return codes from lldb-platform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lld

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz marked 5 inline comments as done. saschwartz added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } teemper

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367688. saschwartz marked an inline comment as done. saschwartz added a comment. Fix one missed return nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367685. saschwartz added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lldb-server/TestErrorMessages.

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added a comment. Responded to comments - will tidy up the nits. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:289 fprintf(stderr, "failed to create acceptor: %s", error.AsCString()); -exit(socket_error); +return -1; } teemperor

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367508. saschwartz added a comment. Fix lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lldb-server/TestErrorMessages.test lldb/tes

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:324 WithColor::error() << error.AsCString() << '\n'; - exit(socket_error); + return socket_error; } teemperor wrote: > FWIW, `socket_error` seems to be ju

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367498. saschwartz added a comment. Use `make_scope_exit` to avoid superfluous return variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367401. saschwartz added a comment. Also propagate platform mode return codes and add additional test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files:

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz updated this revision to Diff 367397. saschwartz added a comment. Fix unannotated fallthrough in switch statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D108351 Files: lldb/test/Shell/lldb-

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

saschwartz created this revision. saschwartz added a reviewer: clayborg. saschwartz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff modifies the LLDB server return codes to more accurately reflect usage error paths. It additionall