Author: spyffe
Date: Thu Sep 28 13:20:25 2017
New Revision: 314458
URL: http://llvm.org/viewvc/llvm-project?rev=314458&view=rev
Log:
[Expression parser] Setting to enable use of ExternalASTMerger
This setting can be enabled like this at the target level:
(lldb) settings set target.experimental.u
Author: spyffe
Date: Tue Sep 26 10:25:34 2017
New Revision: 314225
URL: http://llvm.org/viewvc/llvm-project?rev=314225&view=rev
Log:
[Expression Parser] Inhibit global lookups for symbols in the IR dynamic checks
The IR dynamic checks are self-contained functions whose job is to
- verify that po
Author: spyffe
Date: Tue Aug 1 10:43:54 2017
New Revision: 309714
URL: http://llvm.org/viewvc/llvm-project?rev=309714&view=rev
Log:
xfail test_get_process_info pending bot fixes
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api/process/TestProcessAPI.py
Modified:
lldb/trunk/p
Vadim,
this patch is breaking
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11601
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/5560
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/6022
http://lab.llvm.org:8011/builders/lldb
Author: spyffe
Date: Tue Aug 1 10:08:46 2017
New Revision: 309702
URL: http://llvm.org/viewvc/llvm-project?rev=309702&view=rev
Log:
[build system] Add SBProcessInfo to the xcodeproj
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: spyffe
Date: Mon Jul 31 14:50:00 2017
New Revision: 309631
URL: http://llvm.org/viewvc/llvm-project?rev=309631&view=rev
Log:
[build-script] Bring in modernizations from downstream:
- Don't do any checks of the current SCM repository if the
llvm repositories are already there. Useful fo
Author: spyffe
Date: Tue Jul 25 15:44:34 2017
New Revision: 309046
URL: http://llvm.org/viewvc/llvm-project?rev=309046&view=rev
Log:
Skip test_unique_stacks on Darwin, because it doesn't terminate reliably.
rdar://problem/33462362
Modified:
lldb/trunk/packages/Python/lldbsuite/test/function
Author: spyffe
Date: Tue Jul 25 10:33:37 2017
New Revision: 308993
URL: http://llvm.org/viewvc/llvm-project?rev=308993&view=rev
Log:
[TypeSystem] Guard the global `ASTSourceMap` with a mutex
s_source_map in ClangExternalASTSourceCommon.cpp is unguarded
and therefore can break in multithreaded co
Author: spyffe
Date: Mon Jul 24 13:11:20 2017
New Revision: 308919
URL: http://llvm.org/viewvc/llvm-project?rev=308919&view=rev
Log:
Skip test_lldbmi_var_update on Darwin.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/TestMiVar.py
Modified:
lldb/trunk/packages/
Author: spyffe
Date: Thu Jun 29 17:39:17 2017
New Revision: 306773
URL: http://llvm.org/viewvc/llvm-project?rev=306773&view=rev
Log:
[Data formatters] Make NSSetM support both old- and new-style representation
NSSetM has two in-memory representations depending on what Foundation version
is in us
Author: spyffe
Date: Wed Jun 28 15:51:16 2017
New Revision: 306611
URL: http://llvm.org/viewvc/llvm-project?rev=306611&view=rev
Log:
Added a project for the unified IR interpreter.
Modified:
lldb/trunk/www/projects.html
Modified: lldb/trunk/www/projects.html
URL:
http://llvm.org/viewvc/llvm
Author: spyffe
Date: Tue Jun 27 13:35:53 2017
New Revision: 306460
URL: http://llvm.org/viewvc/llvm-project?rev=306460&view=rev
Log:
[build system] If there's an OVERRIDE, don't guess the current SCM.
This makes automatic checkout work even in situations where the
current repository can't be dete
Author: spyffe
Date: Fri Jun 23 18:15:03 2017
New Revision: 306180
URL: http://llvm.org/viewvc/llvm-project?rev=306180&view=rev
Log:
Updated the NSArray and NSDictionary formatters to support new storage formats.
Also un-xfailed a testcase that was affected by this. Thanks to Jason Molenda
for
Author: spyffe
Date: Mon Jun 19 13:32:22 2017
New Revision: 305727
URL: http://llvm.org/viewvc/llvm-project?rev=305727&view=rev
Log:
Updated NSNumber formatter for new internal representation.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter
Author: spyffe
Date: Wed Jun 14 18:01:43 2017
New Revision: 305424
URL: http://llvm.org/viewvc/llvm-project?rev=305424&view=rev
Log:
[testsuite] xfailed two tests that depend on NSString conforming to NSCopying.
NSString is loaded from the DWARF, which doesn't have the concept of protocols.
When
Author: spyffe
Date: Thu Jun 1 20:24:18 2017
New Revision: 304510
URL: http://llvm.org/viewvc/llvm-project?rev=304510&view=rev
Log:
[TypeSystem] Handle Clang AttributedTypes
When parsing types originating in modules, it is possible to encounter
AttributedTypes
(such as the type generated for N
Author: spyffe
Date: Wed May 31 12:18:10 2017
New Revision: 304314
URL: http://llvm.org/viewvc/llvm-project?rev=304314&view=rev
Log:
Added a testcase for local/namespaced name conflicts.
This works on SVN but is a bit fragile on the Swift branch.
I'm adding the test to both, so we have this path
Author: spyffe
Date: Tue May 16 18:46:13 2017
New Revision: 303223
URL: http://llvm.org/viewvc/llvm-project?rev=303223&view=rev
Log:
[Expression parser] Look up module symbols before hunting globally
When it resolves symbol-only variables, the expression parser
currently looks only in the global
Author: spyffe
Date: Mon May 15 14:55:20 2017
New Revision: 303110
URL: http://llvm.org/viewvc/llvm-project?rev=303110&view=rev
Log:
[TypeSystem] Fix inspection of Objective-C object types
ptr_refs exposed a problem in ClangASTContext's implementation: it
uses an accessor to downcast a QualType t
Author: spyffe
Date: Fri May 12 16:53:44 2017
New Revision: 302954
URL: http://llvm.org/viewvc/llvm-project?rev=302954&view=rev
Log:
Fixed the OS X build after Error -> Status rename.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: spyffe
Date: Thu May 11 18:38:21 2017
New Revision: 302850
URL: http://llvm.org/viewvc/llvm-project?rev=302850&view=rev
Log:
xfail TestClassTemplateParameterPack on gcc to mollify
lldb-x86_64-ubuntu-14.04-cmake.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/class-temp
Author: spyffe
Date: Thu May 11 17:08:05 2017
New Revision: 302833
URL: http://llvm.org/viewvc/llvm-project?rev=302833&view=rev
Log:
[DWARF parser] Produce correct template parameter packs
Templates can end in parameter packs, like this
template struct MyStruct
{ /*...*/ };
LLDB does not cu
Author: spyffe
Date: Tue May 2 19:41:43 2017
New Revision: 301993
URL: http://llvm.org/viewvc/llvm-project?rev=301993&view=rev
Log:
Fixed a bug where we did not properly use the complete versions of Objective-C
classes.
Also added a test case, thanks to Greg Clayton.
Added:
lldb/trunk/pac
Author: spyffe
Date: Wed Apr 26 15:36:47 2017
New Revision: 301461
URL: http://llvm.org/viewvc/llvm-project?rev=301461&view=rev
Log:
Fixed a crash when dealing with an empty method name in the ObjC runtime.
I've filed a bug covering better unit testing of our runtime metadata reader,
which will a
Author: spyffe
Date: Mon Apr 24 18:58:36 2017
New Revision: 301280
URL: http://llvm.org/viewvc/llvm-project?rev=301280&view=rev
Log:
Name the C++ source files for two tests correctly.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/main.cpp
- copied, changed from r3
Author: spyffe
Date: Mon Apr 24 18:49:06 2017
New Revision: 301277
URL: http://llvm.org/viewvc/llvm-project?rev=301277&view=rev
Log:
Fixed two bad Makefiles that might be breaking Linux.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/llvm-style/Makefile
lldb/trunk/packages/P
Author: spyffe
Date: Mon Apr 24 18:14:04 2017
New Revision: 301273
URL: http://llvm.org/viewvc/llvm-project?rev=301273&view=rev
Log:
[Expression parser] Return both types and variables
Many times a user wants to access a type when there's a variable of
the same name, or a variable when there's a
Author: spyffe
Date: Mon Apr 24 17:11:10 2017
New Revision: 301263
URL: http://llvm.org/viewvc/llvm-project?rev=301263&view=rev
Log:
[DWARF] Fix lookup in the abstract origins of inlined blocks/functions
LLDB uses clang::DeclContexts for lookups, and variables get put into
the DeclContext for the
Author: spyffe
Date: Thu Apr 20 13:07:51 2017
New Revision: 300862
URL: http://llvm.org/viewvc/llvm-project?rev=300862&view=rev
Log:
Changed a use of APInt::getSignBit to APInt::getSignMask.
Modified:
lldb/trunk/source/Core/Scalar.cpp
Modified: lldb/trunk/source/Core/Scalar.cpp
URL:
http://
Author: spyffe
Date: Wed Apr 5 15:33:39 2017
New Revision: 299587
URL: http://llvm.org/viewvc/llvm-project?rev=299587&view=rev
Log:
The darwin_log tests are very fragile and currently do not properly assess the
state of that functionality.
I have put them all in their own category, and made that
Author: spyffe
Date: Mon Apr 3 18:56:41 2017
New Revision: 299402
URL: http://llvm.org/viewvc/llvm-project?rev=299402&view=rev
Log:
Add CPlusPlusNameParser to the xcodeproj
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://l
This is not dead code in Swift-enabled LLDB, as I just found out doing a merge.
I'm going to use Default and see what breaks.
Sean
> On Mar 18, 2017, at 10:33 AM, Tamas Berghammer via lldb-commits
> wrote:
>
> Author: tberghammer
> Date: Sat Mar 18 12:33:00 2017
> New Revision: 298189
>
> U
Author: spyffe
Date: Wed Mar 29 14:32:59 2017
New Revision: 299020
URL: http://llvm.org/viewvc/llvm-project?rev=299020&view=rev
Log:
Move the definition of SBListener::GetSP() to SBListener.cpp.
This is the requirement for all functions in the public API,
to eliminate weak symbol definitions.
Mo
Thanks, Pavel.
I think if we do this again we should indirect the new API through the LLDB
FileSpec API or at least a global function somewhere in LLDB, so that we can
change implementations without having to touch so much source code.
Sean
> On Mar 7, 2017, at 5:19 AM, Pavel Labath via lldb-co
Author: spyffe
Date: Tue Mar 7 02:31:41 2017
New Revision: 297128
URL: http://llvm.org/viewvc/llvm-project?rev=297128&view=rev
Log:
Fixed a missing brace.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/Platfor
Author: spyffe
Date: Sat Mar 4 02:05:54 2017
New Revision: 296963
URL: http://llvm.org/viewvc/llvm-project?rev=296963&view=rev
Log:
Project file fixes after movement of Data* and removal of ThisThread.cpp
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodepro
Author: spyffe
Date: Fri Mar 3 19:48:43 2017
New Revision: 296951
URL: http://llvm.org/viewvc/llvm-project?rev=296951&view=rev
Log:
Disable the lldb-mi tests on remote platforms.
Currently on remote platforms the lldb-mi tests fail, which means they time out.
Given how many of the lldb-mi tests
Author: spyffe
Date: Fri Mar 3 17:13:30 2017
New Revision: 296924
URL: http://llvm.org/viewvc/llvm-project?rev=296924&view=rev
Log:
Fixed repo.py to not send git errors to stderr.
Some repos are not git repos, so git is expected
to fail. These errors should not go to stderr,
because Xcode inte
file data .done
Committing transaction...
Committed revision 295922.
Please let me know if you see any problems.
Sean
> On Feb 22, 2017, at 4:56 PM, Sean Callanan via lldb-commits
> wrote:
>
> I'll roll it back pending some fixes on my end.
> Sorry for the break.
>
Author: spyffe
Date: Wed Feb 22 20:21:34 2017
New Revision: 295922
URL: http://llvm.org/viewvc/llvm-project?rev=295922&view=rev
Log:
Changed builld-llvm.py to use .json files
LLDB has many branches in a variety of repositories.
The build-script.py file is subtly different for each set.
This is un
Author: spyffe
Date: Wed Feb 22 18:46:30 2017
New Revision: 295915
URL: http://llvm.org/viewvc/llvm-project?rev=295915&view=rev
Log:
Reverted 295897 pending refinements and fixes for green-dragon.
Removed:
lldb/trunk/scripts/Xcode/repo.py
lldb/trunk/scripts/Xcode/repos/
Modified:
lldb
ailures here?
>
> http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console
> <http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/26076/console>
>
> Thanks!
> -Tim
>
>
> On Wed, Feb 22, 2017 at 2:57 PM, Sean Callanan via lldb-commits
Author: spyffe
Date: Wed Feb 22 16:57:59 2017
New Revision: 295897
URL: http://llvm.org/viewvc/llvm-project?rev=295897&view=rev
Log:
Changed builld-llvm.py to use .json files
LLDB has many branches in a variety of repositories.
The build-script.py file is subtly different for each set.
This is un
Author: spyffe
Date: Fri Feb 17 19:07:51 2017
New Revision: 295522
URL: http://llvm.org/viewvc/llvm-project?rev=295522&view=rev
Log:
Updated the results formatter to eliminate redundant data.
The testsuite's results formatter maintains a result_status_counts
structure solely for the purpose of se
Author: spyffe
Date: Thu Jan 26 02:51:32 2017
New Revision: 293161
URL: http://llvm.org/viewvc/llvm-project?rev=293161&view=rev
Log:
Removed an unneccesary #if now that debugserver-mini links Foundation.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm
Modified: lldb/trunk
Author: spyffe
Date: Wed Jan 25 15:32:00 2017
New Revision: 293098
URL: http://llvm.org/viewvc/llvm-project?rev=293098&view=rev
Log:
Link debugserver against Foundation to get access to NSProcessInfo.
debugserver-mini can't use Foundation so disable that code there.
Modified:
lldb/trunk/too
Author: spyffe
Date: Tue Jan 24 23:39:14 2017
New Revision: 293022
URL: http://llvm.org/viewvc/llvm-project?rev=293022&view=rev
Log:
Reverted 292880 to fix a linker error.
Modified:
lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj
Modified: lldb/trunk/tools/debugserver/de
Author: spyffe
Date: Tue Jan 24 23:18:32 2017
New Revision: 293020
URL: http://llvm.org/viewvc/llvm-project?rev=293020&view=rev
Log:
Conditionalized OsLogger.cpp on a modern SDK.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/OsLogger.cpp
Modified: lldb/trunk/tools/debugserver/source/M
Author: spyffe
Date: Wed Dec 21 17:21:11 2016
New Revision: 290282
URL: http://llvm.org/viewvc/llvm-project?rev=290282&view=rev
Log:
specify -DNDEBUG for BNI builds of all targets in the Xcode build
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/proje
Author: spyffe
Date: Wed Dec 14 15:31:31 2016
New Revision: 289711
URL: http://llvm.org/viewvc/llvm-project?rev=289711&view=rev
Log:
Adopt PrettyStackTrace in LLDB
LLDB needs some minor changes to adopt PrettyStackTrace after
https://reviews.llvm.org/D27683.
We remove our own SetCrashDescription
ETA 10 minutes.
>
>> On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits
>> mailto:lldb-commits@lists.llvm.org>> wrote:
>>
>> It's definitely this one. I'll have a fix or a revert in the next 30
>> minutes.
>>> On Dec 1, 2016, at 10:58
Author: spyffe
Date: Thu Dec 1 13:14:55 2016
New Revision: 288403
URL: http://llvm.org/viewvc/llvm-project?rev=288403&view=rev
Log:
Handle empty strings when looking for a CFString's encoding.
Should fix the bots.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
Mo
It'll be a fix. ETA 10 minutes.
> On Dec 1, 2016, at 11:16 AM, Sean Callanan via lldb-commits
> wrote:
>
> It's definitely this one. I'll have a fix or a revert in the next 30 minutes.
>> On Dec 1, 2016, at 10:58 AM, Tim Hammerquist > <mailto:pen...@gma
sible the failure was introduced by either this
> commit (r288386) or possibly r288372.
>
> -Tim
>
>
> On Thu, Dec 1, 2016 at 9:46 AM, Sean Callanan via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
> Author: spyffe
> Date: Thu Dec 1 11:46:51 201
Author: spyffe
Date: Thu Dec 1 11:46:51 2016
New Revision: 288386
URL: http://llvm.org/viewvc/llvm-project?rev=288386&view=rev
Log:
Handle UTF-16 and UTF-32 constant CFStrings
We have a longstanding issue where the expression parser does not handle wide
CFStrings (e.g., @"凸凹") correctly, produc
Author: spyffe
Date: Wed Oct 19 19:03:39 2016
New Revision: 284674
URL: http://llvm.org/viewvc/llvm-project?rev=284674&view=rev
Log:
Added a decorator for the macOS version and switched over testcases that used
platform.release
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.p
Author: spyffe
Date: Tue Oct 11 11:57:21 2016
New Revision: 283904
URL: http://llvm.org/viewvc/llvm-project?rev=283904&view=rev
Log:
Clarified the explanation of expr --top-level.
Modified:
lldb/trunk/source/Commands/CommandObjectExpression.cpp
Modified: lldb/trunk/source/Commands/CommandObj
Author: spyffe
Date: Fri Oct 7 16:25:29 2016
New Revision: 283604
URL: http://llvm.org/viewvc/llvm-project?rev=283604&view=rev
Log:
Remove a stray dump().
Modified:
lldb/trunk/source/Expression/IRExecutionUnit.cpp
Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp
URL:
http://llv
Author: spyffe
Date: Fri Sep 30 15:46:09 2016
New Revision: 282943
URL: http://llvm.org/viewvc/llvm-project?rev=282943&view=rev
Log:
Adding ivars in class extensions isn't supported on i386; skip a test.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/persist_objc_poin
Author: spyffe
Date: Fri Sep 30 13:44:43 2016
New Revision: 282898
URL: http://llvm.org/viewvc/llvm-project?rev=282898&view=rev
Log:
Fixed several i386 Objective-C tests by completing objects, not their pointers.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/sou
Author: spyffe
Date: Fri Sep 30 11:02:28 2016
New Revision: 282869
URL: http://llvm.org/viewvc/llvm-project?rev=282869&view=rev
Log:
Skip TestRuntimeIvars on i386; the Objective-C V1 runtime doesn't list ivars.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-runtime-ivars/
Author: spyffe
Date: Thu Sep 29 17:01:11 2016
New Revision: 282794
URL: http://llvm.org/viewvc/llvm-project?rev=282794&view=rev
Log:
Don't expect new-style Objective-C literals to work on i386 with the V1 runtime.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-new-syntax/
Author: spyffe
Date: Thu Sep 29 16:43:31 2016
New Revision: 282787
URL: http://llvm.org/viewvc/llvm-project?rev=282787&view=rev
Log:
Fixed TestObjCMethods2/i386 by separating out the portions that require ObjC V2.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/foundation/TestO
Author: spyffe
Date: Thu Sep 29 12:57:33 2016
New Revision: 282741
URL: http://llvm.org/viewvc/llvm-project?rev=282741&view=rev
Log:
To fix TestObjCMethods2/i386, allowed messaging nil ObjC objects as in x86_64.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleO
Author: spyffe
Date: Wed Sep 28 19:45:33 2016
New Revision: 282657
URL: http://llvm.org/viewvc/llvm-project?rev=282657&view=rev
Log:
Fixed TestObjCStructArgument/i386; expressions can now call ObjC class methods.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
Author: spyffe
Date: Wed Sep 28 19:16:37 2016
New Revision: 282653
URL: http://llvm.org/viewvc/llvm-project?rev=282653&view=rev
Log:
Introduced a null check to avoid a crash in a test on i386.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.cpp
Author: spyffe
Date: Mon Sep 26 15:18:51 2016
New Revision: 282434
URL: http://llvm.org/viewvc/llvm-project?rev=282434&view=rev
Log:
Added a setting that enables saving all .o files from a given JIT expression.
This allows debugging of the JIT and other analyses of the internals of the
expression
Author: spyffe
Date: Mon Sep 19 17:06:12 2016
New Revision: 281943
URL: http://llvm.org/viewvc/llvm-project?rev=281943&view=rev
Log:
Fixed the build by changing a couple of const char *s to StringRefs.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
lldb/trunk/source/Host/macosx/HostInfoM
I agree completely with tackling the easy stuff first.
That said, the easy stuff (probably >50% of the testsuite) doesn't even require
command-line interaction and is just of the form "stop here, run this one
expression, maybe print this variable using 'frame variab'e'"
I would argue that we can
How different is that really from
(lldb) script lldb.frame.FindVariable("argc").GetValue()
'1'
(lldb) script lldb.process.GetNumThreads()
1
(lldb) script lldb.process.GetThreadAtIndex(0).GetThreadID()
3514809
? If it's developer-only, then this is even fairly well-documented using e.g.
"script
spyffe added a subscriber: spyffe.
spyffe added a comment.
I like this concept a lot, and I think it's great for testcases that actually
need to interact with the command line.
I'm concerned, though, that the separation of input from command files makes
tests more complex to write. One thing th
Author: spyffe
Date: Wed Sep 14 16:54:28 2016
New Revision: 281545
URL: http://llvm.org/viewvc/llvm-project?rev=281545&view=rev
Log:
More cleanup in `frame diagnose,` eliminating a bunch of messy cases.
Modified:
lldb/trunk/include/lldb/Core/Disassembler.h
lldb/trunk/source/Core/Disassemb
Author: spyffe
Date: Wed Sep 14 15:58:31 2016
New Revision: 281536
URL: http://llvm.org/viewvc/llvm-project?rev=281536&view=rev
Log:
Replaced two instances of std::function with auto.
Thanks to Zachary Turner for the suggestion. It's distasteful that the actual
type of the lambda can't be spelle
Okay, one sec.
Sean
> On Sep 14, 2016, at 1:40 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 14, 2016 at 1:38 PM Sean Callanan via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
>
> Instruction::Operand *origin_operand = nullptr;
Author: spyffe
Date: Wed Sep 14 15:29:57 2016
New Revision: 281534
URL: http://llvm.org/viewvc/llvm-project?rev=281534&view=rev
Log:
Cleaned up a little bit of redundant code in 'frame diagnose.`
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.
Author: spyffe
Date: Tue Sep 13 19:48:19 2016
New Revision: 281428
URL: http://llvm.org/viewvc/llvm-project?rev=281428&view=rev
Log:
Cleaned up the code that handles function return addresses in "frame diagnose."
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/T
Author: spyffe
Date: Tue Sep 13 16:18:27 2016
New Revision: 281398
URL: http://llvm.org/viewvc/llvm-project?rev=281398&view=rev
Log:
Cleaned up some of the "frame diagnose" code to use Operands as currency.
Also added some utility functions around Operands to make code easier and more
compact to
Author: spyffe
Date: Mon Sep 5 23:48:36 2016
New Revision: 280692
URL: http://llvm.org/viewvc/llvm-project?rev=280692&view=rev
Log:
Added the "frame diagnose" command and use its output to make crash info better.
When a process stops due to a crash, we get the crashing instruction and the
crashi
Author: spyffe
Date: Fri Aug 26 19:35:37 2016
New Revision: 279896
URL: http://llvm.org/viewvc/llvm-project?rev=279896&view=rev
Log:
Fixed the location of a conditional to make the following code clearer.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Mo
Author: spyffe
Date: Fri Aug 26 19:20:38 2016
New Revision: 279894
URL: http://llvm.org/viewvc/llvm-project?rev=279894&view=rev
Log:
The error stream in IRForTarget is never null, so use it instead of the log.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cp
Author: spyffe
Date: Fri Aug 26 18:48:03 2016
New Revision: 279884
URL: http://llvm.org/viewvc/llvm-project?rev=279884&view=rev
Log:
Fixed a bad lldbassert() condition.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins/E
Author: spyffe
Date: Fri Aug 26 13:12:39 2016
New Revision: 279850
URL: http://llvm.org/viewvc/llvm-project?rev=279850&view=rev
Log:
Don't crash when trying to capture persistent variables in a block.
Reports an error instead. We can fix this later to make persistent variables
work, but right no
Author: spyffe
Date: Thu Aug 18 12:45:50 2016
New Revision: 279098
URL: http://llvm.org/viewvc/llvm-project?rev=279098&view=rev
Log:
Fixed a problem where we failed to get the size of an Objective-C type.
Modified:
lldb/trunk/source/Expression/Materializer.cpp
Modified: lldb/trunk/source/E
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This looks fine. How tricky would it be to make a test case for a reproduction
scenario?
https://reviews.llvm.org/D21328
___
lldb-com
Author: spyffe
Date: Fri Jul 15 19:18:24 2016
New Revision: 275652
URL: http://llvm.org/viewvc/llvm-project?rev=275652&view=rev
Log:
Fixed the location of the Swift bindings in the Xcode build.
$BUILT_PRODUCTS_DIR is usually the same as $CONFIGURATION_BUILD_DIR, but differs
when LLDB is being bui
Reverted with r275237.
Sean
> On Jul 12, 2016, at 4:33 PM, Sean Callanan wrote:
>
> Argh, this isn’t what I wanted to commit AT ALL.
> Sorry folks. I’ll fix this momentarily.
> Thanks to Jim Ingham for pointing it out.
>
> Sean
>
>> On Jul 12, 2016, at 3
Author: spyffe
Date: Tue Jul 12 18:31:42 2016
New Revision: 275237
URL: http://llvm.org/viewvc/llvm-project?rev=275237&view=rev
Log:
Revert r275223, which committed the wrong thing.
Modified:
lldb/trunk/lldb.xcworkspace/contents.xcworkspacedata
Modified: lldb/trunk/lldb.xcworkspace/contents.
Argh, this isn’t what I wanted to commit AT ALL.
Sorry folks. I’ll fix this momentarily.
Thanks to Jim Ingham for pointing it out.
Sean
> On Jul 12, 2016, at 3:42 PM, Sean Callanan via lldb-commits
> wrote:
>
> Author: spyffe
> Date: Tue Jul 12 17:42:07 2016
> New Revisio
Author: spyffe
Date: Tue Jul 12 17:42:07 2016
New Revision: 275223
URL: http://llvm.org/viewvc/llvm-project?rev=275223&view=rev
Log:
Mark TagDecls as having external visible storage, like ContainerDecls.
The lookup tables can get out of date during the lifetime of the object so we
need to preserv
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
I'm concerned about the performance implications here, because
`FindBestAlternateMangledName` is invoked for every C++ symbol lookup, not just
for ones that would fail unless we did
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Yes, we should follow the same rules as in regular lookup for these contexts.
If the test suite is happy here, I'm happy.
http://reviews.llvm.org/D13350
__
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
Sorry for getting to this review so late.
This looks all right, and pretty conservative. As long as the test suite is
okay with it, this looks fine!
Thanks for the test case, too.
Repository
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This code has been eliminated as -part of a refactoring of the way IRForTarget
works.
I'm sorry that I didn't get to this review earlier, but at this point the patch
probably isn't w
Author: spyffe
Date: Tue Jul 5 17:06:01 2016
New Revision: 274580
URL: http://llvm.org/viewvc/llvm-project?rev=274580&view=rev
Log:
Fixed a bug where we report a single type multiple times in namespaces.
Also added a testcase.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/name
Author: spyffe
Date: Thu Jun 30 13:00:32 2016
New Revision: 274254
URL: http://llvm.org/viewvc/llvm-project?rev=274254&view=rev
Log:
Removed the redundant "%d errors parsing expression" error. Nobody keeps score.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/variable/T
Author: spyffe
Date: Fri Jun 24 15:41:18 2016
New Revision: 273718
URL: http://llvm.org/viewvc/llvm-project?rev=273718&view=rev
Log:
Added a test case for bitfield ivars. It currently fails.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/bitfield_ivars/
lldb/trunk/packages
Author: spyffe
Date: Thu Jun 23 19:24:40 2016
New Revision: 273632
URL: http://llvm.org/viewvc/llvm-project?rev=273632&view=rev
Log:
Handle variadic Objective-C methods from DWARF correctly.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/variadic_methods/
lldb/trunk/package
Author: spyffe
Date: Thu Jun 23 17:18:08 2016
New Revision: 273622
URL: http://llvm.org/viewvc/llvm-project?rev=273622&view=rev
Log:
Don't run the top-level expression test case with -gmodules.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExp
Author: spyffe
Date: Wed Jun 22 12:32:17 2016
New Revision: 273445
URL: http://llvm.org/viewvc/llvm-project?rev=273445&view=rev
Log:
Don't omit `this' from expression args if it couldn't be read, but warn loudly.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression
Author: spyffe
Date: Mon Jun 20 18:01:11 2016
New Revision: 273211
URL: http://llvm.org/viewvc/llvm-project?rev=273211&view=rev
Log:
Test that lldb calls the right 'printf' even when a 'printf' method exists.
This test is currently failing. We have a bug for it, as noted.
Added:
lldb/trunk/
1 - 100 of 260 matches
Mail list logo
