sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69
-SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16,
SveBFloat16Ty, 8, 16, false, false, true)
+SVE_VECTOR_TYPE("__SVBFloa
sdesmalen updated this revision to Diff 272342.
sdesmalen added a comment.
- Updated RUN line in tests to fix test failures.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82187/new/
https://reviews.llvm.org/D82187
Files:
clang/include/clang/Basic/AArch64SVEACLETypes.def
clang/inclu
sdesmalen created this revision.
sdesmalen added reviewers: stuij, efriedma, c-rhodes, fpetrogalli.
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, danielkiss,
psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added projects: clang, LLDB, LLVM.
sdesmalen added a parent
This revision was automatically updated to reflect the committed changes.
Closed by commit rG121e585ec8aa: [AArch64][SVE] ACLE: Add bfloat16 to struct
load/stores. (authored by sdesmalen).
Changed prior to commit:
https://reviews.llvm.org/D82187?vs=272342&id=272678#toc
Repository:
rG LLVM Gi
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
Thanks for all the changes, this patch LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77587/new/
https://reviews.llvm.org/D77587
_
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:411
SmallVector WhatToStore;
-if (ArgType->isFPOrFPVectorTy() &&
-(ArgType->getTypeID() != Type::VectorTyID)) {
+if (ArgType->isFPOrFPVectorTy()
sdesmalen added a comment.
Thanks for this patch @ctetreau! Overall looks great to me, just two little
nits.
Comment at: llvm/include/llvm/IR/DerivedTypes.h:436
+
+ static VectorType *get(Type *ElementType, const VectorType *Other) {
+return VectorType::get(ElementType, O
