[Lldb-commits] [libcxxabi] [lldb] [llvm] [WIP] [ItaniumDemangle] Add infrastructure to track location information of parts of a demangled function name (PR #133249)

@@ -6176,6 +6180,10 @@ struct ManglingParser : AbstractManglingParser, Alloc> { Alloc>::AbstractManglingParser; }; +inline void OutputBuffer::printLeft(const Node &N) { N.printLeft(*this); } zygoloid wrote: Thanks, yes. I agree

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

rsmith added a comment. I have no strong opinions on the merits of this patch in either direction; I think the "sorry"s in the Sema diagnostics for regrettable non-conformance make Clang marginally friendlier, but they do nothing to actually help people who encounter the diagnostic. FWIW, the

[Lldb-commits] [PATCH] D142733: Add _Optional as fast qualifier

rsmith added a comment. Including a link to the RFC (https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/68004/2) in each of the patches in this series would be helpful. Assuming that we want to go in this direction, it seems quite expensive to model this

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

rsmith added a comment. In D131858#3957630 , @arphaman wrote: > This change has caused a failure in Clang's stage 2 CI on the green dragon > Darwin CI: > https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. > > Assertion failed: (l

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

rsmith added a comment. Hi, the newly-added test, `TestDynamicLoaderDarwin.py`, fails under asan: https://gist.github.com/zygoloid/bf7b21f03d7db966e456b6c365c4635d Please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/ne

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

rsmith added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); This is not right -- libc+

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rsmith accepted this revision. rsmith added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

rsmith accepted this revision. rsmith added a comment. Looks good to me. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6504-6516 // If we have function pointer types, unify them anyway to unify their // exception specifications, if any. if (LTy->isFunctionPointerTyp

Re: [Lldb-commits] [lldb] eee687a - [lldb] Add minidump save-core functionality to ELF object files

The new test fails under MSan: Uninitialized bytes in __interceptor_write at offset 2 inside [0x7fb1f42ed000, 18438530) ==3871==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55f5706515d9 in RetryAfterSignal llvm-project/llvm/include/llvm/Support/Errno.h:38:11 #1 0x55f5706515d9

[Lldb-commits] [PATCH] D95164: Make SBDebugger::CreateTargetWithFileAndArch accept lldb.LLDB_DEFAULT_ARCH

rsmith added a comment. I reverted this and the follow-up fix in rG8b1171488575bd0b5ccb23bc1a3d22e2aaccb244 , because it's introduced several test failures. Example: http://lab.llvm.org:8011/#/builders/96/builds/3777 It appe

[Lldb-commits] [lldb] 4b57400 - [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

Author: Richard Smith Date: 2021-01-18T21:05:01-08:00 New Revision: 4b574008aef5a7235c1f894ab065fe300d26e786 URL: https://github.com/llvm/llvm-project/commit/4b574008aef5a7235c1f894ab065fe300d26e786 DIFF: https://github.com/llvm/llvm-project/commit/4b574008aef5a7235c1f894ab065fe300d26e786.diff

[Lldb-commits] [lldb] 856fd98 - Generalize regex matching std::string variants to compensate for recent

Author: Richard Smith Date: 2020-11-11T17:55:47-08:00 New Revision: 856fd98a176240470dcc2b8ad54b5c17ef6a75b3 URL: https://github.com/llvm/llvm-project/commit/856fd98a176240470dcc2b8ad54b5c17ef6a75b3 DIFF: https://github.com/llvm/llvm-project/commit/856fd98a176240470dcc2b8ad54b5c17ef6a75b3.diff

[Lldb-commits] [lldb] 2f95c50 - Fix use of wrong printf format specifier for size_t argument.

Author: Richard Smith Date: 2020-09-29T16:02:08-07:00 New Revision: 2f95c50a8b713970c5134dabc246270111a48c6d URL: https://github.com/llvm/llvm-project/commit/2f95c50a8b713970c5134dabc246270111a48c6d DIFF: https://github.com/llvm/llvm-project/commit/2f95c50a8b713970c5134dabc246270111a48c6d.diff

[Lldb-commits] [lldb] 825e3bb - PR46209: properly determine whether a copy assignment operator is

Author: Richard Smith Date: 2020-06-05T16:05:32-07:00 New Revision: 825e3bb58082eafa8db87a9034379b88f892ce9d URL: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d DIFF: https://github.com/llvm/llvm-project/commit/825e3bb58082eafa8db87a9034379b88f892ce9d.diff

Re: [Lldb-commits] [clang] c13dd74 - Set the captures on a CXXRecordDecl representing a lambda closure type

x in 825e3bb58082eafa8db87a9034379b88f892ce9d. > Thanks, > Jonas > > > > On Thu, Jun 4, 2020 at 7:25 PM Richard Smith via cfe-commits < > cfe-comm...@lists.llvm.org> wrote: > >> >> Author: Richard Smith >> Date: 2020-06-04T19:19:01-07:00 >> New

[Lldb-commits] [lldb] r373685 - Properly handle instantiation-dependent array bounds.

Author: rsmith Date: Thu Oct 3 18:25:59 2019 New Revision: 373685 URL: http://llvm.org/viewvc/llvm-project?rev=373685&view=rev Log: Properly handle instantiation-dependent array bounds. We previously failed to treat an array with an instantiation-dependent but not value-dependent bound as being

[Lldb-commits] [lldb] r371817 - For PR17164: split -fno-lax-vector-conversion into three different

Author: rsmith Date: Thu Sep 12 23:02:15 2019 New Revision: 371817 URL: http://llvm.org/viewvc/llvm-project?rev=371817&view=rev Log: For PR17164: split -fno-lax-vector-conversion into three different levels: -- none: no lax vector conversions [new GCC default] -- integer: only conversions betwe

Re: [Lldb-commits] [lldb] r361565 - [lldb] followup fix for https://reviews.llvm.org/D62305

On Thu, 23 May 2019 at 15:39, Konrad Kleine via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: kwk > Date: Thu May 23 15:39:13 2019 > New Revision: 361565 > > URL: http://llvm.org/viewvc/llvm-project?rev=361565&view=rev > Log: > [lldb] followup fix for https://reviews.llvm.org/D62305

[Lldb-commits] [lldb] r360312 - Fix up lldb after clang r360311.

Author: rsmith Date: Wed May 8 21:40:57 2019 New Revision: 360312 URL: http://llvm.org/viewvc/llvm-project?rev=360312&view=rev Log: Fix up lldb after clang r360311. Patch by Tyker! Differential Revision: https://reviews.llvm.org/D60934 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp

[Lldb-commits] [lldb] r354185 - Temporarily disable test:

Author: rsmith Date: Fri Feb 15 16:13:26 2019 New Revision: 354185 URL: http://llvm.org/viewvc/llvm-project?rev=354185&view=rev Log: Temporarily disable test: test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py It fails on Mac OS; apparently a VarDecl 'void *&C' is impl

[Lldb-commits] [lldb] r354173 - Fix AST generated for a class template to connect the class inside a

Author: rsmith Date: Fri Feb 15 13:48:09 2019 New Revision: 354173 URL: http://llvm.org/viewvc/llvm-project?rev=354173&view=rev Log: Fix AST generated for a class template to connect the class inside a class template back to the template. Previously, when the ASTImporter imported the class, it di

[Lldb-commits] [lldb] r331406 - Use conventional spelling of always-failing assert.

Author: rsmith Date: Wed May 2 15:21:11 2018 New Revision: 331406 URL: http://llvm.org/viewvc/llvm-project?rev=331406&view=rev Log: Use conventional spelling of always-failing assert. Fixes -Wstring-conversion warning that was breaking -Werror builds. Modified: lldb/trunk/source/Core/Module

[Lldb-commits] [lldb] r331323 - Update lldb to match clang r331244 (addition of char8_t).

Author: rsmith Date: Tue May 1 19:43:22 2018 New Revision: 331323 URL: http://llvm.org/viewvc/llvm-project?rev=331323&view=rev Log: Update lldb to match clang r331244 (addition of char8_t). Also fix misclassification of char16_t and char32_t: these are unsigned types, not signed types. Modified

[Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

rsmith added a comment. In https://reviews.llvm.org/D39307#907358, @xiaobai wrote: > It seems like clang shouldn't even be asking us about this in the first > place, but I don't fully understand why it's trying to do what it's trying to > do. It looks like there are two issues here: clang is

[Lldb-commits] [lldb] r301483 - Update lldb to match clang r301442.

Author: rsmith Date: Wed Apr 26 17:10:53 2017 New Revision: 301483 URL: http://llvm.org/viewvc/llvm-project?rev=301483&view=rev Log: Update lldb to match clang r301442. This code really doesn't make any sense: there is only ever one InputKind here. Plus, this is an incomplete and out-of-date copy

[Lldb-commits] [lldb] r291738 - Update to match clang r291737.

Author: rsmith Date: Wed Jan 11 20:37:54 2017 New Revision: 291738 URL: http://llvm.org/viewvc/llvm-project?rev=291738&view=rev Log: Update to match clang r291737. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp Modified: lldb/trunk/source/Plugins/Express

Re: [Lldb-commits] [PATCH] D18530: Move some functions from ClangASTContext to ClangUtil

rsmith added a comment. In http://reviews.llvm.org/D18530#387230, @zturner wrote: > I'm curious now what clang does in this regard, so +rsmith in case he has > some insight into what happens in clang when someone wants to re-organize > some code and how other downstream customers (for example,

[Lldb-commits] [lldb] r245397 - Fix LLDB after Clang r245346.

Author: rsmith Date: Tue Aug 18 20:05:34 2015 New Revision: 245397 URL: http://llvm.org/viewvc/llvm-project?rev=245397&view=rev Log: Fix LLDB after Clang r245346. The right thing to do here would be to give the ASTConsumer to the CompilerInstance so it can set things up for us, but we can't do th

[Lldb-commits] [lldb] r244194 - Update lldb's ExternalASTSources to match Clang r244161.

Author: rsmith Date: Thu Aug 6 00:13:41 2015 New Revision: 244194 URL: http://llvm.org/viewvc/llvm-project?rev=244194&view=rev Log: Update lldb's ExternalASTSources to match Clang r244161. Modified: lldb/trunk/include/lldb/Expression/ClangASTSource.h lldb/trunk/include/lldb/Symbol/ClangE