Honsik added a comment.
Yes please, with that comment change jingham has mentioned.
Do you want me to create new diff?
http://reviews.llvm.org/D17635
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Honsik updated this revision to Diff 50373.
Honsik added a comment.
Sorry for the delay, I have been on holiday.
I have modified the patch as jingham requested. The public run lock is reset
back on error in both Resume and ResumeSynchronous methods.
http://reviews.llvm.org/D17635
Files:
pa
Honsik updated this revision to Diff 49258.
Honsik added a comment.
OK I have modified the PrivateResume to add the check and release the public
running lock.
http://reviews.llvm.org/D17635
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBrea
Honsik added a comment.
I tried to put this check in PrivateResume, but its not that simple because of
the public RUN lock. I am not that sure if it is safe to always unclock the
lock inside PrivateResume.
http://reviews.llvm.org/D17635
___
lldb-c
Honsik created this revision.
Honsik added a reviewer: zturner.
Honsik added a subscriber: lldb-commits.
When process exits, and SBProcess.Continue() is executed, timeout occurs
(5secs). Instead error message "Process is not alive" is returned. Added test
for this message.
Fix of breakpoint cas
Honsik added a comment.
I have generated it against master branch. I used git reset HEAD~1, modified,
commited and created patch.
Maybe the problem was I used the Arcanist for the first diff and then I used
web interface, as you have suggested.
http://reviews.llvm.org/D17492
__
Honsik added a comment.
The testsuite passed the same way as master, but no UNEXPECTED SUCCESS.
Please fix the miss spelling directly.
Thanks.
Comment at: source/Host/common/FileSpec.cpp:517
@@ -511,2 +516,2 @@
// If full is false, then if either directory is empty, then
Honsik added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:288-294
@@ -288,1 +287,9 @@
+
+if sys.platform.startswith('win32'):
+import ctypes, time
+while not ctypes.windll.kernel32.IsDebuggerPresent():
+
Honsik updated the summary for this revision.
Honsik updated this revision to Diff 48871.
Honsik added a comment.
I added requested changes.
http://reviews.llvm.org/D17492
Files:
include/lldb/Core/ConstString.h
include/lldb/Host/FileSpec.h
packages/Python/lldbsuite/test/functionalities/b
Honsik added a comment.
Hello, newcomer here.
Thanks zturner for you support.
Shouldn't best workflow for VS also be mentioned? Like one solution for code
editing generated by CMake -G "Visual Studio 14" that lacks directory structure
(mostly CMake + VS issue) and another with custom project co
10 matches
Mail list logo
