nilanjana_basu updated this revision to Diff 210142.
nilanjana_basu added a comment.
Added record kind name in the comments for better readability
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64536/new/
https://reviews.llvm.org/D64536
Files:
llvm/include/llvm/
nilanjana_basu updated this revision to Diff 210123.
nilanjana_basu added a comment.
Corrected comments for codeview type record from "NumAttributes" to
"AccessSpecifier"
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64536/new/
https://reviews.llvm.org/D64536
Fi
nilanjana_basu marked 2 inline comments as done.
nilanjana_basu added inline comments.
Comment at: llvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h:63
- Error mapInteger(TypeIndex &TypeInd);
+ Error mapInteger(TypeIndex &TypeInd, const char* Comment = nullptr);
-
nilanjana_basu updated this revision to Diff 209278.
nilanjana_basu added a comment.
Herald added subscribers: lldb-commits, abidh.
Herald added a project: LLDB.
String parameter passing is done using Twine instead of using C strings, as
suggested in the review
Repository:
rLLDB LLDB
CHANGES
