[Lldb-commits] [clang-tools-extra] [libunwind] [libcxx] [llvm] [libc] [mlir] [compiler-rt] [lldb] [clang] [flang] [lld] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do

minglotus-6 wrote: I created a [branch](https://github.com/minglotus-6/llvm-project/tree/type_profile) and submitted the end-to-end implementation there. Besides (a [squashed version](https://github.com/llvm/llvm-project/commit/de71eacf04a236031be6f1b53168f8f566244297) of) this pull request,

[Lldb-commits] [libunwind] [lldb] [llvm] [libc] [clang-tools-extra] [compiler-rt] [flang] [clang] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: And pushed https://github.com/llvm/llvm-project/pull/76005 to require 64-bit systems for IR test. Raw profile reader swaps byte orders properly so `REQUIRES: host-byteorder-little-endian` looks actually unnecessary but will keep it fwiw for now. I feel sorry for dance aroun

[Lldb-commits] [clang] [lldb] [libunwind] [libc] [clang-tools-extra] [compiler-rt] [llvm] [flang] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: > I'm seeing spurious failures from big-endian systems. I'll revert and > investigate a fix. I ended up sending a fix forward in https://github.com/llvm/llvm-project/pull/76001 . Will monitor the build-bots. https://github.com/llvm/llvm-project/pull/75954 __

[Lldb-commits] [clang] [libc] [flang] [lldb] [clang-tools-extra] [libunwind] [llvm] [compiler-rt] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: I'm seeing spurious failures from big-endian systems. I'll revert and investigate a fix. https://github.com/llvm/llvm-project/pull/75954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [compiler-rt] [lldb] [llvm] [libunwind] [clang] [flang] [clang-tools-extra] [libc] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: > It fails here https://lab.llvm.org/buildbot/#/builders/18/builds/13216 thanks for the report. I marked the two relevant tests as `UNSUPPORTED` in [commit 85525f8](https://github.com/llvm/llvm-project/commit/85525f8fb6740a4cc117b00a238c85bda4ea01bf). Will need to investiga

[Lldb-commits] [clang-tools-extra] [libunwind] [lldb] [libc] [llvm] [clang] [compiler-rt] [flang] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

https://github.com/minglotus-6 closed https://github.com/llvm/llvm-project/pull/75954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [lldb] [clang-tools-extra] [compiler-rt] [flang] [llvm] [clang] [libunwind] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: I'll go ahead and push it since the diff is test only. https://github.com/llvm/llvm-project/pull/75954 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [libc] [lldb] [libunwind] [llvm] [clang-tools-extra] [compiler-rt] [clang] [mlir] [lld] [libcxx] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do

minglotus-6 wrote: > After this patch, follow up with a patch documenting raw and index format. > This has long being requested by many in the community. Sure, I'm working on an `rst` doc and would like to focus on the PGO profile format (while compiler-rt infrastructure supports other use cas

[Lldb-commits] [llvm] [lldb] [flang] [clang-tools-extra] [compiler-rt] [libunwind] [libc] [clang] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

minglotus-6 wrote: The diff of this reland compared with the 1st reland is clearer in this commit (https://github.com/llvm/llvm-project/pull/75954/commits/cca510e569e9325ec089974e006eb2a8e2d0a2a7) https://github.com/llvm/llvm-project/pull/75954 ___ ll

[Lldb-commits] [llvm] [lldb] [flang] [clang-tools-extra] [compiler-rt] [libunwind] [libc] [clang] Reland the reland "[PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delim

https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/75954 >From 4936920fbbe5e70a47be35b057200de3b07a087f Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 18 Dec 2023 20:21:40 -0800 Subject: [PATCH 1/2] Reapply "Reland "[PGO][GlobalValue][LTO]In GlobalValues::get

[Lldb-commits] [libc] [compiler-rt] [lldb] [llvm] [lld] [libcxx] [flang] [clang-tools-extra] [libunwind] [mlir] [clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do

minglotus-6 wrote: Three tests failed on the windows build-bot (https://buildkite.com/llvm-project/github-pull-requests/builds/20392#018c3c8d-d4fd-41f7-b456-b1a4ded6dc61). Two (Transforms/PGOProfile/vtable_profile.ll and tools/llvm-profdata/vtable-value-prof-basic.test) of these three passed i

[Lldb-commits] [lld] [llvm] [lldb] [clang-tools-extra] [libcxx] [libunwind] [mlir] [libc] [clang] [compiler-rt] [flang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do

@@ -453,11 +471,94 @@ Error InstrProfSymtab::create(Module &M, bool InLTO) { if (Error E = addFuncWithName(F, getPGOFuncName(F, InLTO))) return E; } + + SmallVector Types; + for (GlobalVariable &G : M.globals()) { +if (!G.hasName()) + continue; +Types

[Lldb-commits] [lldb] [clang] [mlir] [compiler-rt] [libc] [flang] [libunwind] [llvm] [lld] [libcxx] [clang-tools-extra] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do

minglotus-6 wrote: > One heads up, the latest 'git merge main' brings a failure in test > https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/fuzzer/gc-sections.test > :( . `ninja check-all` on a clean main gives the same failure. Hopefully it > would be fixed soon. This is fixed