[Lldb-commits] [PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

2023-08-29 Thread Mikhail Goncharov via Phabricator via lldb-commits
goncharov added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform ldionne wrote: > goncharov wrote: > > do I understa

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

2022-06-27 Thread Mikhail Goncharov via Phabricator via lldb-commits
goncharov added a comment. FYI this caused a test breakage at lldb-aarch64-ubuntu, https://lab.llvm.org/buildbot/#/builders/96/builds/25128. I have reverted this in fe6db8d03ff16a65f57af24d2cb04f489e2e9b0c Repository: rG

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

2021-02-22 Thread Mikhail Goncharov via Phabricator via lldb-commits
goncharov added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-76 """ -if "LLDB_DEBUGSERVER_PATH" in os.environ: -return os.environ["LLDB_DEBUGSERVER_PATH"] hi @labath ! Sorry for ig

[Lldb-commits] [PATCH] D91504: [lldb] Use translated full ftag values

2020-11-19 Thread Mikhail Goncharov via Phabricator via lldb-commits
goncharov added a comment. Herald added a subscriber: JDevlieghere. Hi @mgorny! http://lab.llvm.org:8011/#/builders/68/builds/2298 build failed. Could you please fix the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://review