[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

glandium added a comment. I haven't tested this patch, but it looks like it contains everything that unbreaks our builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ https://reviews.llvm.org/D151344 _

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. So the problem is that `CMakePolicy.cmake` is not included in `compiler-rt/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 _

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. It's related, though, because now that I look at my build logs, the difference between when it works and when it doesn't is `/MT` vs `-MD` when compiler-rt is compiled. The main peculiarity on our end, though, is that the Windows compiler-rt is cross-compiled. Reposi

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4347604 , @mstorsjo wrote: > See D150688 - I believe that might fix the > issue you're seeing, as that one mentions compiler-rt. Unfortunately, it doesn't. FWIW, the errors looks l

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. Herald added subscribers: bviyer, ekilmer, jplehr. FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c is causing problems on Windows compiler-rt for some reason I haven't identified yet (with cmake 3.25.1

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Almost there, but not quite: [task 2022-11-22T23:55:36.341Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1106:6: error: no matching function for call to object of type '(lambda at /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugi

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. Still broken: task 2022-11-22T22:09:00.912Z] /usr/lib/llvm-11/bin/clang++ --sysroot=/builds/worker/fetches/sysroot -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/gold -I/builds/worker/fetches/llvm-proje

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

glandium added a comment. This broke the gold plugin: [task 2022-11-22T21:03:29.486Z] /builds/worker/fetches/llvm-project/llvm/tools/gold/gold-plugin.cpp:1108:19: error: no matching function for call to 'localCache' [task 2022-11-22T21:03:29.486Z] Cache = check(localCache("ThinLTO", "T

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) thieta wrote: > glandium wrote: > >

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

glandium added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) You didn't update llvm/cmake/platfo

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. In D112374#3651218 , @mizvekov wrote: > Can you confirm that this `NoPrincipalGetURI` matcher would, in clang version > without this patch here, fail to match if you had rewritten the `GetUri` > method to use a qualified name?

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

glandium added a comment. FWIW, this change also broke this check in Firefox's clang plugin: https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev