[Lldb-commits] [PATCH] D74892: [lldb][cmake] Also use local submodule visibility on Darwin

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74892/new/ https://reviews.llvm.org/D74892 ___ lldb-c

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

Bigcheese added a comment. This looks like a good simplification, but I think `call_once` could be simplified more. Comment at: llvm/cmake/modules/CheckAtomic.cmake:46 + if (NOT HAVE_ATOMICS_WITH_LIB) + message(FATAL_ERROR "Host compiler must support atomic!")