[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

nidefawl added a comment. In D123025#3429896 , @wallace wrote: > Let me know if you need help upstreaming this patch. Yes I needs some help. This is my first contribution. I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

nidefawl marked 2 inline comments as done. nidefawl added inline comments. Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:55 } - callback(StringRef(buffer, bytes_count).str()); + callback(StringRef(buffer, bytes_count)); } mstorsjo

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

nidefawl updated this revision to Diff 420531. nidefawl added a comment. Reorder OS check to remove negation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123025/new/ https://reviews.llvm.org/D123025 Files: lldb/tools/lldb-vscode/OutputRedirecto

[Lldb-commits] [PATCH] D123025: [lldb-vscode] Implement stderr/stdout on win32 and redirect lldb log to VSCode

nidefawl created this revision. nidefawl added a reviewer: wallace. nidefawl added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. nidefawl requested review of this revision. Herald added a subscriber: lldb-commits. This patch implements stderr/stdout forward